From: Rob Herring <robh@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: frowand.list@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] of: property: lower loglevel of of_graph_get_next_endpoint
Date: Fri, 1 Mar 2024 15:03:26 -0600 [thread overview]
Message-ID: <20240301210326.GA3020204-robh@kernel.org> (raw)
In-Reply-To: <20240223104721.4140880-1-m.felsch@pengutronix.de>
On Fri, Feb 23, 2024 at 11:47:21AM +0100, Marco Felsch wrote:
> Drivers like the tcpm.c do search for a remote endpoint on different
> places to be dt-bindings compatible. The search is done on the device
> itself or on the child fwnode in case it was not found the first time.
>
> This indicates that not finding the remote endpoint at the first try is
> a valid use-case and should not cause an error printing.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Hi,
>
> I'm not 100% certain if this is the correct place but if our platform
> follows the dt-bindings we receive
>
> | OF: graph: no port node found in /soc@0/bus@30800000/i2c@30a30000/tcpc@50
>
> a few times because of the below pr_err() and EPROBE_DEFER.
>
> Regards,
> Marco
>
> drivers/of/property.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 641a40cf5cf3..155df04a9512 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -665,7 +665,7 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
> of_node_put(node);
>
> if (!port) {
> - pr_err("graph: no port node found in %pOF\n", parent);
> + pr_notice("graph: no port node found in %pOF\n", parent);
Already changed to pr_debug.
Rob
next prev parent reply other threads:[~2024-03-01 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 10:47 [PATCH] of: property: lower loglevel of of_graph_get_next_endpoint Marco Felsch
2024-03-01 21:03 ` Rob Herring [this message]
2024-03-04 7:37 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301210326.GA3020204-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.