From: Josef Bacik <josef@toxicpanda.com>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: fiemap fix and optimization
Date: Fri, 1 Mar 2024 16:06:54 -0500 [thread overview]
Message-ID: <20240301210654.GA2112259@perftesting> (raw)
In-Reply-To: <cover.1709202499.git.fdmanana@suse.com>
On Thu, Feb 29, 2024 at 11:56:20AM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> One more fix for a regression introduced recently introduced to fiemap,
> which can actually have serious consequences, as explained in the change
> log of the first patch. The other is just a small optimization.
> More details in the change logs.
>
> Filipe Manana (2):
> btrfs: fix race when detecting delalloc ranges during fiemap
> btrfs: reuse cloned extent buffer during fiemap to avoid re-allocations
>
> fs/btrfs/extent_io.c | 253 +++++++++++++++++++++++++++++++------------
> 1 file changed, 184 insertions(+), 69 deletions(-)
>
Man I just made a whole mess of this whole thing. I didn't take into account
the cloned leaf buffer thing. I really hate our reliance on the extent lock to
protect so much vood here, but in the end I don't think there's much we can do
about it.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
prev parent reply other threads:[~2024-03-01 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 11:56 [PATCH 0/2] btrfs: fiemap fix and optimization fdmanana
2024-02-29 11:56 ` [PATCH 1/2] btrfs: fix race when detecting delalloc ranges during fiemap fdmanana
2024-02-29 11:56 ` [PATCH 2/2] btrfs: reuse cloned extent buffer during fiemap to avoid re-allocations fdmanana
2024-03-01 21:06 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301210654.GA2112259@perftesting \
--to=josef@toxicpanda.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.