From: kernel test robot <lkp@intel.com>
To: jasperwang@tencent.com, kaixuxia@tencent.com,
frankjpliu@tencent.com, kasong@tencent.com,
sagazchen@tencent.com, kernelxing@tencent.com,
aurelianliu@tencent.com, jason.zeng@intel.com,
wu.zheng@intel.com, yingbao.jia@intel.com, pei.p.jia@intel.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [opencloudos:next 86/98] kernel/sched/psi.c:272:1: warning: control reaches end of non-void function
Date: Sat, 2 Mar 2024 05:55:08 +0800 [thread overview]
Message-ID: <202403020559.Porpme18-lkp@intel.com> (raw)
tree: https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git next
head: a4b2dc2ffad1810ebe7a86710aa1e5cc312aa2a1
commit: 5ad399e959efe7243d5e3c8afc13d249c607746a [86/98] psi: support cgroup v1 psi accounting
config: x86_64-buildonly-randconfig-002-20240302 (https://download.01.org/0day-ci/archive/20240302/202403020559.Porpme18-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240302/202403020559.Porpme18-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403020559.Porpme18-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/smp.h:12,
from include/linux/sched/clock.h:5,
from kernel/sched/build_utility.c:12:
kernel/sched/psi.c: In function 'psi_use_legacy':
kernel/sched/psi.c:267:31: error: 'memory_cgrp_subsys_on_dfl_key' undeclared (first use in this function); did you mean 'debug_cgrp_subsys_on_dfl_key'?
267 | !cgroup_subsys_on_dfl(memory_cgrp_subsys) &&
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:76:40: note: in definition of macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:508:34: note: in expansion of macro 'likely_notrace'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:508:49: note: in expansion of macro 'static_key_enabled'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
include/linux/cgroup.h:97:2: note: in expansion of macro 'static_branch_likely'
97 | static_branch_likely(&ss ## _on_dfl_key)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:267:10: note: in expansion of macro 'cgroup_subsys_on_dfl'
267 | !cgroup_subsys_on_dfl(memory_cgrp_subsys) &&
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:267:31: note: each undeclared identifier is reported only once for each function it appears in
267 | !cgroup_subsys_on_dfl(memory_cgrp_subsys) &&
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:76:40: note: in definition of macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:508:34: note: in expansion of macro 'likely_notrace'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:508:49: note: in expansion of macro 'static_key_enabled'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
include/linux/cgroup.h:97:2: note: in expansion of macro 'static_branch_likely'
97 | static_branch_likely(&ss ## _on_dfl_key)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:267:10: note: in expansion of macro 'cgroup_subsys_on_dfl'
267 | !cgroup_subsys_on_dfl(memory_cgrp_subsys) &&
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:268:31: error: 'io_cgrp_subsys_on_dfl_key' undeclared (first use in this function); did you mean 'misc_cgrp_subsys_on_dfl_key'?
268 | !cgroup_subsys_on_dfl(io_cgrp_subsys);
| ^~~~~~~~~~~~~~
include/linux/compiler.h:76:40: note: in definition of macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:508:34: note: in expansion of macro 'likely_notrace'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:508:49: note: in expansion of macro 'static_key_enabled'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
include/linux/cgroup.h:97:2: note: in expansion of macro 'static_branch_likely'
97 | static_branch_likely(&ss ## _on_dfl_key)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:268:10: note: in expansion of macro 'cgroup_subsys_on_dfl'
268 | !cgroup_subsys_on_dfl(io_cgrp_subsys);
| ^~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/build_utility.c:97:
kernel/sched/psi.c: In function 'psi_group_change_legacy':
kernel/sched/psi.c:936:40: error: 'io_cgrp_subsys' undeclared (first use in this function); did you mean 'misc_cgrp_subsys'?
936 | group = cgroup_psi(task_cgroup(task, io_cgrp_subsys.id));
| ^~~~~~~~~~~~~~
| misc_cgrp_subsys
kernel/sched/psi.c:943:40: error: 'memory_cgrp_subsys' undeclared (first use in this function); did you mean 'debug_cgrp_subsys'?
943 | group = cgroup_psi(task_cgroup(task, memory_cgrp_subsys.id));
| ^~~~~~~~~~~~~~~~~~
| debug_cgrp_subsys
kernel/sched/psi.c: In function 'psi_use_legacy':
>> kernel/sched/psi.c:272:1: warning: control reaches end of non-void function [-Wreturn-type]
272 | }
| ^
vim +272 kernel/sched/psi.c
262
263 static inline bool psi_use_legacy(void)
264 {
265 #ifdef CONFIG_CGROUPS
266 return !cgroup_subsys_on_dfl(cpu_cgrp_subsys) &&
267 !cgroup_subsys_on_dfl(memory_cgrp_subsys) &&
268 !cgroup_subsys_on_dfl(io_cgrp_subsys);
269 #else
270 return false;
271 #endif
> 272 }
273
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-03-01 21:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403020559.Porpme18-lkp@intel.com \
--to=lkp@intel.com \
--cc=aurelianliu@tencent.com \
--cc=frankjpliu@tencent.com \
--cc=jason.zeng@intel.com \
--cc=jasperwang@tencent.com \
--cc=kaixuxia@tencent.com \
--cc=kasong@tencent.com \
--cc=kernelxing@tencent.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pei.p.jia@intel.com \
--cc=sagazchen@tencent.com \
--cc=wu.zheng@intel.com \
--cc=yingbao.jia@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.