From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>,
"fw@strlen.de" <fw@strlen.de>,
"davem@davemloft.net" <davem@davemloft.net>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net v2] netfilter: Add protection for bmp length out of range
Date: Sat, 2 Mar 2024 12:52:41 +0100 [thread overview]
Message-ID: <20240302115241.GA7494@breakpoint.cc> (raw)
In-Reply-To: <ZeL1_-Pdq6Kw0NIO@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > + if (f->sz > 32)
> > + return H323_ERROR_RANGE;
>
> Could you possibly place this in get_bitmap()? IIRC these are the only
> two calls to this function.
How would you signal the error? I think this patch is fine as-is.
next prev parent reply other threads:[~2024-03-02 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:12 [PATCH net v2] netfilter: Add protection for bmp length out of range Lena Wang (王娜)
2024-03-01 15:29 ` Jiri Pirko
2024-03-02 9:48 ` Pablo Neira Ayuso
2024-03-02 11:52 ` Florian Westphal [this message]
2024-03-04 12:41 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302115241.GA7494@breakpoint.cc \
--to=fw@strlen.de \
--cc=Lena.Wang@mediatek.com \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.