From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Zhihong Wang" <wangzhihong.wzh@bytedance.com>,
"Yuanhan Liu" <yliu@fridaylinux.org>,
"Xiaoyun Li" <xiaoyun.li@intel.com>
Subject: Re: [PATCH] rte_memcpy: fix off by one for size 16 and 32
Date: Sat, 2 Mar 2024 12:56:47 -0800 [thread overview]
Message-ID: <20240302125647.63ef6aec@hermes.local> (raw)
In-Reply-To: <20240302204923.227105-1-stephen@networkplumber.org>
On Sat, 2 Mar 2024 12:49:23 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The rte_memcpy code would do extra instructions for size 16
> and 32 which potentially could reference past end of data.
>
> For size of 16, only single mov16 is needed.
> same for size of 32, only single mov32.
>
> Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86")
> Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
>
> Suggested-by: Morten Brørup <mb@smartsharesystems.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Self-NAK, more is needed here.
The code has lots of pre-existing bugs where it will reference past the end
of the data in some cases.
next prev parent reply other threads:[~2024-03-02 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 20:49 [PATCH] rte_memcpy: fix off by one for size 16 and 32 Stephen Hemminger
2024-03-02 20:56 ` Stephen Hemminger [this message]
2024-03-02 22:10 ` Morten Brørup
2024-03-03 6:46 ` Mattias Rönnblom
2024-03-02 23:57 ` Morten Brørup
2024-03-03 6:47 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302125647.63ef6aec@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=wangzhihong.wzh@bytedance.com \
--cc=xiaoyun.li@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.