From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/9] package/policycoreutils: bump version to 3.6
Date: Sat, 2 Mar 2024 18:10:19 +0100 [thread overview]
Message-ID: <20240302181019.43115635@windsurf> (raw)
In-Reply-To: <20240226205446.842600-4-adam.duskett@amarulasolutions.com>
Hello Adam,
On Mon, 26 Feb 2024 13:54:40 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> setsebool/Makefile now unconditionally links against libsepol.
> As such, it is now a new dependency.
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
Some minor nit I would have fixed myself when applying, but since a v2
will be needed due to the PATCH 3/9 issue, here is a very minor comment.
> ---
> package/policycoreutils/Config.in | 1 +
> package/policycoreutils/policycoreutils.hash | 2 +-
> package/policycoreutils/policycoreutils.mk | 4 ++--
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/policycoreutils/Config.in b/package/policycoreutils/Config.in
> index 3201c8fede..46a367129a 100644
> --- a/package/policycoreutils/Config.in
> +++ b/package/policycoreutils/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_POLICYCOREUTILS
> depends on !BR2_STATIC_LIBS # libsemanage
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libsemanage -> libselinux -> libsepol
> select BR2_PACKAGE_LIBSEMANAGE
> + select BR2_PACKAGE_LIBSEPOL
Would be nice to update the depends on comments:
depends on BR2_TOOLCHAIN_HAS_THREADS # libsemanage, libsepol
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libsemanage, libsepol
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-03-02 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 20:54 [Buildroot] [PATCH 1/9] package/libsepol: bump to version 3.6 Adam Duskett
2024-02-26 20:54 ` [Buildroot] [PATCH 2/9] package/libsemanage: bump version to 3.6 Adam Duskett
2024-02-26 20:54 ` [Buildroot] [PATCH 3/9] package/libselinux: " Adam Duskett
2024-03-02 17:07 ` Thomas Petazzoni via buildroot
2024-02-26 20:54 ` [Buildroot] [PATCH 4/9] package/policycoreutils: " Adam Duskett
2024-03-02 17:10 ` Thomas Petazzoni via buildroot [this message]
2024-02-26 20:54 ` [Buildroot] [PATCH 5/9] package/checkpolicy: " Adam Duskett
2024-02-26 20:54 ` [Buildroot] [PATCH 6/9] package/restorecond: " Adam Duskett
2024-02-26 20:54 ` [Buildroot] [PATCH 7/9] package/semodule-utils: " Adam Duskett
2024-02-26 20:54 ` [Buildroot] [PATCH 8/9] package/selinux-python: " Adam Duskett
2024-02-26 20:54 ` [Buildroot] [PATCH 9/9] package/setools: bump version to 4.4.4 Adam Duskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302181019.43115635@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.