From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [linux-next:master 9115/11394] drivers/gpu/drm/xe/xe_ggtt.c:256 ggtt_invalidate_gt_tlb() warn: variable dereferenced before check 'gt' (see line 253)
Date: Sun, 3 Mar 2024 14:03:24 +0800 [thread overview]
Message-ID: <202403031315.uPyTvJYB-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Matthew Brost <matthew.brost@intel.com>
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 1870cdc0e8dee32e3c221704a2977898ba4c10e8
commit: 3121fed0c51beb8ea7b18ab2ceff1ac9e358ac53 [9115/11394] drm/xe: Cleanup some layering in GGTT
:::::: branch date: 2 days ago
:::::: commit date: 8 days ago
config: x86_64-randconfig-161-20240302 (https://download.01.org/0day-ci/archive/20240303/202403031315.uPyTvJYB-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202403031315.uPyTvJYB-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/xe/xe_ggtt.c:256 ggtt_invalidate_gt_tlb() warn: variable dereferenced before check 'gt' (see line 253)
vim +/gt +256 drivers/gpu/drm/xe/xe_ggtt.c
dd08ebf6c3525a Matthew Brost 2023-03-30 250
d78a4778195079 Matt Roper 2023-06-01 251 static void ggtt_invalidate_gt_tlb(struct xe_gt *gt)
dd08ebf6c3525a Matthew Brost 2023-03-30 252 {
3121fed0c51beb Matthew Brost 2024-02-22 @253 struct xe_device *xe = gt_to_xe(gt);
3121fed0c51beb Matthew Brost 2024-02-22 254 int err;
3121fed0c51beb Matthew Brost 2024-02-22 255
d78a4778195079 Matt Roper 2023-06-01 @256 if (!gt)
d78a4778195079 Matt Roper 2023-06-01 257 return;
ad703e06376d5d Matt Roper 2023-06-01 258
933b78d678213f Matt Roper 2023-06-01 259 /*
933b78d678213f Matt Roper 2023-06-01 260 * Invalidation can happen when there's no in-flight work keeping the
933b78d678213f Matt Roper 2023-06-01 261 * GT awake. We need to explicitly grab forcewake to ensure the GT
933b78d678213f Matt Roper 2023-06-01 262 * and GuC are accessible.
933b78d678213f Matt Roper 2023-06-01 263 */
933b78d678213f Matt Roper 2023-06-01 264 xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
3121fed0c51beb Matthew Brost 2024-02-22 265 err = xe_gt_tlb_invalidation_ggtt(gt);
3121fed0c51beb Matthew Brost 2024-02-22 266 if (err)
3121fed0c51beb Matthew Brost 2024-02-22 267 drm_warn(&xe->drm, "xe_gt_tlb_invalidation_ggtt error=%d", err);
933b78d678213f Matt Roper 2023-06-01 268 xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
dd08ebf6c3525a Matthew Brost 2023-03-30 269 }
dd08ebf6c3525a Matthew Brost 2023-03-30 270
:::::: The code at line 256 was first introduced by commit
:::::: d78a4778195079e0b2820550efeecb7b25fa764a drm/xe: Invalidate TLB on all affected GTs during GGTT updates
:::::: TO: Matt Roper <matthew.d.roper@intel.com>
:::::: CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-03-03 6:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403031315.uPyTvJYB-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.