From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B87D067A1C for ; Sun, 3 Mar 2024 15:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709479258; cv=none; b=R+pbFiGT6h7ajxt8cjnUUpwlM48SS4by34zrHkD5Y5N9PDFgYkRClpXcU3EfsMJZG6kwaKJEaeKdlu4a+M7/OyOYJswdxVekM6vsK/Epk+pwLl3wPpVfqjK8Qax8NqTfCMklQ5+EQBPZkWcgAVtuJk5F7Igd+ul29zzjW+LUugs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709479258; c=relaxed/simple; bh=qQsHhhyZSLunijRqrueQaWzmyOOeSwu9cJMm/kra/Nc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Wmki+VWX5Rz4k6S/PVnt3f9HVWrG86OMdVvqaF+bhvKd6fByeJBpaj4x5O8cV2d1s+YPVjF/SadpSMAAzcrB4K9KJiPUQmvsPAar9UycIDT2YvzAbiZAv7aiPtjssIc/H5SzYa0gRrTFj/gGRIr7zu4qsNNOdaxQECvqIIkH16c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T4ZZY+Wj; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T4ZZY+Wj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709479256; x=1741015256; h=date:from:to:cc:subject:message-id:mime-version; bh=qQsHhhyZSLunijRqrueQaWzmyOOeSwu9cJMm/kra/Nc=; b=T4ZZY+WjoeNzM9yHoBDo7tFLay3WWZjT945YdJYgINLOwX7ObG4YbyD/ It0ws/FB0FZ1L0psb4SrFeU5eukXS60uziwJiDpmNshEfivm6ndQR+eTn XaQsXfcAFDKhZJgp5/R/Chta1YVo9MW9DQ6hv+p70VYi3vDiv+Db+bpFp qaDTrlOZu6BILnurAMkFzaNWVz0J+oEqGXznovSHmLJNs/z76cVXL9LRo c9I7SZdnZ/4mjGNClOG2YOOhvXf9yI+QHVtM+6XFv+/9PjVNMS3KBvUuz Tq24N/MCtsmiQQZf0WYHdGZtSCiV52cBhU4iT8ZrK22IBvgwPrhU7Iqos Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11001"; a="21424932" X-IronPort-AV: E=Sophos;i="6.06,201,1705392000"; d="scan'208";a="21424932" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2024 07:20:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,201,1705392000"; d="scan'208";a="9295383" Received: from lkp-server01.sh.intel.com (HELO b21307750695) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 03 Mar 2024 07:20:51 -0800 Received: from kbuild by b21307750695 with local (Exim 4.96) (envelope-from ) id 1rgndw-0001qi-1j; Sun, 03 Mar 2024 15:20:48 +0000 Date: Sun, 3 Mar 2024 23:20:28 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1670 kvm_commit_memory_region() error: we previously assumed 'old' could be null (see line 1663) Message-ID: <202403032353.WvUDlJUc-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Tianrui Zhao CC: Huacai Chen CC: Bibo Mao tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 04b8076df2534f08bb4190f90a24e0f7f8930aca commit: c1fc48aad14dbe7654f5986afb906332b528d54b LoongArch: KVM: Enable kvm config and add the makefile date: 5 months ago :::::: branch date: 16 hours ago :::::: commit date: 5 months ago config: loongarch-randconfig-r081-20240225 (https://download.01.org/0day-ci/archive/20240303/202403032353.WvUDlJUc-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202403032353.WvUDlJUc-lkp@intel.com/ New smatch warnings: arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1670 kvm_commit_memory_region() error: we previously assumed 'old' could be null (see line 1663) arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1672 kvm_commit_memory_region() error: we previously assumed 'new' could be null (see line 1664) arch/loongarch/kvm/mmu.c:867 kvm_map_page() warn: if statement not indented Old smatch warnings: arch/loongarch/include/asm/atomic.h:109 arch_atomic_fetch_add_unless() warn: inconsistent indenting vim +/old +1670 arch/loongarch/kvm/../../../virt/kvm/kvm_main.c 36947254e5f981 Sean Christopherson 2020-02-18 1657 07921665a65191 Sean Christopherson 2021-12-06 1658 static void kvm_commit_memory_region(struct kvm *kvm, 07921665a65191 Sean Christopherson 2021-12-06 1659 struct kvm_memory_slot *old, 07921665a65191 Sean Christopherson 2021-12-06 1660 const struct kvm_memory_slot *new, cf47f50b5c2e24 Sean Christopherson 2020-02-18 1661 enum kvm_mr_change change) cf47f50b5c2e24 Sean Christopherson 2020-02-18 1662 { 6c7b2202e4d115 Paolo Bonzini 2022-11-17 @1663 int old_flags = old ? old->flags : 0; 6c7b2202e4d115 Paolo Bonzini 2022-11-17 @1664 int new_flags = new ? new->flags : 0; 07921665a65191 Sean Christopherson 2021-12-06 1665 /* 07921665a65191 Sean Christopherson 2021-12-06 1666 * Update the total number of memslot pages before calling the arch 07921665a65191 Sean Christopherson 2021-12-06 1667 * hook so that architectures can consume the result directly. 07921665a65191 Sean Christopherson 2021-12-06 1668 */ 07921665a65191 Sean Christopherson 2021-12-06 1669 if (change == KVM_MR_DELETE) 07921665a65191 Sean Christopherson 2021-12-06 @1670 kvm->nr_memslot_pages -= old->npages; 07921665a65191 Sean Christopherson 2021-12-06 1671 else if (change == KVM_MR_CREATE) 07921665a65191 Sean Christopherson 2021-12-06 @1672 kvm->nr_memslot_pages += new->npages; cf47f50b5c2e24 Sean Christopherson 2020-02-18 1673 6c7b2202e4d115 Paolo Bonzini 2022-11-17 1674 if ((old_flags ^ new_flags) & KVM_MEM_LOG_DIRTY_PAGES) { 6c7b2202e4d115 Paolo Bonzini 2022-11-17 1675 int change = (new_flags & KVM_MEM_LOG_DIRTY_PAGES) ? 1 : -1; 6c7b2202e4d115 Paolo Bonzini 2022-11-17 1676 atomic_set(&kvm->nr_memslots_dirty_logging, 6c7b2202e4d115 Paolo Bonzini 2022-11-17 1677 atomic_read(&kvm->nr_memslots_dirty_logging) + change); 6c7b2202e4d115 Paolo Bonzini 2022-11-17 1678 } 6c7b2202e4d115 Paolo Bonzini 2022-11-17 1679 07921665a65191 Sean Christopherson 2021-12-06 1680 kvm_arch_commit_memory_region(kvm, old, new, change); 07921665a65191 Sean Christopherson 2021-12-06 1681 a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1682 switch (change) { a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1683 case KVM_MR_CREATE: a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1684 /* Nothing more to do. */ a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1685 break; a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1686 case KVM_MR_DELETE: a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1687 /* Free the old memslot and all its metadata. */ a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1688 kvm_free_memslot(kvm, old); a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1689 break; a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1690 case KVM_MR_MOVE: a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1691 case KVM_MR_FLAGS_ONLY: b10a038e84d188 Ben Gardon 2021-05-18 1692 /* a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1693 * Free the dirty bitmap as needed; the below check encompasses a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1694 * both the flags and whether a ring buffer is being used) 07921665a65191 Sean Christopherson 2021-12-06 1695 */ a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1696 if (old->dirty_bitmap && !new->dirty_bitmap) 07921665a65191 Sean Christopherson 2021-12-06 1697 kvm_destroy_dirty_bitmap(old); 07921665a65191 Sean Christopherson 2021-12-06 1698 a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1699 /* a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1700 * The final quirk. Free the detached, old slot, but only its a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1701 * memory, not any metadata. Metadata, including arch specific a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1702 * data, may be reused by @new. a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1703 */ a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1704 kfree(old); a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1705 break; a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1706 default: a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1707 BUG(); a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1708 } a54d806688fe1e Maciej S. Szmigiero 2021-12-06 1709 } cf47f50b5c2e24 Sean Christopherson 2020-02-18 1710 :::::: The code at line 1670 was first introduced by commit :::::: 07921665a651918350bc6653d4ca8a516a867b4b KVM: Use prepare/commit hooks to handle generic memslot metadata updates :::::: TO: Sean Christopherson :::::: CC: Paolo Bonzini -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki