From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, jiri@resnulli.us
Subject: Re: [PATCH net-next 4/4] tools: ynl: add --dbg-small-recv for easier kernel testing
Date: Mon, 4 Mar 2024 06:59:00 -0800 [thread overview]
Message-ID: <20240304065900.60d3670d@kernel.org> (raw)
In-Reply-To: <m2wmqijkzn.fsf@gmail.com>
On Mon, 04 Mar 2024 11:26:52 +0000 Donald Hunter wrote:
> > + parser.add_argument('--dbg-small-recv', default=0, const=4000,
> > + action='store', nargs='?', type=int)
>
> This breaks ynl if you don't use '--dbg-small-recv', it passes 0 which
> fails the _recv_size check.
Good catch, one too many refactorings..
prev parent reply other threads:[~2024-03-04 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 23:05 [PATCH net-next 0/4] tools: ynl: add --dbg-small-recv for easier kernel testing Jakub Kicinski
2024-03-01 23:05 ` [PATCH net-next 1/4] tools: ynl: move the new line in NlMsg __repr__ Jakub Kicinski
2024-03-04 11:08 ` Donald Hunter
2024-03-01 23:05 ` [PATCH net-next 2/4] tools: ynl: allow setting recv() size Jakub Kicinski
2024-03-04 11:38 ` Donald Hunter
2024-03-04 13:38 ` Donald Hunter
2024-03-04 14:58 ` Jakub Kicinski
2024-03-04 15:57 ` Donald Hunter
2024-03-04 16:20 ` Jakub Kicinski
2024-03-01 23:05 ` [PATCH net-next 3/4] tools: ynl: support debug printing messages Jakub Kicinski
2024-03-04 11:34 ` Donald Hunter
2024-03-01 23:05 ` [PATCH net-next 4/4] tools: ynl: add --dbg-small-recv for easier kernel testing Jakub Kicinski
2024-03-04 11:26 ` Donald Hunter
2024-03-04 14:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304065900.60d3670d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.