From: Jakub Kicinski <kuba@kernel.org>
To: Kui-Feng Lee <sinquersw@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
Kui-Feng Lee <thinker.li@gmail.com>,
netdev@vger.kernel.org, ast@kernel.org, martin.lau@linux.dev,
kernel-team@meta.com, davem@davemloft.net, kuifeng@meta.com
Subject: Re: [PATCH net-next] selftests/net: force synchronized GC for a test.
Date: Mon, 4 Mar 2024 07:44:21 -0800 [thread overview]
Message-ID: <20240304074421.41726c4d@kernel.org> (raw)
In-Reply-To: <d2a4bcab-4fab-4750-b856-a8a9b674a31a@gmail.com>
On Fri, 1 Mar 2024 16:45:58 -0800 Kui-Feng Lee wrote:
> However, some extra waiting may be added to it.
> There are two possible extra waiting. The first one is calling
> round_jiffies() in fib6_run_gc(), that may add 750ms at most. The second
> one is the granularity of waiting for 5 seconds (in our case) is 512ms
> for HZ 1000 according to the comment at the very begin of timer.c.
> In fact, it can add 392ms for 5750ms (5000ms + 750ms). Overall, they may
> contribute up to 1144ms.
>
> Does that make sense?
>
> Debug build is slower. So, the test scripts will be slower than normal
> build. That means the script is actually waiting longer with a debug build.
Meaning bumping the wait to $((($EXPIRE + 1) * 2))
should be enough for the non-debug runner?
next prev parent reply other threads:[~2024-03-04 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 8:13 [PATCH net-next] selftests/net: force synchronized GC for a test Kui-Feng Lee
2024-02-24 2:21 ` Jakub Kicinski
2024-02-24 3:15 ` David Ahern
2024-02-24 3:54 ` Kui-Feng Lee
2024-02-29 17:39 ` Kui-Feng Lee
2024-03-02 0:45 ` Kui-Feng Lee
2024-03-04 15:44 ` Jakub Kicinski [this message]
2024-03-04 17:27 ` Kui-Feng Lee
2024-03-05 2:41 ` David Ahern
2024-03-05 2:49 ` David Ahern
2024-03-05 3:20 ` Kui-Feng Lee
2024-02-24 4:40 ` Kui-Feng Lee
2024-02-27 8:53 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304074421.41726c4d@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sinquersw@gmail.com \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.