From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F1A171BF for ; Mon, 4 Mar 2024 08:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540252; cv=none; b=jhUsRWYLpYQA7lughR2nFLw+gk01QoF+bntag1H+yPPDWWPEiDGpet611fS8P8HQ8Moe+KrV2Bw8yHzyV9N4nwXbYgb3suD0P5QcfI/1DIKSZd/wTIfVNCt/+pP2knUhMTsdfapv2rW+K8SURQntGVs4j6KNHUbuS33toRLdiQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540252; c=relaxed/simple; bh=AD9VdZnv6tpH2MGwDtAtMpimMoKxyHcy4Zu3b2xEwqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G7rkgZB4IDlFJEZCtObYlcHPdWTXjJOSOFMfS9B5Dw8plkIdqZYdumDcnb+UwWmmbCD/JJBIZMMW6RR4vIPYbzD3fqsQNQO3juwGB5+D6P4Nn3OxPSyzy0DRJsca7nRqLFBxc5hNKcMUxHtEaw0U+hP0nTob30yTTcFc85zIuXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qLBmXvOF; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qLBmXvOF" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7810827e54eso323647985a.2 for ; Mon, 04 Mar 2024 00:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540248; x=1710145048; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hmWR/dQ/IEMHbjZi2RajMkmXPdKPqp6IFe8boeN75aE=; b=qLBmXvOFtcsx+rnJDCob3E2rOLnBI9AHapK8Dtm+Rr0QUw0xTMdXs5+xl8zCLLe6Wk 4C0UQRqwzo/e+bpVnUe5IEBdARgbSoe1YKekPfBbgodS9Oxr/KXR9Ok8Fox2ccxVZeeo IekStR2qwSUACWCj/Vhafm2bPKC4KCUC3hAO2cPa9zVsiuo0wpp6SANzq1kgdw5JecWN n24mVnoGUqHpn4oMM7trC3Bm6l9GwFW3Wr3tR3NB8etQ57+oQdEpLLa1zseKHaoBPcsw FDOFm3k8CA9v0YmDrk9fDKQA46FOViUkCzPNLLSjX42QG9r5JT6adkpbocbPOG28rV7K LswA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540248; x=1710145048; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hmWR/dQ/IEMHbjZi2RajMkmXPdKPqp6IFe8boeN75aE=; b=nsbdIAWMHw85m0FWOS5BLvdFR1St5u21GcSqIqs7Qi7zTDQ0X8qHEFake85PqV+OxM d0ddADKfP/UwEbVAOtnmNaNFjhlM/UL9zTgoregr9dyceIqfAHENP/hOhr+VJreHRF0R fZAmTxu/qYDTZTOFKTzX39bKlJfh86qswrCYKNypoC7McTgEt9Bv3tt1BcxBCDe8jtNL ECvGiONNNqaW2nUDSSS6My6Fv/TcXfcK4IAaev3Dcd/BUIRIzIYHLdwc4a8uxh+szNfq vfE5YfgKD2vgAE6WPzq0Xll/49h68byuhcrmQQL/WWl/05tek+2zg86l1to7wLw1cRCU weog== X-Forwarded-Encrypted: i=1; AJvYcCUtQ5MTGPQyrzQm9ipJAdyH+UPJZnLWMbir8t1Z/3bmkvuvmsKNse565IF95vKuonXNQ3voBY2j9WbhNtwxL9b8YjdRK8Gv1YV2BNi1PA== X-Gm-Message-State: AOJu0Yy20s1bdFDPZPjj/B1gNz+7PNUs3Wa4kqkma4L9D3U+z38Tdjpp 1VJihBGVO6vi4bi6Tsz350N5N59amrb+8pqi5+u46rsjt8jpCVWltQlYm4s7lw== X-Google-Smtp-Source: AGHT+IHj2odoO405rOYr1Gbd+eMsiiWMwBO5dmlWnp+hZP/p4is76K0Utr7rAm1gwPP1v5DFYu5Uzw== X-Received: by 2002:a05:620a:110d:b0:788:22c4:c95f with SMTP id o13-20020a05620a110d00b0078822c4c95fmr3901107qkk.21.1709540248532; Mon, 04 Mar 2024 00:17:28 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id t20-20020a05620a0b1400b007881ed0f87dsm1737718qkg.65.2024.03.04.00.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:17:28 -0800 (PST) Date: Mon, 4 Mar 2024 13:47:13 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# Message-ID: <20240304081713.GH2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-3-64c7fd0cfe64@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 29, 2024 at 01:40:29PM +0100, Niklas Cassel wrote: > On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote: > > For DWC glue drivers supporting PERST# (currently Qcom and Tegra194), some > > of the DWC resources like eDMA should be cleaned up during the PERST# > > assert time. > > > > So let's introduce a dw_pcie_ep_cleanup() API that could be called by these > > drivers to cleanup the DWC specific resources. Currently, it just removes > > eDMA. > > > > Reported-by: Niklas Cassel > > Closes: https://lore.kernel.org/linux-pci/ZWYmX8Y%2F7Q9WMxES@x1-carbon > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 11 +++++++++-- > > drivers/pci/controller/dwc/pcie-designware.h | 5 +++++ > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ > > 4 files changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index 2b11290aab4c..1205bfba8310 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > @@ -564,12 +564,19 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > return 0; > > } > > > > -void dw_pcie_ep_deinit(struct dw_pcie_ep *ep) > > +void dw_pcie_ep_cleanup(struct dw_pcie_ep *ep) > > { > > struct dw_pcie *pci = to_dw_pcie_from_ep(ep); > > - struct pci_epc *epc = ep->epc; > > > > dw_pcie_edma_remove(pci); > > Hello Mani, > > In this message: > https://lore.kernel.org/linux-pci/20240130062938.GB32821@thinkpad/ > > You mentioned that you were going to clean up the BARs. Yes, I did and it is still in my queue. > (Like I wrote in that thread, I really think that we should merge a fix for > the broken "do we have a saved value from find_first_zero_bit() in the array", > by using a "if (!saved_value[bar])", when find_first_zero_bit() returns zero.) > Hmm, yeah that logic is flawed. Let me take another look. > However, regardless of that, I do not see that this series (neither > dw_pcie_ep_cleanup(), nor dw_pcie_ep_linkdown()), calls any function which > will clean up the BARs. > > Since e.g. qcom-ep.c does a reset_control_assert() during perst > assert/deassert, which should clear sticky registers, I think that > you should let dw_pcie_ep_cleanup() clean up the BARs using > dw_pcie_ep_clear_bar(). > As I mentioned earlier, it is the job of the EPF drivers to clear the BARs since they allocate them. I'm trying to reduce the implicit resetting wherever we could. The proper fix is to add the LINK_DOWN callback to EPF drivers and do cleanup. I'm planning to submit a series for that after this one. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7B38C54E41 for ; Mon, 4 Mar 2024 08:18:18 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=X3qY4gkH; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TpBQx2GlQz3dDq for ; Mon, 4 Mar 2024 19:18:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=X3qY4gkH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::730; helo=mail-qk1-x730.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TpBQ62br6z2ykn for ; Mon, 4 Mar 2024 19:17:32 +1100 (AEDT) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-787b0b1deeaso217670485a.3 for ; Mon, 04 Mar 2024 00:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540248; x=1710145048; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hmWR/dQ/IEMHbjZi2RajMkmXPdKPqp6IFe8boeN75aE=; b=X3qY4gkHKhRUv9s8SjMq+ObHkE4TtQD5NXVhhwPVzvgeQpUK3NwdE/rPRmuWKavRB+ rVuhb6zflLJsoJ7q8AO+BC0K71qw321mRuYby1CvXs8B1GmkvlC2th7J1RjgOE1RyZM6 GYkiiEobTIs65HUdo7z3PO9y1qVAo4GwhkvPusRD8fcACJhz+l7Ce0SuJewVKPQU7pJA 7il3VYBZkJefwXV6l1CwfI2N7377q4iUl/Mg1BUbaD0qDxPelsjI7Zp87brBoyqm7R0y Yh6uhGi5K5oJVF+3GtYnoZUOjD9vY+jYfluh1prDDSp0hWb/iH/1AxEeSizPgYhy+v5t kLxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540248; x=1710145048; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hmWR/dQ/IEMHbjZi2RajMkmXPdKPqp6IFe8boeN75aE=; b=Hx0vjel8ZPlUPoZBnoIFDXCbCKwJQBcNokUkiuuXxUD2Rx4dFT9UyIDJzN7lptxndu RclirQRr58S20+naDAs40t5+YIOYwaV1TLXp8lKpFpJTDnHcutv84a+Xr2CyQ1/o4nbe WtS8UCgjtbZFw6YzfryMxL8SHYsS7dBtAfdI0pdD7d1ZeITmvc+4Q6829FT+9xtj+xTo 5PArq/nCMFmHVUOzVt6OLG6FKiP1WTZRfmbXcVz47egFlb+j34IGSF1A48T8Ny1rC7Hd ExZ7R8ZJJb5sqhlhA5KTSzgvu4HtOsBXMI51tFu1iLtFYiEf2Gpyms89HGaqQQ5eom9o Y7jg== X-Forwarded-Encrypted: i=1; AJvYcCWgICHb7Cd3o0ucW9jKZiwZSfsk4ZDGcAqcJYF5rMEOs3mwHp9BDpmkkOZwZrJqi0CvzW8OuixLvgHE0sKKcTsuTxNLN4CBk7PFNHOqNQ== X-Gm-Message-State: AOJu0YznLWe/h+gHUC7/e1D+XmzqoADuKu3SD3+vwQFHtws+bEhNkXhc vRmA+82BP48x0RB3aQVpjvkMmzedrBg38NHFP/5e8MfZeZNywKXmr4RACat+pg== X-Google-Smtp-Source: AGHT+IHj2odoO405rOYr1Gbd+eMsiiWMwBO5dmlWnp+hZP/p4is76K0Utr7rAm1gwPP1v5DFYu5Uzw== X-Received: by 2002:a05:620a:110d:b0:788:22c4:c95f with SMTP id o13-20020a05620a110d00b0078822c4c95fmr3901107qkk.21.1709540248532; Mon, 04 Mar 2024 00:17:28 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id t20-20020a05620a0b1400b007881ed0f87dsm1737718qkg.65.2024.03.04.00.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:17:28 -0800 (PST) Date: Mon, 4 Mar 2024 13:47:13 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# Message-ID: <20240304081713.GH2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-3-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Richard Zhu , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux- kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 29, 2024 at 01:40:29PM +0100, Niklas Cassel wrote: > On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote: > > For DWC glue drivers supporting PERST# (currently Qcom and Tegra194), some > > of the DWC resources like eDMA should be cleaned up during the PERST# > > assert time. > > > > So let's introduce a dw_pcie_ep_cleanup() API that could be called by these > > drivers to cleanup the DWC specific resources. Currently, it just removes > > eDMA. > > > > Reported-by: Niklas Cassel > > Closes: https://lore.kernel.org/linux-pci/ZWYmX8Y%2F7Q9WMxES@x1-carbon > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 11 +++++++++-- > > drivers/pci/controller/dwc/pcie-designware.h | 5 +++++ > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ > > 4 files changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index 2b11290aab4c..1205bfba8310 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > @@ -564,12 +564,19 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > return 0; > > } > > > > -void dw_pcie_ep_deinit(struct dw_pcie_ep *ep) > > +void dw_pcie_ep_cleanup(struct dw_pcie_ep *ep) > > { > > struct dw_pcie *pci = to_dw_pcie_from_ep(ep); > > - struct pci_epc *epc = ep->epc; > > > > dw_pcie_edma_remove(pci); > > Hello Mani, > > In this message: > https://lore.kernel.org/linux-pci/20240130062938.GB32821@thinkpad/ > > You mentioned that you were going to clean up the BARs. Yes, I did and it is still in my queue. > (Like I wrote in that thread, I really think that we should merge a fix for > the broken "do we have a saved value from find_first_zero_bit() in the array", > by using a "if (!saved_value[bar])", when find_first_zero_bit() returns zero.) > Hmm, yeah that logic is flawed. Let me take another look. > However, regardless of that, I do not see that this series (neither > dw_pcie_ep_cleanup(), nor dw_pcie_ep_linkdown()), calls any function which > will clean up the BARs. > > Since e.g. qcom-ep.c does a reset_control_assert() during perst > assert/deassert, which should clear sticky registers, I think that > you should let dw_pcie_ep_cleanup() clean up the BARs using > dw_pcie_ep_clear_bar(). > As I mentioned earlier, it is the job of the EPF drivers to clear the BARs since they allocate them. I'm trying to reduce the implicit resetting wherever we could. The proper fix is to add the LINK_DOWN callback to EPF drivers and do cleanup. I'm planning to submit a series for that after this one. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A533DC48BF6 for ; Mon, 4 Mar 2024 08:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EB5Az7EVOCh5XDfPvvNBH58+4vPsBmDmy5Mt1wB6dto=; b=fNEaAaIhTWtQBr 75tk4RaNpHnlL5OAavCAITX9aQ0AQA4lSDgyueIyF1a5A8YIrVo2X6iAvXUT55ARNwU/y1X1EIdVe +P5qmMyybOut7whZ0vOdVJfr2UBZEoBfpk6ZfvQHh+z5t0h8kGHV2ofQVfs6HLOebmq5fBmlYicf5 wvOYV/bXkmwCVjIKDBv7fq13knFH5ttZPQA6IERtHhDC70BEgmstKEwy+AExruIiU2Ip429zATyb5 rdMK07DcM2dI/rD4FcC7KmxgUDgTmlvsTa1sQ9Lf+OxJxdnk8m8bY98lbZi9o/H2aXwpfQlqmrDIS TqMD4xXHij6bYUIKSqSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh3Vv-000000086oJ-375r; Mon, 04 Mar 2024 08:17:35 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh3Vq-000000086mf-2h6E for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 08:17:33 +0000 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7882b1e87c4so13498785a.1 for ; Mon, 04 Mar 2024 00:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540248; x=1710145048; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hmWR/dQ/IEMHbjZi2RajMkmXPdKPqp6IFe8boeN75aE=; b=uDwWjOT81lztmIge8ZTLTsouOZiCN8Akwgrd8CyT/VykKdt4trR5JpOxZGbo2U+1+b fBei/+GoYPcxSXpTNndCidP7kSSDNkn7liHv9zeGKzgYOctabBcRWalbkOzC0w1V7pbF bwv1f5awbHLUUAEarp38NQwcU+Cuzn7X6h+lzwcd51qr9jKstQu92WKGerjo4zMRd2p+ +9qJuREVdxbAj0Wd1iQMUjNadgX5mGsd73yH0Sdb+MaQR1bNRLkxvfHewKL0rNOZG2Gx R8wmdWmpBSB2/bh93vwRvPeJNCZnypHSEKEws+ktFULTLJxUALar6/I3uxfYcGqGqUJ2 jyoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540248; x=1710145048; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hmWR/dQ/IEMHbjZi2RajMkmXPdKPqp6IFe8boeN75aE=; b=LuIqq0Pg7HZZKbAZLHmNYBM1ifPf7KaeYJPMgqkPMto+eYBg1OShGFRITAjM6Y2Q1t fpkE9GWhxip9tar5iOF9LCXQqIh/SCKHvSuzQuWQgKTMapRu8i4l4x7xAqfq54fkEb2y Lzd9QgExb7pW1Ni8wqZW3nqRZnYh4J/Nu5hMH4P/YA0ArUmFufg2vAJyVVkwriMoRn4k AMV/R9XJS6pRFaPC+DTYtoXmSg+0qnzpJFLopC0X37HJ2cvanqXVc/mFNj10/wtw/ZGC 16MtA6774mkWMLCvPBiBjAw9oh06SHBAuSxH8l6fX91p+tWLv3cZuVsHMnVynHenisMN qZfQ== X-Forwarded-Encrypted: i=1; AJvYcCVqjQQoJ9mMby9II6wBngJroOK0xBkpwUsJsxReG6kJRb/fg+PaOcBxeGsz7IbMlb0kQyIrUR8TyNfCgWCJvS6nUB4mNUx11gBcV0fRhXT5W5STStA= X-Gm-Message-State: AOJu0Yx58cQzOzFlxnF1u0lLncx/cWnm6rE7x1vEZPtG0W6f0Xk31k4y z33z28ZPDxnHtkeksb26WNknsO72VnSt9BlLCgdJOHL5FvvIM3A27Qc24OYl9A== X-Google-Smtp-Source: AGHT+IHj2odoO405rOYr1Gbd+eMsiiWMwBO5dmlWnp+hZP/p4is76K0Utr7rAm1gwPP1v5DFYu5Uzw== X-Received: by 2002:a05:620a:110d:b0:788:22c4:c95f with SMTP id o13-20020a05620a110d00b0078822c4c95fmr3901107qkk.21.1709540248532; Mon, 04 Mar 2024 00:17:28 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id t20-20020a05620a0b1400b007881ed0f87dsm1737718qkg.65.2024.03.04.00.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:17:28 -0800 (PST) Date: Mon, 4 Mar 2024 13:47:13 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# Message-ID: <20240304081713.GH2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-3-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_001730_773253_59943A6B X-CRM114-Status: GOOD ( 29.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMjksIDIwMjQgYXQgMDE6NDA6MjlQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBTYXQsIEZlYiAyNCwgMjAyNCBhdCAxMjoyNDowOVBNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiBGb3IgRFdDIGdsdWUgZHJpdmVycyBzdXBwb3J0aW5n IFBFUlNUIyAoY3VycmVudGx5IFFjb20gYW5kIFRlZ3JhMTk0KSwgc29tZQo+ID4gb2YgdGhlIERX QyByZXNvdXJjZXMgbGlrZSBlRE1BIHNob3VsZCBiZSBjbGVhbmVkIHVwIGR1cmluZyB0aGUgUEVS U1QjCj4gPiBhc3NlcnQgdGltZS4KPiA+IAo+ID4gU28gbGV0J3MgaW50cm9kdWNlIGEgZHdfcGNp ZV9lcF9jbGVhbnVwKCkgQVBJIHRoYXQgY291bGQgYmUgY2FsbGVkIGJ5IHRoZXNlCj4gPiBkcml2 ZXJzIHRvIGNsZWFudXAgdGhlIERXQyBzcGVjaWZpYyByZXNvdXJjZXMuIEN1cnJlbnRseSwgaXQg anVzdCByZW1vdmVzCj4gPiBlRE1BLgo+ID4gCj4gPiBSZXBvcnRlZC1ieTogTmlrbGFzIENhc3Nl bCA8Y2Fzc2VsQGtlcm5lbC5vcmc+Cj4gPiBDbG9zZXM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2xpbnV4LXBjaS9aV1ltWDhZJTJGN1E5V014RVNAeDEtY2FyYm9uCj4gPiBTaWduZWQtb2ZmLWJ5 OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZhbUBsaW5hcm8ub3Jn Pgo+ID4gLS0tCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJl LWVwLmMgfCAxMSArKysrKysrKystLQo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3Bj aWUtZGVzaWdud2FyZS5oICAgIHwgIDUgKysrKysKPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLXFjb20tZXAuYyAgICAgICB8ICAxICsKPiA+ICBkcml2ZXJzL3BjaS9jb250cm9s bGVyL2R3Yy9wY2llLXRlZ3JhMTk0LmMgICAgICB8ICAyICsrCj4gPiAgNCBmaWxlcyBjaGFuZ2Vk LCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMgYi9kcml2ZXJz L3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWRlc2lnbndhcmUtZXAuYwo+ID4gaW5kZXggMmIxMTI5 MGFhYjRjLi4xMjA1YmZiYTgzMTAgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9s bGVyL2R3Yy9wY2llLWRlc2lnbndhcmUtZXAuYwo+ID4gKysrIGIvZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMKPiA+IEBAIC01NjQsMTIgKzU2NCwxOSBAQCBp bnQgZHdfcGNpZV9lcF9yYWlzZV9tc2l4X2lycShzdHJ1Y3QgZHdfcGNpZV9lcCAqZXAsIHU4IGZ1 bmNfbm8sCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+IC12b2lkIGR3X3BjaWVfZXBf ZGVpbml0KHN0cnVjdCBkd19wY2llX2VwICplcCkKPiA+ICt2b2lkIGR3X3BjaWVfZXBfY2xlYW51 cChzdHJ1Y3QgZHdfcGNpZV9lcCAqZXApCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHdfcGNpZSAqcGNp ID0gdG9fZHdfcGNpZV9mcm9tX2VwKGVwKTsKPiA+IC0Jc3RydWN0IHBjaV9lcGMgKmVwYyA9IGVw LT5lcGM7Cj4gPiAgCj4gPiAgCWR3X3BjaWVfZWRtYV9yZW1vdmUocGNpKTsKPiAKPiBIZWxsbyBN YW5pLAo+IAo+IEluIHRoaXMgbWVzc2FnZToKPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51 eC1wY2kvMjAyNDAxMzAwNjI5MzguR0IzMjgyMUB0aGlua3BhZC8KPiAKPiBZb3UgbWVudGlvbmVk IHRoYXQgeW91IHdlcmUgZ29pbmcgdG8gY2xlYW4gdXAgdGhlIEJBUnMuCgpZZXMsIEkgZGlkIGFu ZCBpdCBpcyBzdGlsbCBpbiBteSBxdWV1ZS4KCj4gKExpa2UgSSB3cm90ZSBpbiB0aGF0IHRocmVh ZCwgSSByZWFsbHkgdGhpbmsgdGhhdCB3ZSBzaG91bGQgbWVyZ2UgYSBmaXggZm9yCj4gdGhlIGJy b2tlbiAiZG8gd2UgaGF2ZSBhIHNhdmVkIHZhbHVlIGZyb20gZmluZF9maXJzdF96ZXJvX2JpdCgp IGluIHRoZSBhcnJheSIsCj4gYnkgdXNpbmcgYSAiaWYgKCFzYXZlZF92YWx1ZVtiYXJdKSIsIHdo ZW4gZmluZF9maXJzdF96ZXJvX2JpdCgpIHJldHVybnMgemVyby4pCj4gCgpIbW0sIHllYWggdGhh dCBsb2dpYyBpcyBmbGF3ZWQuIExldCBtZSB0YWtlIGFub3RoZXIgbG9vay4KCj4gSG93ZXZlciwg cmVnYXJkbGVzcyBvZiB0aGF0LCBJIGRvIG5vdCBzZWUgdGhhdCB0aGlzIHNlcmllcyAobmVpdGhl cgo+IGR3X3BjaWVfZXBfY2xlYW51cCgpLCBub3IgZHdfcGNpZV9lcF9saW5rZG93bigpKSwgY2Fs bHMgYW55IGZ1bmN0aW9uIHdoaWNoCj4gd2lsbCBjbGVhbiB1cCB0aGUgQkFScy4KPiAKPiBTaW5j ZSBlLmcuIHFjb20tZXAuYyBkb2VzIGEgcmVzZXRfY29udHJvbF9hc3NlcnQoKSBkdXJpbmcgcGVy c3QKPiBhc3NlcnQvZGVhc3NlcnQsIHdoaWNoIHNob3VsZCBjbGVhciBzdGlja3kgcmVnaXN0ZXJz LCBJIHRoaW5rIHRoYXQKPiB5b3Ugc2hvdWxkIGxldCBkd19wY2llX2VwX2NsZWFudXAoKSBjbGVh biB1cCB0aGUgQkFScyB1c2luZwo+IGR3X3BjaWVfZXBfY2xlYXJfYmFyKCkuCj4gCgpBcyBJIG1l bnRpb25lZCBlYXJsaWVyLCBpdCBpcyB0aGUgam9iIG9mIHRoZSBFUEYgZHJpdmVycyB0byBjbGVh ciB0aGUgQkFScyBzaW5jZQp0aGV5IGFsbG9jYXRlIHRoZW0uIEknbSB0cnlpbmcgdG8gcmVkdWNl IHRoZSBpbXBsaWNpdCByZXNldHRpbmcgd2hlcmV2ZXIgd2UKY291bGQuCgpUaGUgcHJvcGVyIGZp eCBpcyB0byBhZGQgdGhlIExJTktfRE9XTiBjYWxsYmFjayB0byBFUEYgZHJpdmVycyBhbmQgZG8g Y2xlYW51cC4KSSdtIHBsYW5uaW5nIHRvIHN1Ym1pdCBhIHNlcmllcyBmb3IgdGhhdCBhZnRlciB0 aGlzIG9uZS4KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTg rr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK