From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F87B171AF for ; Mon, 4 Mar 2024 08:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540356; cv=none; b=fAWi8hIJ81mVUxcmZnFWbq0cThvoFdM2jJ0rJ2sWNb8B4x8Ni7IeEZ0T/L2t/Kt0UWcIyr3CAHDwB2BKohkFmOieYIcZ1+xfER4VNpLnRhPLNqU/Dwtkf8xzn0xTd2ySSks9cSySW88KGjFj0FRkspGeczgb764OVTkInIsObgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540356; c=relaxed/simple; bh=H5uERWY03PMmpXHmr9VmP2Q+Yn+vktnT7Eljnh8Qo9s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vFUFJqVPHbkjlJDZsNiTjwSGV9mBuPQMjIeokSx4b+fiuunt5uJzsteGA5WpUoq035TngaZJ+0TTMNba7b5Jshb6+XhQ/mViypA1DW5z6u4qitHrFU2P6vTrnTm7OQT8ufHdCSU26SB1DoTfQXxkZQZkPUBAtbJSKrlLHljioG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Iye9FMvY; arc=none smtp.client-ip=209.85.219.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Iye9FMvY" Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dcbf82cdf05so4116472276.2 for ; Mon, 04 Mar 2024 00:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540353; x=1710145153; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=Iye9FMvY1Mxl9ba1DIM6exZqxv2w3tmhNabwkzOPFQzyHWkk3ww/BUx20ZE0Mu8osc VKIZ+KTYku6OZM7RP9UMjbysJJwdct9OYF5b1wOhW38kp9OYhn6bJNz991NkYt2c0Hlr 7v2+g0ycRxxXmq+r0ossgxFsbbkgsxXzYsm4kPEfFFh00o2/4sRt3VMOsmwsQFKi5Rtm J8w4x4+5bRrV8O8aJgGhB3o4sTmKCBVPgbX0naIbmibJV01s5p1pDRfYr5gsJevO2GAY BSG2yxYsA2fhSkc+HFkbK/cq61znvWC5QhlsPhFA+rG6ljvDujssljeJs6E39J9AO6Fs hgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540353; x=1710145153; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=D18tsxFk+Mm5QydLYW6lcW6b7Of5iFTZltieVMgdtP7UVMyFS4H9UOpPHlJm5GolRF owJMCBOUMiyEdOR+xQFAIzj7L9itscvbErOm8wboDoyLK06qlmCrHich/sRple3af3Qz q6als2+GZmvpsbOW5nBPXk8y2fTfr3m056X2yF+zvik4ELLNe8dlSX1im7LSsMedOEIb HyDNg6XPbwPhGR4zvpZhCLrjRuPhbjb+eF7Mk0BpeLi59tgjz0/MbbRwFen4r8qX/eT0 gxsGEsotXdAyrb1aIji1oyxOj4O57/yQWcqiLs3VZRNVqr/HYplWfRq/CL6nvi69CSkY EehA== X-Forwarded-Encrypted: i=1; AJvYcCUJOMgvbtgpEMJtKXbk2jK16INBKfNSK8+ciXRxFmbtI41qck9c3TJaV1k3sVqKuEsbESOIcm3Hjq1Xtc0fWrX4l4KBjqi8XANs1ObtSw== X-Gm-Message-State: AOJu0YymJqqo0ij/hJdLhURrRu1sDcxEVNEBwXNx9TfqHaYIbqfDn7v9 +gEWT7XL7Uo2E+tGwGYNS8P3P6JGDY0RNnv7haif+3csn4LfHhsy3KeyqKGcrw== X-Google-Smtp-Source: AGHT+IHL1WHL+wc2Bkuxv4RuAVn4VY861FeJv8fqtZvJsgPjzKqwuQFKnCSzgHkDfczowkgJ09KEpA== X-Received: by 2002:a25:7412:0:b0:dcc:79ab:e51a with SMTP id p18-20020a257412000000b00dcc79abe51amr6318413ybc.57.1709540353345; Mon, 04 Mar 2024 00:19:13 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id ks17-20020ac86211000000b0042ed81f5297sm2298830qtb.35.2024.03.04.00.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:19:13 -0800 (PST) Date: Mon, 4 Mar 2024 13:48:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240304081859.GI2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-10-64c7fd0cfe64@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 29, 2024 at 01:56:23PM +0100, Niklas Cassel wrote: > Hello Mani, > > On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 92 +++++++++++++++++++++++++ > > 1 file changed, 92 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index fed4c2936c78..cdcb33a279db 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > (snip) > > > @@ -556,6 +606,12 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > return 0; > > } > > > > +/** > > + * dw_pcie_ep_cleanup - Cleanup DWC EP resources > > + * @ep: DWC EP device > > + * > > + * Cleans up the DWC EP specific resources like eDMA etc... > > I think that you should mention that this is only for glue drivers that > use PERST# handling, so that other glue drivers do no start using it :) > You are right. Will add the wording. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FE2BC54E41 for ; Mon, 4 Mar 2024 08:20:00 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=naQuZIwe; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TpBSt6xVXz3dTk for ; Mon, 4 Mar 2024 19:19:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=naQuZIwe; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::b31; helo=mail-yb1-xb31.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TpBS44HS2z2x9T for ; Mon, 4 Mar 2024 19:19:16 +1100 (AEDT) Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-dd02fb9a31cso886540276.3 for ; Mon, 04 Mar 2024 00:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540353; x=1710145153; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=naQuZIweo7uKfc93x9hERvxKCvYNFUk4so6h+b7ADsconH+C1xpfDodi98eX/FcbC7 vhcQfrqZSBjhAfgn0i8vBcdx19YB31o9Yit+RdjudI9qMOUQP7KRa/HV4x3vK/wKWl1S VnWQqcuqdN3MPKbQOnZVQ0t9et/7grqlMMnCsCpyZh4Bka11Ke7VV7iO/lSONIE7ssS6 3ogIHhVcr4lGw+K/VUJ0yTuq9BKJ9mV+3ZCisMoccDRc4QcfoVG1coFu+GQEWSVgHcdK CKBTXWmqpawOGnUohGK/d1rrZzXFnqLtk6ZEiaAns4iNgq9bzlsZYqJbeDVTUTdOgnmL e+/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540353; x=1710145153; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=BJrtLJPGJ1Zi7KdYKfl/VTWtrMXM0txobdIsWOL2+6RChVfW7tM56NsFE6TPWm41OK 8mfPjxKe5qY6F5IMUtZmfZmur5xgVJ5Q/fSUOcFN0TKQfL2U2QMzj1TVWRFulrha56/u 4byLdJxcGvMzPzxLm7zMPFnjU5hEQ64VYaLRGzL8LiVEx6izUXW1LKFvH15gBsbXTPxC RfFu2iKJX0UB5qNglJB1Bmn+bsqzcszXfGv7GHQablH9f0fkLxbRGyhxs/+8dxwhUyGo QFlBJUADX9N9OZkNEx66eQ1ge5OE3yA7MLe1wlQIkBIJTB4VgiwAOw8nZJMiaKsBNGef vipQ== X-Forwarded-Encrypted: i=1; AJvYcCUjDbVAAySfGs0Y1KUEr5DjCLEZtub8No+NhYZZHVDDx/2POVleTlpVy26s/EVhj/ekbHn+mfoBzvmNF/K1KdX//A2wCEMoVhWYhYoS3A== X-Gm-Message-State: AOJu0YznhqRS587wDIHoeqYfwgTwmUwZ1ZBUikg5Wfz82KTWj+mifG64 wET866zY95dkay6o/bkHeUUMLZ3QaDnOVjkK4VmohwrqBv8J6ouogGTawNqcCQ== X-Google-Smtp-Source: AGHT+IHL1WHL+wc2Bkuxv4RuAVn4VY861FeJv8fqtZvJsgPjzKqwuQFKnCSzgHkDfczowkgJ09KEpA== X-Received: by 2002:a25:7412:0:b0:dcc:79ab:e51a with SMTP id p18-20020a257412000000b00dcc79abe51amr6318413ybc.57.1709540353345; Mon, 04 Mar 2024 00:19:13 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id ks17-20020ac86211000000b0042ed81f5297sm2298830qtb.35.2024.03.04.00.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:19:13 -0800 (PST) Date: Mon, 4 Mar 2024 13:48:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v8 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240304081859.GI2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-10-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Richard Zhu , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux- kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 29, 2024 at 01:56:23PM +0100, Niklas Cassel wrote: > Hello Mani, > > On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 92 +++++++++++++++++++++++++ > > 1 file changed, 92 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index fed4c2936c78..cdcb33a279db 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > (snip) > > > @@ -556,6 +606,12 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > return 0; > > } > > > > +/** > > + * dw_pcie_ep_cleanup - Cleanup DWC EP resources > > + * @ep: DWC EP device > > + * > > + * Cleans up the DWC EP specific resources like eDMA etc... > > I think that you should mention that this is only for glue drivers that > use PERST# handling, so that other glue drivers do no start using it :) > You are right. Will add the wording. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 872B7C48BF6 for ; Mon, 4 Mar 2024 08:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BbQp4lIn59GEDCIt6xhNJ612jS93YO1rte2Xby4HIuo=; b=mrEwpYQ2yHfVXC zQw5vrK4l/AKueg5sRjnipHWnYn8SOzNKfXiJoi9Dyc0WNHTnFfY5pjQFGBsAlUpJ/QSTmeLs239R b0yNK8IYifwk2tYDOBlG0h4kpUkWfO1wdS/vGon4COo/3F3Mn5HPchcQj2NH4q+cIR+9TRpV3agEi //GQ1mqDtEy2Qk7kP1VaE8AR5zqq2AWqC9L6CXsM4UeD/OQHlU584Bjv7GAuv+w/LZuAAfLvlfKzv GieXRfksPPdMtcn92iSTrJKsI63ZEeVeAhX79DIqVmUzVCGvMJiI+H0/CV4Ponazn4TwRanwBBKki 97Pk2wwkpTqK5BxjnINg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh3XZ-0000000879g-1KUb; Mon, 04 Mar 2024 08:19:17 +0000 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh3XW-0000000878Z-3Hrd for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 08:19:16 +0000 Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-dcbf82cdf05so4116473276.2 for ; Mon, 04 Mar 2024 00:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540353; x=1710145153; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=jeRfpfXlsuDqSM122mA2Kcgj4L7O9ylvoWm9Zk/P2XFWNcMncZWXEXM62palSq3NG0 ssXnwbVDK+HCKTxfnHUx/VeFNQz05UjxaGc96WSyvmdYdtxwM5opP13LjnXBqSSTwb0+ SmqNHXx2qK+VTkGOuU8sGJ8ARE8ui0xsfBDK7hBKOd2YfpV0w1yeB7xBQrf5LKpnPQ31 l9+c8j4acH8BkUmBmhiGAk9e+UxF0iDsU9lwVlY6dw7hdLn/azM7Fk8EpURBWnipoWWp 02gR2a8kciIa7ZJCJT5XyZHfO9LJAVq1dVaDXfSrcPXaCZOfjmoQXyNj4aWRuZdcdHQ7 Lq3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540353; x=1710145153; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=k2mZUyWHeFg16i3GCtkEGSRP1G8uRMijeteT2AbAv8VnlRFzwj2ymh+ueDHH7u7pgP 9zBSbUD0uWHuXxkdqUdAGr42pS3WnckgSfe1ZorQfPwjcOnINtaOTwfFATjJT6TM4Rl9 rb3uq1p6APjnfGi3oexTzyM9+5lr2yFG58ssol2ivvKZoXF+TrNkko4wFbQneYfBPsw9 uYLDqGikH4UaRigg4y2IiUXlh189+xiL7ag/xzQVXhMdoEla2Xtue7DMJWKz4+7bRmwf gbdb7ZP3qAYCg5Dy1cQ5PplT/hz1aLzZ+0WpVJFa6PbJvGkdBKmpOp//h55KmcCM/lpr BHgA== X-Forwarded-Encrypted: i=1; AJvYcCWJWnxrDbc2b/m56L8dy0m7zaY33aVij0c5muLJD2I8jzYreOhrmIZ9FEKM9jY8GIjxUE0yCJyQZsXbgMRlnatKMD8+VsHwUtOUAaXofVLtvR5FQzs= X-Gm-Message-State: AOJu0YxWwNPMHRBX1Efq9dnVQyzMY8luf1fHOjH7w+Ze0I1M97bQpw1N 3qJy0zXA+au8kWTH+ncBP76qpKXYs6azisOVmJ82Lbfxul92XFAJ2C13eMRWtg== X-Google-Smtp-Source: AGHT+IHL1WHL+wc2Bkuxv4RuAVn4VY861FeJv8fqtZvJsgPjzKqwuQFKnCSzgHkDfczowkgJ09KEpA== X-Received: by 2002:a25:7412:0:b0:dcc:79ab:e51a with SMTP id p18-20020a257412000000b00dcc79abe51amr6318413ybc.57.1709540353345; Mon, 04 Mar 2024 00:19:13 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id ks17-20020ac86211000000b0042ed81f5297sm2298830qtb.35.2024.03.04.00.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:19:13 -0800 (PST) Date: Mon, 4 Mar 2024 13:48:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240304081859.GI2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-10-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_001914_855859_945F9AD2 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMjksIDIwMjQgYXQgMDE6NTY6MjNQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBIZWxsbyBNYW5pLAo+IAo+IE9uIFNhdCwgRmViIDI0LCAyMDI0IGF0IDEyOjI0OjE2 UE0gKzA1MzAsIE1hbml2YW5uYW4gU2FkaGFzaXZhbSB3cm90ZToKPiA+IEFsbCBvZiB0aGUgQVBJ cyBhcmUgbWlzc2luZyB0aGUgS2VybmVsLWRvYyBjb21tZW50cy4gSGVuY2UsIGFkZCB0aGVtLgo+ ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4u c2FkaGFzaXZhbUBsaW5hcm8ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMgfCA5MiArKysrKysrKysrKysrKysrKysrKysrKysr Cj4gPiAgMSBmaWxlIGNoYW5nZWQsIDkyIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZGVzaWdud2FyZS1lcC5jIGIvZHJp dmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMKPiA+IGluZGV4IGZl ZDRjMjkzNmM3OC4uY2RjYjMzYTI3OWRiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMKPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaWUtZGVzaWdud2FyZS1lcC5jCj4gCj4gKHNuaXApCj4gCj4gPiBAQCAt NTU2LDYgKzYwNiwxMiBAQCBpbnQgZHdfcGNpZV9lcF9yYWlzZV9tc2l4X2lycShzdHJ1Y3QgZHdf cGNpZV9lcCAqZXAsIHU4IGZ1bmNfbm8sCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ ICsvKioKPiA+ICsgKiBkd19wY2llX2VwX2NsZWFudXAgLSBDbGVhbnVwIERXQyBFUCByZXNvdXJj ZXMKPiA+ICsgKiBAZXA6IERXQyBFUCBkZXZpY2UKPiA+ICsgKgo+ID4gKyAqIENsZWFucyB1cCB0 aGUgRFdDIEVQIHNwZWNpZmljIHJlc291cmNlcyBsaWtlIGVETUEgZXRjLi4uCj4gCj4gSSB0aGlu ayB0aGF0IHlvdSBzaG91bGQgbWVudGlvbiB0aGF0IHRoaXMgaXMgb25seSBmb3IgZ2x1ZSBkcml2 ZXJzIHRoYXQKPiB1c2UgUEVSU1QjIGhhbmRsaW5nLCBzbyB0aGF0IG90aGVyIGdsdWUgZHJpdmVy cyBkbyBubyBzdGFydCB1c2luZyBpdCA6KQo+IAoKWW91IGFyZSByaWdodC4gV2lsbCBhZGQgdGhl IHdvcmRpbmcuCgotIE1hbmkKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k 4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==