From: David Voit <david.voit@gmail.com>
To: linux-cifs@vger.kernel.org
Cc: David Voit <david.voit@gmail.com>
Subject: [PATCH v2 0/1] cifs-utils: CLDAP-Ping to find the correct site
Date: Mon, 4 Mar 2024 13:23:00 +0100 [thread overview]
Message-ID: <20240304122302.96156-1-david.voit@gmail.com> (raw)
Hi All,
we had some internal review of the patchset and I had some
misunderstanding of the dn_expand call. Thought it returns the
uncompressed size, but it always returns the compressed size, which
easily can be transformed to the next offset. This code was so or so a
little bit flaky, hope this makes the review of the rest of the code
easier for you guys.
summary of changes from last revision:
- use dn_expand instead of custom implementation
- check for minimum length in netlogon_size
- inline read_dns_string return value check
David Voit (1):
Implement CLDAP Ping to find the closest site
Makefile.am | 15 +--
cldap_ping.c | 284 +++++++++++++++++++++++++++++++++++++++++++++++++
cldap_ping.h | 9 ++
mount.cifs.c | 5 +-
resolve_host.c | 270 +++++++++++++++++++++++++++++++++++++++++-----
resolve_host.h | 6 +-
6 files changed, 551 insertions(+), 38 deletions(-)
create mode 100644 cldap_ping.c
create mode 100644 cldap_ping.h
--
2.44.0
next reply other threads:[~2024-03-04 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 12:23 David Voit [this message]
2024-03-04 12:23 ` [PATCH v2 1/1] Implement CLDAP Ping to find the closest site David Voit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304122302.96156-1-david.voit@gmail.com \
--to=david.voit@gmail.com \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.