From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D31CC5478C for ; Mon, 4 Mar 2024 13:17:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5157911213B; Mon, 4 Mar 2024 13:17:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="psfqezqt"; dkim-atps=neutral Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28B3A11213B for ; Mon, 4 Mar 2024 13:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709558230; bh=891A/GwRTFxXBWsENHQ+ZvT3FWtVkguSadkoSVZcP4k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=psfqezqtTmd7R0gHFyE92NpEO8gMsXLIOOv1ovKKB1GXJp+4ZxvBMnFYgzf8L5Nz5 8tEdVg+KBXbPfhSncd1pBEI+A6gzx8qfL3+/+CXXXS53Ws7eh/Bk/tfrm2WWnCT88W Kfn3sIFvbOu2kCDJ9NfaYqv02arEPbrEQX903Ux/z2/tmIm6Xgy7G2dUaI9tTYTGx2 PGYXPMo91afP1FwecK6LO4vu1iHf8mUeko+sl5HHF+CAONcVZ+IYRw+/OM3G3TXqcx XGu6fis63BEhLojp9pEK4xUS/+2rT8aM0Ha2BLrbUJK6ipPdcTRA4x5It3SG5f3MS5 iWfYAy9Q+osIg== Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madrid.collaboradmins.com (Postfix) with ESMTPSA id C39503780629; Mon, 4 Mar 2024 13:17:09 +0000 (UTC) Date: Mon, 4 Mar 2024 14:17:08 +0100 From: Boris Brezillon To: Steven Price Cc: Liviu Dudau , dri-devel@lists.freedesktop.org, kernel@collabora.com, kernel test robot Subject: Re: [PATCH 2/3] drm/panthor: Explicitly include page.h for the {virt,__phys)_to_pfn() defs Message-ID: <20240304141708.4f886418@collabora.com> In-Reply-To: References: <20240304090812.3941084-1-boris.brezillon@collabora.com> <20240304090812.3941084-3-boris.brezillon@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 4 Mar 2024 12:31:23 +0000 Steven Price wrote: > On 04/03/2024 09:08, Boris Brezillon wrote: > > Something on arm[64] must be including , but things fail > > to compile on sparc64. Make sure this header is included explicitly > > so this driver can be compile-tested on all supported architectures. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202403031142.Vl4pW7X6-lkp@intel.com/ > > Signed-off-by: Boris Brezillon > > Seems reasonable, although I do wonder if it's right to include a "asm" > header here or if we should pull in something like "linux/mm.h" which > includes asm/page.h. I can find examples of both. Either way: Actually, I considered including linux/mm.h too, so I'm happy to go for this option (will fix when applying. > > Reviewed-by: Steven Price > > > --- > > drivers/gpu/drm/panthor/panthor_device.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c > > index bfe8da4a6e4c..68e467ee458a 100644 > > --- a/drivers/gpu/drm/panthor/panthor_device.c > > +++ b/drivers/gpu/drm/panthor/panthor_device.c > > @@ -3,6 +3,8 @@ > > /* Copyright 2019 Linaro, Ltd, Rob Herring */ > > /* Copyright 2023 Collabora ltd. */ > > > > +#include > > + > > #include > > #include > > #include >