From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] Add SAFE_MPROTECT() macro
Date: Mon, 4 Mar 2024 17:30:12 +0100 [thread overview]
Message-ID: <20240304163012.GA3191855@pevik> (raw)
In-Reply-To: <ZeXe_WJcPDfea8eC@yuki>
> Hi!
> > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > > ---
> > > include/tst_safe_macros.h | 5 +++++
> > > lib/safe_macros.c | 18 ++++++++++++++++++
> > > 2 files changed, 23 insertions(+)
> > Although Cyril acked this I wonder why we are adding it into the old API.
> > Shouldn't it be added only into tst_safe_macros.c?
> To be honest I do not care that much as long as we do not expose the
> functions into the headers for old API. We will have to convert the
> safe_macros.c with coccinelle once all tests are converted and one more
> function in there does not really matter that much.
OTOH we have tst_* file, moving it there (+ remove 'm' from functions) would be
trivial (and less confusing). Sure, finally coccinelle will be used.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-04 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 15:37 [LTP] [PATCH v2 0/2] SysV IPC bug reproducer Andrea Cervesato
2024-02-26 15:37 ` [LTP] [PATCH v2 1/2] Add SAFE_MPROTECT() macro Andrea Cervesato
2024-02-26 15:44 ` Cyril Hrubis
2024-03-04 14:35 ` Petr Vorel
2024-03-04 14:47 ` Cyril Hrubis
2024-03-04 16:30 ` Petr Vorel [this message]
2024-02-26 15:37 ` [LTP] [PATCH v2 2/2] Add shmat04 SysV IPC bug reproducer Andrea Cervesato
2024-02-26 16:06 ` Cyril Hrubis
2024-03-04 14:17 ` Andrea Cervesato via ltp
2024-03-04 14:19 ` Cyril Hrubis
2024-03-04 14:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304163012.GA3191855@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.