From: Simon Horman <horms@kernel.org>
To: R SUNDAR <prosunofficial@gmail.com>
Cc: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removed blocking_link field description to prevent kernel doc warning
Date: Mon, 4 Mar 2024 17:28:36 +0000 [thread overview]
Message-ID: <20240304172836.GL403078@kernel.org> (raw)
In-Reply-To: <20240303144359.7066-1-prosunofficial@gmail.com>
On Sun, Mar 03, 2024 at 08:13:59PM +0530, R SUNDAR wrote:
> ./net/tipc/socket.c:143: warning: Excess struct member 'blocking_link' description in 'tipc_sock'
>
> Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
> ---
> net/tipc/socket.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index bb1118d02f95..7e4135db5816 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -80,7 +80,6 @@ struct sockaddr_pair {
> * @phdr: preformatted message header used when sending messages
> * @cong_links: list of congested links
> * @publications: list of publications for port
> - * @blocking_link: address of the congested link we are currently sleeping on
> * @pub_count: total # of publications port has made during its lifetime
> * @conn_timeout: the time we can wait for an unresponded setup request
> * @probe_unacked: probe has not received ack yet
Thanks, this looks good.
However, it duplicates a patch accepted upstream in January.
Link: https://git.kernel.org/netdev/net-next/c/88bf1b8f3c31
--
pw-bot: not-applicable
prev parent reply other threads:[~2024-03-04 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 14:43 [PATCH] Removed blocking_link field description to prevent kernel doc warning R SUNDAR
2024-03-04 17:28 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304172836.GL403078@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prosunofficial@gmail.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.