From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wander Lairson Costa <wander@redhat.com>,
Yan Zhai <yan@cloudflare.com>
Subject: Re: [PATCH v3 net-next 0/3] net: Provide SMP threads for backlog NAPI
Date: Mon, 4 Mar 2024 19:30:33 -0800 [thread overview]
Message-ID: <20240304193033.1c433585@kernel.org> (raw)
In-Reply-To: <20240228121000.526645-1-bigeasy@linutronix.de>
On Wed, 28 Feb 2024 13:05:47 +0100 Sebastian Andrzej Siewior wrote:
> The RPS code and "deferred skb free" both send IPI/ function call
> to a remote CPU in which a softirq is raised. This leads to a warning on
> PREEMPT_RT because raising softiqrs from function call led to undesired
> behaviour in the past. I had duct tape in RT for the "deferred skb free"
> and Wander Lairson Costa reported the RPS case.
>
> This series only provides support for SMP threads for backlog NAPI, I
> did not attach a patch to make it default and remove the IPI related
> code to avoid confusion. I can post it for reference it asked.
>
> The RedHat performance team was so kind to provide some testing here.
> The series (with the IPI code removed) has been tested and no regression
> vs without the series has been found. For testing iperf3 was used on 25G
> interface, provided by mlx5, ix40e or ice driver and RPS was enabled. I
> can provide the individual test results if needed.
Acked-by: Jakub Kicinski <kuba@kernel.org>
prev parent reply other threads:[~2024-03-05 3:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 12:05 [PATCH v3 net-next 0/3] net: Provide SMP threads for backlog NAPI Sebastian Andrzej Siewior
2024-02-28 12:05 ` [PATCH v3 net-next 1/4] net: Remove conditional threaded-NAPI wakeup based on task state Sebastian Andrzej Siewior
2024-02-28 12:05 ` [PATCH v3 net-next 2/4] net: Allow to use SMP threads for backlog NAPI Sebastian Andrzej Siewior
2024-03-05 10:08 ` Paolo Abeni
2024-03-05 10:35 ` Sebastian Andrzej Siewior
2024-03-05 10:44 ` Paolo Abeni
2024-03-05 10:52 ` Sebastian Andrzej Siewior
2024-03-05 15:23 ` Jakub Kicinski
2024-03-05 15:33 ` Eric Dumazet
2024-03-06 8:18 ` Sebastian Andrzej Siewior
2024-02-28 12:05 ` [PATCH v3 net-next 3/4] net: Use backlog-NAPI to clean up the defer_list Sebastian Andrzej Siewior
2024-03-05 9:55 ` Paolo Abeni
2024-03-05 10:25 ` Sebastian Andrzej Siewior
2024-03-05 10:36 ` Paolo Abeni
2024-03-05 10:40 ` Sebastian Andrzej Siewior
2024-02-28 12:05 ` [PATCH v3 net-next 4/4] net: Rename rps_lock to backlog_lock Sebastian Andrzej Siewior
2024-03-05 3:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304193033.1c433585@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.