From: Jakub Kicinski <kuba@kernel.org>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [PATCH net-next v9 02/13] net: Make dev_get_hwtstamp_phylib accessible
Date: Tue, 5 Mar 2024 07:05:22 -0800 [thread overview]
Message-ID: <20240305070522.7064e11a@kernel.org> (raw)
In-Reply-To: <20240305110233.2aca99f7@kmaincent-XPS-13-7390>
On Tue, 5 Mar 2024 11:02:33 +0100 Köry Maincent wrote:
> > > since we don't expect modules to call this, how about we move dev_set*
> > > and the new declaration to net/core/dev.h ?
> >
> > Ok for me.
>
> I replied to quickly.
> It seems this header in not include in ethtool part.
> This would imply adding #include "../core/dev.h" in the tsinfo.c file.
> Not sure this is what we want.
It's not amazing but I think that's better than putting internal stuff
in netdevice.h. ethtool is separated from core for code organization,
it's not really a separate entity, it controls very core things.
next prev parent reply other threads:[~2024-03-05 15:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 13:39 [PATCH net-next v9 00/13] net: Make timestamping selectable Kory Maincent
2024-02-26 13:39 ` [PATCH net-next v9 01/13] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Kory Maincent
2024-02-26 13:39 ` [PATCH net-next v9 02/13] net: Make dev_get_hwtstamp_phylib accessible Kory Maincent
2024-03-05 2:40 ` Jakub Kicinski
2024-03-05 9:56 ` Köry Maincent
2024-03-05 10:02 ` Köry Maincent
2024-03-05 15:05 ` Jakub Kicinski [this message]
2024-02-26 13:39 ` [PATCH net-next v9 03/13] net: Make net_hwtstamp_validate accessible Kory Maincent
2024-02-26 13:39 ` [PATCH net-next v9 04/13] net: Change the API of PHY default timestamp to MAC Kory Maincent
2024-02-26 13:39 ` [PATCH net-next v9 05/13] net: net_tstamp: Add unspec field to hwtstamp_source enumeration Kory Maincent
2024-02-26 13:39 ` [PATCH net-next v9 06/13] net: Add struct kernel_ethtool_ts_info Kory Maincent
2024-02-26 16:47 ` Alexandra Winter
2024-02-28 3:27 ` Jakub Kicinski
2024-02-29 9:17 ` Köry Maincent
2024-02-26 13:39 ` [PATCH net-next v9 07/13] ptp: Move from simple ida to xarray Kory Maincent
2024-03-05 2:47 ` Jakub Kicinski
2024-03-05 9:02 ` Köry Maincent
2024-03-05 15:03 ` Jakub Kicinski
2024-02-26 13:39 ` [PATCH net-next v9 08/13] ptp: Add phc source and helpers to register specific PTP clock or get information Kory Maincent
2024-03-05 2:57 ` Jakub Kicinski
2024-03-05 8:36 ` Russell King (Oracle)
2024-03-05 10:10 ` Köry Maincent
2024-03-05 14:59 ` Jakub Kicinski
2024-03-05 15:35 ` Köry Maincent
2024-03-05 16:39 ` Jakub Kicinski
2024-02-26 13:40 ` [PATCH net-next v9 09/13] net: Add the possibility to support a selected hwtstamp in netdevice Kory Maincent
2024-02-26 13:40 ` [PATCH net-next v9 10/13] net: netdevsim: ptp_mock: Convert to netdev_ptp_clock_register Kory Maincent
2024-02-26 13:40 ` [PATCH net-next v9 11/13] net: macb: " Kory Maincent
2024-02-26 13:40 ` [PATCH net-next v9 12/13] net: ethtool: tsinfo: Add support for hwtstamp provider and get/set hwtstamp config Kory Maincent
2024-03-05 3:27 ` Jakub Kicinski
2024-03-05 16:52 ` Köry Maincent
2024-03-05 18:04 ` Jakub Kicinski
2024-02-26 13:40 ` [PATCH net-next v9 13/13] netlink: specs: tsinfo: Enhance netlink attributes and add a set command Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305070522.7064e11a@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.