From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 262185915D; Tue, 5 Mar 2024 14:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709648345; cv=none; b=clX/ZgA3BvSyGOH4lNYQhvPH7j+TDRa/kdAQ4mwQLZwp51AtHpe3nd9H553rwum5lvWryU9K0t5i/DEQqTXn+ErmPUJE8htrO4liy5k50tnsuN5oDb6q9XdP86zEn0BUpscvzzDuvh0JJwxAzG8AnR+CzUEiy/hccBZZoFwxD1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709648345; c=relaxed/simple; bh=hkLU/18Cgjxnj864xqTHUx7XR5iiSbQ0FdD/WYjDWdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A52yfs3/XNe6m+GJmHjMMpnXVH5X3ycThzNwUKPARHPWDwp/ib3GhqPYS52AM5ujvWZdgSAasV7bJqmVympJX7f3hhzn6C4jr2adSb0Kwv4ibFYhsVKL9Y0maWDM+eIt1EWzeGhu3q7sU0T0nowgkrM+HI5ZhjP2MwlmMJudhG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=MaV2jXya; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MaV2jXya" Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EC152A27; Tue, 5 Mar 2024 15:18:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709648323; bh=hkLU/18Cgjxnj864xqTHUx7XR5iiSbQ0FdD/WYjDWdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MaV2jXyaB2KFUGcG+eyfmDRB6RKjwb6u8Gdsp79fIFzH7l4PoRgd9puWs1M5jkn72 ZaJtzVM6Z7y4HB2Sq7q2LAe8F5hwUwDxWjL6nAsfaymb/tXx4fA7WZSoKAPVzZ4cBD 4bzOSWfEJvMlcE3Xdua4sRTI9WYovXfYu4aJV7NQ= Date: Tue, 5 Mar 2024 16:19:00 +0200 From: Laurent Pinchart To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, NXP Linux Team , Conor Dooley , Pengutronix Kernel Team , Valentin Raevsky , Krzysztof Kozlowski , Baruch Siach , Sascha Hauer , linux-rtc@vger.kernel.org, Marek Vasut , Shawn Guo , Fabio Estevam , Rob Herring , Alexandre Belloni Subject: Re: [PATCH 0/4] Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS Message-ID: <20240305141900.GD12482@pendragon.ideasonboard.com> References: <20240305004222.622-1-laurent.pinchart@ideasonboard.com> <170964448684.3160987.11938853123583954222.robh@kernel.org> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <170964448684.3160987.11938853123583954222.robh@kernel.org> Hi Rob, On Tue, Mar 05, 2024 at 07:20:21AM -0600, Rob Herring wrote: > On Tue, 05 Mar 2024 02:42:17 +0200, Laurent Pinchart wrote: > > Hello, > > > > This small patch series is a drive-by addition of the Compulab > > SB-UCM-iMX8MPLUS to the Linux kernel device tree sources. While porting > > the device tree from the Compulab BSP kernel to mainline, I thought I > > could as well mainline it, along with related conversion of text DT > > bindings to YAML. > > > > The SB-UCM-iMX8MPLUS is a carrier board designed as a reference to > > evaluate the Compulab UCM-iMX8MPLUS SoM. The SoM integrates the bare > > minimal peripherals (DRAM, eMMC, ethernet PHY, EEPROM and RTC), while > > the carrier board includes a much wider range of peripherals. I have > > only enabled support for the ones I am interested in, or, as a strech > > goal, the ones I could easily test. > > > > The first patch in the series adds compatible strings for the SoM and > > the board to the ARM FSL bindings. The next patch then converts text DT > > bindings to a YAML schema for the RTC present on the SoM. Finally, the > > last two patches add DT sources for the SoM and the carrier board. > > > > Please see individual patches for details. > > > > I have checked the validity of the bindings and the device tree sources. > > The only warnings in the DT sources are due to issues in imx8mp.dtsi. > > > > Laurent Pinchart (4): > > dt-bindings: arm: fsl: Add Compulab SB-UCM-iMX8MPLUS carrier board > > dt-bindings: rtc: abx80x: Convert text bindings to YAML > > arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus > > arm64: dts: freescale: Add device tree for Compulab SB-UCM-iMX8MPLUS > > > > .../devicetree/bindings/arm/fsl.yaml | 6 + > > .../bindings/rtc/abracon,abx80x.txt | 31 -- > > .../bindings/rtc/abracon,abx80x.yaml | 89 +++++ > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../boot/dts/freescale/imx8mp-sb-ucm.dts | 284 ++++++++++++++++ > > arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi | 309 ++++++++++++++++++ > > 6 files changed, 689 insertions(+), 31 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > > create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y freescale/imx8mp-sb-ucm.dtb' for 20240305004222.622-1-laurent.pinchart@ideasonboard.com: > > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:68.1-10 Label or path hdmi_pvi not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:72.1-9 Label or path hdmi_tx not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:86.1-13 Label or path hdmi_tx_phy not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:208.1-8 Label or path lcdif3 not found I forgot to mention in the cover letter that this depends on i.MX8MP HDMI integration in DT that is currently pending. As it's not in linux-next yet, I'll send a v2 that splits HDMI support in a separate patch. Depending on when the HDMI integration gets merged, the base SB-UCM support can go in by itself or with HDMI support in v6.10. > FATAL ERROR: Syntax error parsing input tree > make[3]: *** [scripts/Makefile.lib:419: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb] Error 1 > make[2]: *** [scripts/Makefile.build:481: arch/arm64/boot/dts/freescale] Error 2 > make[2]: Target 'arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb' not remade because of errors. > make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1385: freescale/imx8mp-sb-ucm.dtb] Error 2 > make: *** [Makefile:240: __sub-make] Error 2 > make: Target 'freescale/imx8mp-sb-ucm.dtb' not remade because of errors. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40C60C54798 for ; Tue, 5 Mar 2024 14:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lUcZ7kjciRxXtRjXrjdxy5vHcDpcRG1EqoS6lC9Uci4=; b=NkAgDBq7Zh6fUo wpX3g9ExTI6kqQhYBixYmYom0knc03A4T3KihBQVfNSwFcJzvSw2WTVD98vQeyiOcWvy+0diN9yd0 wXGC4B8Sc/6jXdm+GM6h18Hz+br8yRn4DjT1mMPcr96ks+NZEEPIAYSRXnAgA1taR/gKxeQWZbztR N+/cS3MwfgNgQEiO/nAJJ7hV7yiVQNXGRpBNLIrJVFeOX9ZqiJ1AzxaAiHz5xMrL6R/yG8fMgovMV UVZamTKMptD4rumznbfZrGeyF/yjZqfnQpQuCFIo3hAAj1nwofqZ5GAdu8ojMyVk09Xb3eCn2qBOd 8Fls486FqkS3v6jN73oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhVdM-0000000Dztd-2kUG; Tue, 05 Mar 2024 14:19:08 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhVdI-0000000Dzsm-45Rn for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2024 14:19:06 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EC152A27; Tue, 5 Mar 2024 15:18:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709648323; bh=hkLU/18Cgjxnj864xqTHUx7XR5iiSbQ0FdD/WYjDWdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MaV2jXyaB2KFUGcG+eyfmDRB6RKjwb6u8Gdsp79fIFzH7l4PoRgd9puWs1M5jkn72 ZaJtzVM6Z7y4HB2Sq7q2LAe8F5hwUwDxWjL6nAsfaymb/tXx4fA7WZSoKAPVzZ4cBD 4bzOSWfEJvMlcE3Xdua4sRTI9WYovXfYu4aJV7NQ= Date: Tue, 5 Mar 2024 16:19:00 +0200 From: Laurent Pinchart To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, NXP Linux Team , Conor Dooley , Pengutronix Kernel Team , Valentin Raevsky , Krzysztof Kozlowski , Baruch Siach , Sascha Hauer , linux-rtc@vger.kernel.org, Marek Vasut , Shawn Guo , Fabio Estevam , Rob Herring , Alexandre Belloni Subject: Re: [PATCH 0/4] Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS Message-ID: <20240305141900.GD12482@pendragon.ideasonboard.com> References: <20240305004222.622-1-laurent.pinchart@ideasonboard.com> <170964448684.3160987.11938853123583954222.robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <170964448684.3160987.11938853123583954222.robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240305_061905_191978_EBD7D2C5 X-CRM114-Status: GOOD ( 34.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Tue, Mar 05, 2024 at 07:20:21AM -0600, Rob Herring wrote: > On Tue, 05 Mar 2024 02:42:17 +0200, Laurent Pinchart wrote: > > Hello, > > > > This small patch series is a drive-by addition of the Compulab > > SB-UCM-iMX8MPLUS to the Linux kernel device tree sources. While porting > > the device tree from the Compulab BSP kernel to mainline, I thought I > > could as well mainline it, along with related conversion of text DT > > bindings to YAML. > > > > The SB-UCM-iMX8MPLUS is a carrier board designed as a reference to > > evaluate the Compulab UCM-iMX8MPLUS SoM. The SoM integrates the bare > > minimal peripherals (DRAM, eMMC, ethernet PHY, EEPROM and RTC), while > > the carrier board includes a much wider range of peripherals. I have > > only enabled support for the ones I am interested in, or, as a strech > > goal, the ones I could easily test. > > > > The first patch in the series adds compatible strings for the SoM and > > the board to the ARM FSL bindings. The next patch then converts text DT > > bindings to a YAML schema for the RTC present on the SoM. Finally, the > > last two patches add DT sources for the SoM and the carrier board. > > > > Please see individual patches for details. > > > > I have checked the validity of the bindings and the device tree sources. > > The only warnings in the DT sources are due to issues in imx8mp.dtsi. > > > > Laurent Pinchart (4): > > dt-bindings: arm: fsl: Add Compulab SB-UCM-iMX8MPLUS carrier board > > dt-bindings: rtc: abx80x: Convert text bindings to YAML > > arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus > > arm64: dts: freescale: Add device tree for Compulab SB-UCM-iMX8MPLUS > > > > .../devicetree/bindings/arm/fsl.yaml | 6 + > > .../bindings/rtc/abracon,abx80x.txt | 31 -- > > .../bindings/rtc/abracon,abx80x.yaml | 89 +++++ > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../boot/dts/freescale/imx8mp-sb-ucm.dts | 284 ++++++++++++++++ > > arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi | 309 ++++++++++++++++++ > > 6 files changed, 689 insertions(+), 31 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > > create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y freescale/imx8mp-sb-ucm.dtb' for 20240305004222.622-1-laurent.pinchart@ideasonboard.com: > > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:68.1-10 Label or path hdmi_pvi not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:72.1-9 Label or path hdmi_tx not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:86.1-13 Label or path hdmi_tx_phy not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:208.1-8 Label or path lcdif3 not found I forgot to mention in the cover letter that this depends on i.MX8MP HDMI integration in DT that is currently pending. As it's not in linux-next yet, I'll send a v2 that splits HDMI support in a separate patch. Depending on when the HDMI integration gets merged, the base SB-UCM support can go in by itself or with HDMI support in v6.10. > FATAL ERROR: Syntax error parsing input tree > make[3]: *** [scripts/Makefile.lib:419: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb] Error 1 > make[2]: *** [scripts/Makefile.build:481: arch/arm64/boot/dts/freescale] Error 2 > make[2]: Target 'arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb' not remade because of errors. > make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1385: freescale/imx8mp-sb-ucm.dtb] Error 2 > make: *** [Makefile:240: __sub-make] Error 2 > make: Target 'freescale/imx8mp-sb-ucm.dtb' not remade because of errors. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel