Re: [PATCH v3 1/4] hw/i386/pc: Remove "rtc_state" link again

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Mar 05, 2024 at 07:54:40PM +0000, Bernhard Beschow wrote:
> 
> 
> Am 5. März 2024 15:57:08 UTC schrieb Peter Maydell <peter.maydell@linaro.org>:
> >On Sun, 3 Mar 2024 at 18:55, Bernhard Beschow <shentey@gmail.com> wrote:
> >>
> >> Commit 99e1c1137b6f "hw/i386/pc: Populate RTC attribute directly" made linking
> >> the "rtc_state" property unnecessary and removed it. Commit 84e945aad2d0 "vl,
> >> pc: turn -no-fd-bootchk into a machine property" accidently reintroduced the
> >> link. Remove it again since it is not needed.
> >>
> >> Fixes: 84e945aad2d0 "vl, pc: turn -no-fd-bootchk into a machine property"
> >> Cc: Paolo Bonzini <pbonzini@redhat.com>
> >> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> >
> >Ah, I did wonder when I was working with this code whether that
> >rtc_state link was really necessary.
> >
> >We could now remove the rtc argument from the pc_cmos_init()
> >function, because we can guarantee that it's in x86ms->rtc,
> >which the function already has access to from its pcms argument.
> 
> This series goes one step further and inlines this function. It would be a nice to get some feedback before the freeze.
> 
> Best regards,
> Bernhard

I like it, I tagged it for merge.

> >
> >thanks
> >-- PMM