All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Leon M. Busch-George" <leon@georgemail.de>
To: u-boot@lists.denx.de, Dragan Simic <dsimic@manjaro.org>
Subject: [PATCH v3] Makefile: use shell to calculate map_size
Date: Tue,  5 Mar 2024 17:46:24 +0100	[thread overview]
Message-ID: <20240305164707.23144-1-leon@georgemail.de> (raw)
In-Reply-To: <20240304203909.63796-1-leon@georgemail.de>

From: "Leon M. Busch-George" <leon@georgemail.eu>

The error message "bc: command not found" is easily missed since the
build continues.
bc is not a part of coreutils or base-devel. POSIX sh can also do the
calculation.

Signed-off-by: Leon M. Busch-George <leon@georgemail.eu>
---
 Makefile | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index a2bc9d5903..0aef07ef3b 100644
--- a/Makefile
+++ b/Makefile
@@ -1275,10 +1275,15 @@ OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
 binary_size_check: u-boot-nodtb.bin FORCE
 	@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
 	map_size=$(shell cat u-boot.map | \
-		awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
-		| sed 's/0X//g' \
-		| bc); \
-	if [ "" != "$$map_size" ]; then \
+		awk ' \
+			/_image_copy_start/ { start = $$1 } \
+			/_image_binary_end/ { end = $$1 } \
+			END { \
+				if (start != "" && end != "") \
+					print end " " start; \
+			}' \
+		| sh -c 'read end start && echo $$((end - start))'); \
+	if [ -n "$$map_size" ]; then \
 		if test $$map_size -ne $$file_size; then \
 			echo "u-boot.map shows a binary size of $$map_size" >&2 ; \
 			echo "  but u-boot-nodtb.bin shows $$file_size" >&2 ; \
-- 
2.44.0


  parent reply	other threads:[~2024-03-05 16:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-02 13:17 [PATCH] Makefile: use shell to calculate map_size Leon M. Busch-George
2024-03-02 21:13 ` Dragan Simic
     [not found]   ` <20240304154007.67df1822@couch-potassium>
2024-03-04 15:57     ` Leon Busch-George
2024-03-04 20:38 ` [PATCH v2] " Leon M. Busch-George
2024-03-05 16:40   ` Leon Busch-George
2024-03-05 16:46   ` Leon M. Busch-George [this message]
     [not found]     ` <343281d5cf78e8c473e40f58361e01e1@manjaro.org>
2024-03-10 10:33       ` [PATCH v3] " Dragan Simic
     [not found]   ` <b594973ddce475d2a2baead6f4028134@manjaro.org>
2024-03-10 10:12     ` [PATCH v2] " Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305164707.23144-1-leon@georgemail.de \
    --to=leon@georgemail.de \
    --cc=dsimic@manjaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.