Re: [meta-arago][master][PATCH] base-files: Remove fstab override

[Denys Dmytriyenko <denis@denix.org>]

On Tue, Mar 05, 2024 at 01:11:45PM -0600, Andrew Davis via lists.yoctoproject.org wrote:
> There is already a version of this file provided by oe-core that
> is kept up to date. Do not override it.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../recipes-core/base-files/base-files/fstab        | 13 -------------
>  .../recipes-core/base-files/base-files_%.bbappend   |  2 +-
>  2 files changed, 1 insertion(+), 14 deletions(-)
>  delete mode 100644 meta-arago-distro/recipes-core/base-files/base-files/fstab
> 
> diff --git a/meta-arago-distro/recipes-core/base-files/base-files/fstab b/meta-arago-distro/recipes-core/base-files/base-files/fstab
> deleted file mode 100644
> index 8ddadd98..00000000
> --- a/meta-arago-distro/recipes-core/base-files/base-files/fstab
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -# stock fstab - you probably want to override this with a machine specific one
> -
> -/dev/root            /                    auto       defaults              1  1
> -proc                 /proc                proc       defaults              0  0
> -devpts               /dev/pts             devpts     mode=0620,gid=5       0  0
> -usbdevfs             /proc/bus/usb        usbdevfs   noauto                0  0
> -tmpfs                /run                 tmpfs      mode=0755,nodev,nosuid,strictatime 0  0

> -tmpfs                /var/volatile        tmpfs      defaults,size=50M     0  0
> -tmpfs                /media/ram           tmpfs      defaults,size=16M     0  0

The major difference is these 2 tmpfs entries - upstream doesn't have 
/media/ram, as that was something TI testing framework was using. Plus 
upstream doesn't set the size parameter - by default up to 50% of RAM can 
get used by tmpfs and there were issues with some low-RAM legacy platforms 
in the past.

If neither of these differences matter any longer, this can be removed.


> -# uncomment this if your device has a SD/MMC/Transflash slot
> -#/dev/mmcblk0p1       /media/card          auto       defaults,sync,noauto  0  0
> -
> diff --git a/meta-arago-distro/recipes-core/base-files/base-files_%.bbappend b/meta-arago-distro/recipes-core/base-files/base-files_%.bbappend
> index e5c53e80..7d1f6751 100644
> --- a/meta-arago-distro/recipes-core/base-files/base-files_%.bbappend
> +++ b/meta-arago-distro/recipes-core/base-files/base-files_%.bbappend
> @@ -1,4 +1,4 @@
>  # look for files in this layer first
>  FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
>  
> -PR:append = ".arago4"
> +PR:append = ".arago5"
> -- 
> 2.39.2