All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>
Subject: [net-next V5 13/15] net/mlx5e: Block TLS device offload on combined SD netdev
Date: Tue,  5 Mar 2024 19:02:56 -0800	[thread overview]
Message-ID: <20240306030258.16874-14-saeed@kernel.org> (raw)
In-Reply-To: <20240306030258.16874-1-saeed@kernel.org>

From: Tariq Toukan <tariqt@nvidia.com>

1) Each TX TLS device offloaded context has its own TIS object.  Extra work
is needed to get it working in a SD environment, where a stream can move
between different SQs (belonging to different mdevs).

2) Each RX TLS device offloaded context needs a DEK object from the DEK
pool.

Extra work is needed to get it working in a SD environment, as the DEK
pool currently falsely depends on TX cap, and is on the primary device
only.

Disallow this combination for now.

Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
index 984fa04bd331..e3e57c849436 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
@@ -96,7 +96,7 @@ bool mlx5e_is_ktls_rx(struct mlx5_core_dev *mdev)
 {
 	u8 max_sq_wqebbs = mlx5e_get_max_sq_wqebbs(mdev);
 
-	if (is_kdump_kernel() || !MLX5_CAP_GEN(mdev, tls_rx))
+	if (is_kdump_kernel() || !MLX5_CAP_GEN(mdev, tls_rx) || mlx5_get_sd(mdev))
 		return false;
 
 	/* Check the possibility to post the required ICOSQ WQEs. */
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h
index f11075e67658..adc6d8ea0960 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h
@@ -11,6 +11,7 @@
 
 #ifdef CONFIG_MLX5_EN_TLS
 #include "lib/crypto.h"
+#include "lib/mlx5.h"
 
 struct mlx5_crypto_dek *mlx5_ktls_create_key(struct mlx5_crypto_dek_pool *dek_pool,
 					     struct tls_crypto_info *crypto_info);
@@ -61,7 +62,8 @@ void mlx5e_ktls_rx_resync_destroy_resp_list(struct mlx5e_ktls_resync_resp *resp_
 
 static inline bool mlx5e_is_ktls_tx(struct mlx5_core_dev *mdev)
 {
-	return !is_kdump_kernel() && MLX5_CAP_GEN(mdev, tls_tx);
+	return !is_kdump_kernel() && MLX5_CAP_GEN(mdev, tls_tx) &&
+		!mlx5_get_sd(mdev);
 }
 
 bool mlx5e_is_ktls_rx(struct mlx5_core_dev *mdev);
-- 
2.44.0


  parent reply	other threads:[~2024-03-06  3:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  3:02 [pull request][net-next V5 00/15] mlx5 socket direct (Multi-PF) Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 01/15] net/mlx5: Add MPIR bit in mcam_access_reg Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 02/15] net/mlx5: SD, Introduce SD lib Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 03/15] net/mlx5: SD, Implement basic query and instantiation Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 04/15] net/mlx5: SD, Implement devcom communication and primary election Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 05/15] net/mlx5: SD, Implement steering for primary and secondaries Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 06/15] net/mlx5: SD, Add informative prints in kernel log Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 07/15] net/mlx5: SD, Add debugfs Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 08/15] net/mlx5e: Create single netdev per SD group Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 09/15] net/mlx5e: Create EN core HW resources for all secondary devices Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 10/15] net/mlx5e: Let channels be SD-aware Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 11/15] net/mlx5e: Support cross-vhca RSS Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 12/15] net/mlx5e: Support per-mdev queue counter Saeed Mahameed
2024-03-06  3:02 ` Saeed Mahameed [this message]
2024-03-06  3:02 ` [net-next V5 14/15] net/mlx5: Enable SD feature Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 15/15] Documentation: networking: Add description for multi-pf netdev Saeed Mahameed
2024-03-07  4:53   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240306030258.16874-14-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.