From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH xtables-nft v2] extensions: xt_socket: add txlate support for socket match
Date: Wed, 6 Mar 2024 16:42:07 +0100 [thread overview]
Message-ID: <20240306154207.GD4420@breakpoint.cc> (raw)
In-Reply-To: <ZeiDKkam7FXpCbiU@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> On Wed, Mar 06, 2024 at 11:11:25AM +0100, Florian Westphal wrote:
> > +static int socket_mt_xlate(struct xt_xlate *xl, const struct xt_xlate_mt_params *params)
> > +{
> > + const struct xt_socket_mtinfo3 *info = (const void *)params->match->data;
> > + const char *space = "";
>
> The whole "leading space or not" handling is not necessary, I made
> xt_xlate_add() insert leading space automatically if the first
> character is alpha-numeric or a brace.
Perfect, I'll push this out after removing the extra handling.
next prev parent reply other threads:[~2024-03-06 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 10:11 [PATCH xtables-nft v2] extensions: xt_socket: add txlate support for socket match Florian Westphal
2024-03-06 14:52 ` Phil Sutter
2024-03-06 15:42 ` Florian Westphal [this message]
2024-03-06 16:12 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306154207.GD4420@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.