From: Rob Herring <robh@kernel.org>
To: Mark Brown <broonie@kernel.org>, Zhang Yi <zhangyi@everest-semi.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
tiwai@suse.com, amadeuszx.slawinski@linux.intel.com,
yangxiaohua@everest-semi.com, zhuning@everest-semi.com
Subject: Re: [PATCH v1 2/2] ASoC: codecs: ES8326: change support for ES8326
Date: Wed, 6 Mar 2024 15:35:20 -0600 [thread overview]
Message-ID: <20240306213520.GA713664-robh@kernel.org> (raw)
In-Reply-To: <bf4651f8-279c-429a-8337-2211ce0b89ed@sirena.org.uk>
On Wed, Mar 06, 2024 at 12:36:50PM +0000, Mark Brown wrote:
> On Wed, Mar 06, 2024 at 09:34:14AM +0800, Zhang Yi wrote:
> > Removed mic1-src and mic2-src. and changed default value
> > of interrupt-clk
>
> We could do with a better changelog here.
>
> > - everest,mic1-src:
> > - $ref: /schemas/types.yaml#/definitions/uint8
> > - description:
> > - the value of reg 2A when headset plugged.
> > - minimum: 0x00
> > - maximum: 0x77
> > - default: 0x22
> > -
> > - everest,mic2-src:
> > - $ref: /schemas/types.yaml#/definitions/uint8
> > - description:
> > - the value of reg 2A when headset unplugged.
> > - minimum: 0x00
> > - maximum: 0x77
> > - default: 0x44
>
> This will make any DTs using the properties instantly buggy. I believe
> there's a way of marking properties as deprecated, you should use that
> instead. Or we could just leave the properties there and ignore them at
> runtime.
'deprecated: true' is the way.
Rob
next prev parent reply other threads:[~2024-03-06 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:34 [PATCH v1 0/2] ASoC: codecs: ES8326: change members of private structure Zhang Yi
2024-03-06 1:34 ` [PATCH v1 1/2] ASoC: codecs: ES8326: Changing " Zhang Yi
2024-03-06 1:34 ` [PATCH v1 2/2] ASoC: codecs: ES8326: change support for ES8326 Zhang Yi
2024-03-06 12:36 ` Mark Brown
2024-03-06 21:35 ` Rob Herring [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-07 3:04 Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306213520.GA713664-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhangyi@everest-semi.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.