From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
virtualization@lists.linux.dev
Subject: Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
Date: Thu, 7 Mar 2024 08:03:39 -0800 [thread overview]
Message-ID: <20240307080339.09125a2f@kernel.org> (raw)
In-Reply-To: <1709804195.5639746-1-xuanzhuo@linux.alibaba.com>
On Thu, 7 Mar 2024 17:36:35 +0800 Xuan Zhuo wrote:
> > Please wait for this API to get merged:
> > https://lore.kernel.org/all/20240226211015.1244807-1-kuba@kernel.org/
> > A lot of the stats you're adding here can go into the new API.
> > More drivers can report things like number of LSO / GRO packets.
>
> In this patch set, I just see two for tx, three for rx.
> And what stats do you want to put into this API?
>
> And on the other side, how should we judge whether a stat is placed in this api
> or the interface of ethtool -S?
A bit of a judgment call indeed, let me reply on patch 3 and we
can go over them one by one before you invest the time re-coding.
next prev parent reply other threads:[~2024-03-07 16:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 8:02 [PATCH net-next v3 0/6] virtio-net: support device stats Xuan Zhuo
2024-02-27 8:02 ` [PATCH net-next v3 1/6] virtio_net: introduce device stats feature and structures Xuan Zhuo
2024-02-27 13:16 ` Jiri Pirko
2024-02-27 8:02 ` [PATCH net-next v3 2/6] virtio_net: virtnet_send_command supports command-specific-result Xuan Zhuo
2024-02-27 13:23 ` Jiri Pirko
2024-02-27 8:03 ` [PATCH net-next v3 3/6] virtio_net: support device stats Xuan Zhuo
2024-02-27 14:56 ` Jiri Pirko
2024-02-27 19:19 ` Simon Horman
2024-02-29 10:35 ` kernel test robot
2024-03-07 16:50 ` Jakub Kicinski
2024-03-11 10:48 ` Xuan Zhuo
2024-03-11 15:43 ` Jakub Kicinski
2024-02-27 8:03 ` [PATCH net-next v3 4/6] virtio_net: stats map include driver stats Xuan Zhuo
2024-02-27 15:05 ` Jiri Pirko
2024-02-27 8:03 ` [PATCH net-next v3 5/6] virtio_net: add the total stats field Xuan Zhuo
2024-02-27 14:54 ` Jakub Kicinski
2024-02-27 15:07 ` Jiri Pirko
2024-02-27 15:41 ` Jakub Kicinski
2024-02-27 15:59 ` Jiri Pirko
2024-03-07 9:36 ` Xuan Zhuo
2024-03-07 16:03 ` Jakub Kicinski [this message]
2024-02-27 8:03 ` [PATCH net-next v3 6/6] virtio_net: rename stat tx_timeout to timeout Xuan Zhuo
2024-02-27 15:08 ` Jiri Pirko
2024-02-27 13:14 ` [PATCH net-next v3 0/6] virtio-net: support device stats Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307080339.09125a2f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.