From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: <almasrymina@google.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <leonro@nvidia.com>,
<gal@nvidia.com>,
"Anatoli N . Chechelnickiy"
<Anatoli.Chechelnickiy@m.interpipe.biz>,
Ian Kumlien <ian.kumlien@gmail.com>, <stable@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: esp: fix bad handling of pages from page_pool
Date: Thu, 7 Mar 2024 09:51:58 -0800 [thread overview]
Message-ID: <20240307095158.099d25ed@kernel.org> (raw)
In-Reply-To: <20240307101548.815189-1-dtatulea@nvidia.com>
LGTM, thanks! Minor nit picks for the tags, otherise:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
On Thu, 7 Mar 2024 12:15:47 +0200 Dragos Tatulea wrote:
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
General guidance is to order tag chronologically, so:
Cc: stable@vger.kernel.org
Fixes: (speaking of which, you need to add it, presumably point it at
the commit where skb->pp_recycle was added)
Reported-by:
Link / Closes:
your sign-off
Review tags
> Reported-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@m.interpipe.biz>
> Tested-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@m.interpipe.biz>
You can combine it as Reported-and-tested-by:
up to you
> Reported-by: Ian Kumlien <ian.kumlien@gmail.com>
> Closes: https: //lore.kernel.org/netdev/CAA85sZvvHtrpTQRqdaOx6gd55zPAVsqMYk_Lwh4Md5knTq7AyA@mail.gmail.com
A space sneaked into the link.
> Cc: stable@vger.kernel.org
> Reviewed-by: Mina Almasry <almasrymina@google.com>
> Change-Id: I3d2744e1abb33a694a8f49e07f913724a0f8871a
Change-Id's gotta go.
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-07 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 10:15 [PATCH net] net: esp: fix bad handling of pages from page_pool Dragos Tatulea
2024-03-07 17:51 ` Jakub Kicinski [this message]
2024-03-07 18:33 ` Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307095158.099d25ed@kernel.org \
--to=kuba@kernel.org \
--cc=Anatoli.Chechelnickiy@m.interpipe.biz \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=herbert@gondor.apana.org.au \
--cc=ian.kumlien@gmail.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.