From: Simon Horman <horms@kernel.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dietmar Maurer <dietmar@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [PATCH net] netfilter: conntrack: fix ct-state for ICMPv6 Multicast Router Discovery
Date: Thu, 7 Mar 2024 10:12:54 +0000 [thread overview]
Message-ID: <20240307101254.GL281974@kernel.org> (raw)
In-Reply-To: <20240306141805.17679-1-linus.luessing@c0d3.blue>
On Wed, Mar 06, 2024 at 03:18:04PM +0100, Linus Lüssing wrote:
> So far Multicast Router Advertisements and Multicast Router
> Solicitations from the Multicast Router Discovery protocol (RFC4286)
> would be marked as INVALID for IPv6, even if they are in fact intact
> and adhering to RFC4286.
>
> This broke MRA reception and by that multicast reception on
> IPv6 multicast routers in a Proxmox managed setup, where Proxmox
> would install a rule like "-m conntrack --ctstate INVALID -j DROP"
> at the top of the FORWARD chain with br-nf-call-ip6tables enabled
> by default.
>
> Similar to as it's done for MLDv1, MLDv2 and IPv6 Neighbor Discovery
> already, fix this issue by excluding MRD from connection tracking
> handling as MRD always uses predefined multicast destinations
> for its messages, too. This changes the ct-state for ICMPv6 MRD messages
> from INVALID to UNTRACKED.
>
> This issue was found and fixed with the help of the mrdisc tool
> (https://github.com/troglobit/mrdisc).
>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Hi Linus,
this appears to be a fix and as such I think it warrants a Fixes tag.
You should be able to just add it to this thread if no other changes
are required - no need for a v2 just to address this.
...
next prev parent reply other threads:[~2024-03-07 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:18 [PATCH net] netfilter: conntrack: fix ct-state for ICMPv6 Multicast Router Discovery Linus Lüssing
2024-03-07 10:12 ` Simon Horman [this message]
2024-03-13 19:40 ` Linus Lüssing
2024-03-13 19:44 ` Florian Westphal
2024-03-21 20:52 ` Pablo Neira Ayuso
2024-04-26 8:45 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307101254.GL281974@kernel.org \
--to=horms@kernel.org \
--cc=aderumier@odiso.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dietmar@proxmox.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.