All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [robertosassu:evm-fscaps-v2 29/29] security/security.c:2375:15: error: implicit declaration of function 'ima_inode_set_fscaps'; did you mean 'evm_inode_set_fscaps'?
Date: Thu, 7 Mar 2024 12:55:14 +0800	[thread overview]
Message-ID: <202403071228.6gAA2DMl-lkp@intel.com> (raw)

tree:   https://github.com/robertosassu/linux evm-fscaps-v2
head:   49621962de7e9bad18b99e21dcb8b32f5af7b61e
commit: 49621962de7e9bad18b99e21dcb8b32f5af7b61e [29/29] fixes
config: x86_64-randconfig-122-20240306 (https://download.01.org/0day-ci/archive/20240307/202403071228.6gAA2DMl-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071228.6gAA2DMl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403071228.6gAA2DMl-lkp@intel.com/

All errors (new ones prefixed by >>):

   security/security.c: In function 'security_inode_set_fscaps':
>> security/security.c:2375:15: error: implicit declaration of function 'ima_inode_set_fscaps'; did you mean 'evm_inode_set_fscaps'? [-Werror=implicit-function-declaration]
    2375 |         ret = ima_inode_set_fscaps(idmap, dentry, caps, flags);
         |               ^~~~~~~~~~~~~~~~~~~~
         |               evm_inode_set_fscaps
   security/security.c: In function 'security_inode_remove_fscaps':
>> security/security.c:2434:15: error: implicit declaration of function 'ima_inode_remove_fscaps'; did you mean 'evm_inode_remove_fscaps'? [-Werror=implicit-function-declaration]
    2434 |         ret = ima_inode_remove_fscaps(dentry);
         |               ^~~~~~~~~~~~~~~~~~~~~~~
         |               evm_inode_remove_fscaps
   cc1: some warnings being treated as errors


vim +2375 security/security.c

  2353	
  2354	/**
  2355	 * security_inode_set_fscaps() - Check if setting fscaps is allowed
  2356	 * @idmap: idmap of the mount
  2357	 * @dentry: file
  2358	 * @caps: fscaps to be written
  2359	 * @flags: flags for setxattr
  2360	 *
  2361	 * Check permission before setting the file capabilities given in @vfs_caps.
  2362	 *
  2363	 * Return: Returns 0 if permission is granted.
  2364	 */
  2365	int security_inode_set_fscaps(struct mnt_idmap *idmap, struct dentry *dentry,
  2366				      const struct vfs_caps *caps, int flags)
  2367	{
  2368		int ret;
  2369	
  2370		if (unlikely(IS_PRIVATE(d_backing_inode(dentry))))
  2371			return 0;
  2372		ret = call_int_hook(inode_set_fscaps, 0, idmap, dentry, caps, flags);
  2373		if (ret)
  2374			return ret;
> 2375		ret = ima_inode_set_fscaps(idmap, dentry, caps, flags);
  2376		if (ret)
  2377			return ret;
  2378		return evm_inode_set_fscaps(idmap, dentry, caps, flags);
  2379	}
  2380	
  2381	/**
  2382	 * security_inode_post_set_fscaps() - Update the inode after setting fscaps
  2383	 * @idmap: idmap of the mount
  2384	 * @dentry: file
  2385	 * @caps: fscaps to be written
  2386	 * @flags: flags for setxattr
  2387	 *
  2388	 * Update inode security field after successfully setting fscaps.
  2389	 *
  2390	 */
  2391	void security_inode_post_set_fscaps(struct mnt_idmap *idmap,
  2392					    struct dentry *dentry,
  2393					    const struct vfs_caps *caps, int flags)
  2394	{
  2395		if (unlikely(IS_PRIVATE(d_backing_inode(dentry))))
  2396			return;
  2397		call_void_hook(inode_post_set_fscaps, idmap, dentry, caps, flags);
  2398		evm_inode_post_set_fscaps(idmap, dentry, caps, flags);
  2399	}
  2400	
  2401	/**
  2402	 * security_inode_get_fscaps() - Check if reading fscaps is allowed
  2403	 * @dentry: file
  2404	 *
  2405	 * Check permission before getting fscaps.
  2406	 *
  2407	 * Return: Returns 0 if permission is granted.
  2408	 */
  2409	int security_inode_get_fscaps(struct mnt_idmap *idmap, struct dentry *dentry)
  2410	{
  2411		if (unlikely(IS_PRIVATE(d_backing_inode(dentry))))
  2412			return 0;
  2413		return call_int_hook(inode_get_fscaps, 0, idmap, dentry);
  2414	}
  2415	
  2416	/**
  2417	 * security_inode_remove_fscaps() - Check if removing fscaps is allowed
  2418	 * @idmap: idmap of the mount
  2419	 * @dentry: file
  2420	 *
  2421	 * Check permission before removing fscaps.
  2422	 *
  2423	 * Return: Returns 0 if permission is granted.
  2424	 */
  2425	int security_inode_remove_fscaps(struct mnt_idmap *idmap, struct dentry *dentry)
  2426	{
  2427		int ret;
  2428	
  2429		if (unlikely(IS_PRIVATE(d_backing_inode(dentry))))
  2430			return 0;
  2431		ret = call_int_hook(inode_remove_fscaps, 0, idmap, dentry);
  2432		if (ret)
  2433			return ret;
> 2434		ret = ima_inode_remove_fscaps(dentry);
  2435		if (ret)
  2436			return ret;
  2437		return evm_inode_remove_fscaps(dentry);
  2438	}
  2439	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-03-07  4:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202403071228.6gAA2DMl-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=roberto.sassu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.