From: Heiko Carstens <hca@linux.ibm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] s390/cio: Use while (i--) pattern to clean up
Date: Thu, 7 Mar 2024 14:54:42 +0100 [thread overview]
Message-ID: <20240307135442.33873-B-hca@linux.ibm.com> (raw)
In-Reply-To: <ZeXeBr5z8TrLbuCI@smile.fi.intel.com>
On Mon, Mar 04, 2024 at 04:43:18PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 22, 2024 at 03:45:01PM +0200, Andy Shevchenko wrote:
> > Use more natural while (i--) patter to clean up allocated resources.
>
> Any comments?
It is up to Vineeth and Peter to decide what to do with this.
But in general I'm not a fan of such patches. It depends on what people
prefer, and you can send literally thousands of similar patches where the
code looks "more natural" afterwards.
next prev parent reply other threads:[~2024-03-07 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 13:45 [PATCH v1 1/1] s390/cio: Use while (i--) pattern to clean up Andy Shevchenko
2024-03-04 14:43 ` Andy Shevchenko
2024-03-07 13:54 ` Heiko Carstens [this message]
2024-03-07 13:58 ` Andy Shevchenko
2024-03-13 14:57 ` Vineeth Vijayan
2024-03-13 15:24 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307135442.33873-B-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.