From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E984FC54E4A for ; Thu, 7 Mar 2024 20:18:05 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=j3UVtH/f; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrLG44NkHz3vk7 for ; Fri, 8 Mar 2024 07:18:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=j3UVtH/f; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nvidia.com (client-ip=2a01:111:f403:2414::600; helo=nam11-bn8-obe.outbound.protection.outlook.com; envelope-from=jgg@nvidia.com; receiver=lists.ozlabs.org) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2414::600]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrLFD0b6nz2yk3 for ; Fri, 8 Mar 2024 07:17:17 +1100 (AEDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUeOorKkZ9OFfLTlobVEbbCggrzqkdw4uZPOGMNdjEkfb+TpeXGUQtrtISKJl5+t9fIMb8xo6IyqJDKzqgMl4r8ZJ2HzNrVdcqzcmD/BVLBJpq9ur5YFwzJIYheGP5jxoCly6U9pnxvYkhngaLCEWtszr6TcnI7FzyZhGF9rK+xF31vJuHTdWY1MmxNuzGmIaJCUe0o9xCMD/VwguyBQjV+vDm+cv7qpElUm/KAtrp2KBP4YM9XZmE2WuolxlwZOnEygqTeH6xYuk0BpvU8kOgDeLe5lE19QlMeZDWdSHNPRpkw0vP5a9iAjLb2OoBPcoHMXaQ5nBydrCatpyoU4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yjYLYsWUwR6Os+WUro8W9GHIcP7kmbFChN+9az3aDdY=; b=fLA/gr4qSFjySjO9n4Tim7MvnG3xqqnymm80GGdwvrzeGGZyDSxO061x8tOdebRvjrDzGC3UAmz6mvTZsBjOEKLzMnb2BfvEi9dyc7xgUqKssUuj6VZCBIJfZkAJB6f0z427f9bdP1ohyY5/Jw0/U9ql3iTdg2/v0NgArB91kLG1DMuAkbNrH3YwTiU3rtWHLoHu9SHoj+zVHLFT/zibxxzNK8zlstjEFqsNx0d16MYywapEKVs3g0GQTASi6bsD1fFKBgaylCqXP6A/V9OvfvvxD6o9eovQ1vG3A+kS3ci7eEyOtQM3G7bzKVD96X8cV3ntxbrVNucjl7tFJRh51Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yjYLYsWUwR6Os+WUro8W9GHIcP7kmbFChN+9az3aDdY=; b=j3UVtH/fJzzkCe8JQRPxTEeyU2ZGhp//VEnnGurdy1+9Uipsl8ykUbo9JaYTle9W8eD8VQmhHQW5QVTTdxNyFFonEqKqbOzyOTPo0CEXchzC+R4B5N+rwHcaaQgjq8Qqb2om/uj9yySTtN87yU0mHh1BB55kr0xc+u72XJsBFG2ZUac3W7ChjE+3jN5/LfUf0PP/CaNKyiCmjo7XtF1G4FEpog8pp8P/jcPew+pwRISPiZu0bNsQI2Nj11Sn5+X2r2/5eUgg1J9PYJtdRCUIHrnrAz2HaGO877JCm/CxGFd1tBOO6Xk8u0l6tznIQ63byvHpNf6y9/ivnfAjVb5Mkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by MW3PR12MB4396.namprd12.prod.outlook.com (2603:10b6:303:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Thu, 7 Mar 2024 20:16:57 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7362.019; Thu, 7 Mar 2024 20:16:57 +0000 Date: Thu, 7 Mar 2024 16:16:55 -0400 From: Jason Gunthorpe To: peterx@redhat.com Subject: Re: [PATCH RFC 04/13] mm/x86: Change pXd_huge() behavior to exclude swap entries Message-ID: <20240307201655.GF9179@nvidia.com> References: <20240306104147.193052-1-peterx@redhat.com> <20240306104147.193052-5-peterx@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240306104147.193052-5-peterx@redhat.com> X-ClientProxiedBy: SN4PR0501CA0069.namprd05.prod.outlook.com (2603:10b6:803:41::46) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|MW3PR12MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f5be981-b8a3-4f7f-016a-08dc3ee38a08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NJ8HhtV0wbDGRgbqsFpHWrL0TsNjgen6EOcqvzAwj1i+rknyc4iW+GjuROKcYGZ2InjINyjuJFn6arn9/u/outX9LkV4Kkp+h2wFho6BWXqozGFHnpomOiiLzKh0+K2OwTpJE9/l2lshCFytUlUEANeckfu2Abwhj/F9D9P+VqUYXVArGYXYbp6NuoVAfgAWWrh3hCNTrADdizHWo9ZGUR/K5ZSeef8I8/y6Z1l2fOKj4IKyaPisYNaoSOt5zB2bPIayMRpNx7MKbCDLOnoqbBTJCzambgx+XD46uLMHvY4P/3PdQmbxC0Im7XaP6XPxdPuN9ACFuVoLlZMWlbqLELqic8+19OtI7IF74/MhFSje/7Ea7E3TvwF62zjXWVNjiYcpDxVgUVMGblec1rdUZZtqK55qEL9d9htu/jZR7X+6UbSQpVTyMqZKp+51NCqR3+6CuIEzvZeTPK7deTE7fUyxcvf26NvKZzmiKYEvL7NRA9vqRU8m/M7/+b16kRuVGFySGfJlzh9mhbw4kJleM80czkHWI3rl3ne9QVA7+nEl+WZ8Y1eBEe7yQHHKelCjaLENOeSyF5XINxM3I3PpO+BPv+qBTy2oJ9bjYEAPw3mETRySDUoTJ5eyq4qFDsvOH64a+P6IrCGSj4CoeYtHTORv/pajhfEeSkblmzS8jvs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0pwSFhuZklCNENRWS9mVVNlOUFOVDBPdnFyOEJkYVV5cTJlL0VmNjVBZlpj?= =?utf-8?B?UWZDMVY3SDdWZnptNFlrYjJoajVFNC9JSVFhdDBPZm5ZNE1ITjVtNzlxaS9O?= =?utf-8?B?cVAzcU5OUFZXYis0Y1NnZm1wbFJqMHI3S1VYdktCMDhUaXhLbSthc0tiTHdD?= =?utf-8?B?RkdjUzk3MTM1SFBzekxVdVJjZ3A5WjhkS3Fxa0N6eWo0emtoT1gvMG5yMG5J?= =?utf-8?B?cWlvdnFPZXFLTytnNTAwOHYxUzFjMGlIRGxGY0RtdThTR2JsQlNqQytwMEtr?= =?utf-8?B?dWpSOGVicWxkdEdyRXpad3NaU2I5Zktvcjd5QWJnSW5PUkR1aU5RdGtNNVh5?= =?utf-8?B?elRCVVdnQ0Y5b2cxZURwSGNPZi91V2NCNjY3N3RUMnAyRnpVZXYzb1cySjds?= =?utf-8?B?Rm91Vkl0YXdZbHFYbmoranAwWWM3TEF5a3hHOEkvMExCSDRrNmlnOHhna05m?= =?utf-8?B?UEhVdVd6Vzc1UXRQdmdNMTJZaGptdlpFeEs2Q3ZJNjB2Wlh2S0IvZjNxSUFR?= =?utf-8?B?dCtGd1VrT0RFREFMYTI4eTZIbjM2N2twUXFYWjNwMmw5U1cyeXNrY0xya2xY?= =?utf-8?B?elM3SDVTWUxDUk5iZG1JL1lkZ2loMzlkNmZVaGhIcXY4QUJicXpWTlRKYnl5?= =?utf-8?B?d2QxQjRDbDArZUcwK0RpM1RCa21aaCswZGdPRldLVXVtaGVRdDdmSWxGTm5K?= =?utf-8?B?SVNJQk9CYkNMT2pCUXIzdXo0cWI2cERURUp6VXVZS1NsWVVWWE1xTEpybGR6?= =?utf-8?B?aTdBU0pLK1lMbkxReTh6U2F6SUpONkFNRXUyZEFyNytFS0grNXF0MHlOT1pL?= =?utf-8?B?Vi8zclUwMG93MXF0ZDlsRk9JYUVhNXFhRGp6UnJTOGk1Qkppb0tHZUllRVR6?= =?utf-8?B?RmFRR1B3WStuMDJHZUdZZnNBN25xSzJKZEVmOW9oeVd1aW92ejRVWXErZDJL?= =?utf-8?B?MnVpN0pLdWU1eVBTT1ROQjZBOFM5TysxcTB3TXM0WU1iemxIRlcrdXlLTWZu?= =?utf-8?B?WmdSZlZScHo4OXdaR0kvM0lkZzFvTXhteWhkaDhKRTJJK1N4eTNGUDZqNmxM?= =?utf-8?B?clJkQ3NYbHJlblFWSFd6V205UWhqVm53VUZTTzZvaWxpQndCbVZydXNnQkxr?= =?utf-8?B?amF3Mkhlcmc3bGNIbkJnQjRIUVRQWFJlVWh4NVBNUUlBYzJUcXJ6dWJiMWVD?= =?utf-8?B?MkdwaXR2UHhWU2tDa1dMWTEvdWk4S3l1OUIwVFYzRElmOUFabHFmYjZ5czBk?= =?utf-8?B?MEZMS0F6RTg1Rk02SUNYdzh4enBFUWF6NGxFZjZaVU9nVjQrc2NxUTRYQi9h?= =?utf-8?B?S04xYkNZaDdQQ1dpU3pZQ3U0WlhQM0NWUHk3cjM4SGUvUXlGczVKVzM3WUFC?= =?utf-8?B?Mm1BcStNNW9YNVhXTld6OWdlVzlWN1RIdnFwZ3RoNFhLQUtXYkFRcHJTQWo2?= =?utf-8?B?TmMybU5xaWdwdjErUmI5S3FRRmphZjJUbVpNUXRyM01vU2pjUEtqR003YmxL?= =?utf-8?B?NEIwNGdtallXWWtXN0M5N3ZMbTVCMjdhSTlmMFJZK3hQWWV0RWdpeUZJbW5G?= =?utf-8?B?UnF5TW9KVExINFcwMHhsYWVtOE82VHFoajVGRW5DV1UxeExlMURYQ3UvY2tV?= =?utf-8?B?ZDJXdlpXektTeUhVTlpObC9kZ0JLOGZzZkdWTXZEUmx5K1JnQUU1TDZEd0pI?= =?utf-8?B?WXNUNXZJalhBN21yUjVodnhTdUlVb0tFMk1HN0lqS1pZUUtBSUUxaHFoOGF5?= =?utf-8?B?THhyYUl5b1NEWkYrRW1wZytRRVAvWFNYczJ2ZVdseWM2SGg5YnBnNGVMQ3NI?= =?utf-8?B?cDJlSzRaOCtVSk9MNW9uMmhpbUpsR0ZGeE1MajAyU3RFa0NnVHYrWGowTmtl?= =?utf-8?B?aVFoMk1yb2wwaVRUSG5NOFJsNFNCREdTMnFzeWdKZWJ1bTBhVlVGeURJYVhR?= =?utf-8?B?a21NVkE0Q3R3RHhydmp6dXcxeGQyMko0YnFpdjZoTVprRVIvc3N5YnFYWXk4?= =?utf-8?B?d3hTY1hYenc1ekFnU29UbWpEdVdxbUJFcUNqSVVncHNpSklVemFpTnpUVFZB?= =?utf-8?B?eUdXV3ZTblkwU2F6T1RSNUwwb1JPcjd0dTA0MGthM3pyQ1ZCQnRKazFwNUJ4?= =?utf-8?Q?w/zQ=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5be981-b8a3-4f7f-016a-08dc3ee38a08 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 20:16:57.5340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z5+PuvTjZrLgdSDdJIvRa5G12f22nrcc9yreOm+GTWyDuyBejV1Cd0ZX5bcGF6GP X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4396 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, Dave Hansen , Muchun Song , Naoya Horiguchi , linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, Ingo Molnar , Borislav Petkov , sparclinux@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Mar 06, 2024 at 06:41:38PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > This patch partly reverts below commits: > > 3a194f3f8ad0 ("mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present pud entry") > cbef8478bee5 ("mm/hugetlb: pmd_huge() returns true for non-present hugepage") > > Right now, pXd_huge() definition across kernel is unclear. We have two > groups that think differently on swap entries: > > - x86/sparc: Allow pXd_huge() to accept swap entries > - all the rest: Doesn't allow pXd_huge() to accept swap entries > > This is so confusing. Since the sparc helpers seem to be added in 2016, > which is after x86's (2015), so sparc could have followed a trend. x86 > proposed such swap handling in 2015 to resolve hugetlb swap entries hit in > GUP, but now GUP guards swap entries with !pXd_present() in all layers so > we should be safe. > > We should define this API properly, one way or another, rather than keep > them defined differently across archs. > > Gut feeling tells me that pXd_huge() shouldn't include swap entries, and it > turns out that I am not the only one thinking so, the question was raised > when the current pmd_huge() for x86 was proposed by Ville Syrjälä: > > https://lore.kernel.org/all/Y2WQ7I4LXh8iUIRd@intel.com/ > > I might also be missing something obvious, but why is it even necessary > to treat PRESENT==0+PSE==0 as a huge entry? > > It is also questioned when Jason Gunthorpe reviewed the other patchset on > swap entry handlings: > > https://lore.kernel.org/all/20240221125753.GQ13330@nvidia.com/ > > Revert its meaning back to original. It shouldn't have any functional > change as we should be ready with guards on !pXd_present() explicitly > everywhere. > > Note that I also dropped the "#if CONFIG_PGTABLE_LEVELS > 2", it was there > probably because it was breaking things when 3a194f3f8ad0 was proposed, > according to the report here: > > https://lore.kernel.org/all/Y2LYXItKQyaJTv8j@intel.com/ > > Now we shouldn't need that. > > Instead of reverting to _PAGE_PSE raw check, leverage pXd_leaf(). > > Cc: Naoya Horiguchi > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Signed-off-by: Peter Xu > --- > arch/x86/mm/hugetlbpage.c | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) I think this is the right thing to do, callers should be more directly sensitive to swap entries not back into it indirectly from a helper like this. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08A4713666E; Thu, 7 Mar 2024 20:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.40 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709842624; cv=fail; b=uPVZypbzHtxPzkc8ABeCmB7AX9fR/YRRw2Md3qdc8py1xmsnc8aFoB+suzc4sGoGB6BFojDrOCHCx56xJ1NnUeIUUU1YyGz/UcpNekohC5EMUUfU/Hxwcj6y4U7mvpy16Tj7GwtcJGLAcqYg/XQkbxowHklZDdI3ggvvn2eK6Lk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709842624; c=relaxed/simple; bh=LUjg9QL6Ky/zh7XbnbZ/8kwx/sJCmFMTArh2aK3cu7o=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=lrsSQmpxLAOoEg+JhbMmo3nzJyJD6aExbWBffuzHfP85Tk17E0FbJ5/BxcG4qaFctGBIjWW/b/9AL8nAYZn1U9pByVuc9yTIYABDwYsGTi4811f3YOqBqrS/2DAUj3KjFqJeq8h+slUc+zLA/wBSGjae7UuhkDxAM6XBWasoCCI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=j3UVtH/f; arc=fail smtp.client-ip=40.107.236.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="j3UVtH/f" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUeOorKkZ9OFfLTlobVEbbCggrzqkdw4uZPOGMNdjEkfb+TpeXGUQtrtISKJl5+t9fIMb8xo6IyqJDKzqgMl4r8ZJ2HzNrVdcqzcmD/BVLBJpq9ur5YFwzJIYheGP5jxoCly6U9pnxvYkhngaLCEWtszr6TcnI7FzyZhGF9rK+xF31vJuHTdWY1MmxNuzGmIaJCUe0o9xCMD/VwguyBQjV+vDm+cv7qpElUm/KAtrp2KBP4YM9XZmE2WuolxlwZOnEygqTeH6xYuk0BpvU8kOgDeLe5lE19QlMeZDWdSHNPRpkw0vP5a9iAjLb2OoBPcoHMXaQ5nBydrCatpyoU4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yjYLYsWUwR6Os+WUro8W9GHIcP7kmbFChN+9az3aDdY=; b=fLA/gr4qSFjySjO9n4Tim7MvnG3xqqnymm80GGdwvrzeGGZyDSxO061x8tOdebRvjrDzGC3UAmz6mvTZsBjOEKLzMnb2BfvEi9dyc7xgUqKssUuj6VZCBIJfZkAJB6f0z427f9bdP1ohyY5/Jw0/U9ql3iTdg2/v0NgArB91kLG1DMuAkbNrH3YwTiU3rtWHLoHu9SHoj+zVHLFT/zibxxzNK8zlstjEFqsNx0d16MYywapEKVs3g0GQTASi6bsD1fFKBgaylCqXP6A/V9OvfvvxD6o9eovQ1vG3A+kS3ci7eEyOtQM3G7bzKVD96X8cV3ntxbrVNucjl7tFJRh51Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yjYLYsWUwR6Os+WUro8W9GHIcP7kmbFChN+9az3aDdY=; b=j3UVtH/fJzzkCe8JQRPxTEeyU2ZGhp//VEnnGurdy1+9Uipsl8ykUbo9JaYTle9W8eD8VQmhHQW5QVTTdxNyFFonEqKqbOzyOTPo0CEXchzC+R4B5N+rwHcaaQgjq8Qqb2om/uj9yySTtN87yU0mHh1BB55kr0xc+u72XJsBFG2ZUac3W7ChjE+3jN5/LfUf0PP/CaNKyiCmjo7XtF1G4FEpog8pp8P/jcPew+pwRISPiZu0bNsQI2Nj11Sn5+X2r2/5eUgg1J9PYJtdRCUIHrnrAz2HaGO877JCm/CxGFd1tBOO6Xk8u0l6tznIQ63byvHpNf6y9/ivnfAjVb5Mkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by MW3PR12MB4396.namprd12.prod.outlook.com (2603:10b6:303:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Thu, 7 Mar 2024 20:16:57 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7362.019; Thu, 7 Mar 2024 20:16:57 +0000 Date: Thu, 7 Mar 2024 16:16:55 -0400 From: Jason Gunthorpe To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Muchun Song , Matthew Wilcox , Mike Rapoport , Christophe Leroy , x86@kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Naoya Horiguchi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH RFC 04/13] mm/x86: Change pXd_huge() behavior to exclude swap entries Message-ID: <20240307201655.GF9179@nvidia.com> References: <20240306104147.193052-1-peterx@redhat.com> <20240306104147.193052-5-peterx@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240306104147.193052-5-peterx@redhat.com> X-ClientProxiedBy: SN4PR0501CA0069.namprd05.prod.outlook.com (2603:10b6:803:41::46) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|MW3PR12MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f5be981-b8a3-4f7f-016a-08dc3ee38a08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NJ8HhtV0wbDGRgbqsFpHWrL0TsNjgen6EOcqvzAwj1i+rknyc4iW+GjuROKcYGZ2InjINyjuJFn6arn9/u/outX9LkV4Kkp+h2wFho6BWXqozGFHnpomOiiLzKh0+K2OwTpJE9/l2lshCFytUlUEANeckfu2Abwhj/F9D9P+VqUYXVArGYXYbp6NuoVAfgAWWrh3hCNTrADdizHWo9ZGUR/K5ZSeef8I8/y6Z1l2fOKj4IKyaPisYNaoSOt5zB2bPIayMRpNx7MKbCDLOnoqbBTJCzambgx+XD46uLMHvY4P/3PdQmbxC0Im7XaP6XPxdPuN9ACFuVoLlZMWlbqLELqic8+19OtI7IF74/MhFSje/7Ea7E3TvwF62zjXWVNjiYcpDxVgUVMGblec1rdUZZtqK55qEL9d9htu/jZR7X+6UbSQpVTyMqZKp+51NCqR3+6CuIEzvZeTPK7deTE7fUyxcvf26NvKZzmiKYEvL7NRA9vqRU8m/M7/+b16kRuVGFySGfJlzh9mhbw4kJleM80czkHWI3rl3ne9QVA7+nEl+WZ8Y1eBEe7yQHHKelCjaLENOeSyF5XINxM3I3PpO+BPv+qBTy2oJ9bjYEAPw3mETRySDUoTJ5eyq4qFDsvOH64a+P6IrCGSj4CoeYtHTORv/pajhfEeSkblmzS8jvs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0pwSFhuZklCNENRWS9mVVNlOUFOVDBPdnFyOEJkYVV5cTJlL0VmNjVBZlpj?= =?utf-8?B?UWZDMVY3SDdWZnptNFlrYjJoajVFNC9JSVFhdDBPZm5ZNE1ITjVtNzlxaS9O?= =?utf-8?B?cVAzcU5OUFZXYis0Y1NnZm1wbFJqMHI3S1VYdktCMDhUaXhLbSthc0tiTHdD?= =?utf-8?B?RkdjUzk3MTM1SFBzekxVdVJjZ3A5WjhkS3Fxa0N6eWo0emtoT1gvMG5yMG5J?= =?utf-8?B?cWlvdnFPZXFLTytnNTAwOHYxUzFjMGlIRGxGY0RtdThTR2JsQlNqQytwMEtr?= =?utf-8?B?dWpSOGVicWxkdEdyRXpad3NaU2I5Zktvcjd5QWJnSW5PUkR1aU5RdGtNNVh5?= =?utf-8?B?elRCVVdnQ0Y5b2cxZURwSGNPZi91V2NCNjY3N3RUMnAyRnpVZXYzb1cySjds?= =?utf-8?B?Rm91Vkl0YXdZbHFYbmoranAwWWM3TEF5a3hHOEkvMExCSDRrNmlnOHhna05m?= =?utf-8?B?UEhVdVd6Vzc1UXRQdmdNMTJZaGptdlpFeEs2Q3ZJNjB2Wlh2S0IvZjNxSUFR?= =?utf-8?B?dCtGd1VrT0RFREFMYTI4eTZIbjM2N2twUXFYWjNwMmw5U1cyeXNrY0xya2xY?= =?utf-8?B?elM3SDVTWUxDUk5iZG1JL1lkZ2loMzlkNmZVaGhIcXY4QUJicXpWTlRKYnl5?= =?utf-8?B?d2QxQjRDbDArZUcwK0RpM1RCa21aaCswZGdPRldLVXVtaGVRdDdmSWxGTm5K?= =?utf-8?B?SVNJQk9CYkNMT2pCUXIzdXo0cWI2cERURUp6VXVZS1NsWVVWWE1xTEpybGR6?= =?utf-8?B?aTdBU0pLK1lMbkxReTh6U2F6SUpONkFNRXUyZEFyNytFS0grNXF0MHlOT1pL?= =?utf-8?B?Vi8zclUwMG93MXF0ZDlsRk9JYUVhNXFhRGp6UnJTOGk1Qkppb0tHZUllRVR6?= =?utf-8?B?RmFRR1B3WStuMDJHZUdZZnNBN25xSzJKZEVmOW9oeVd1aW92ejRVWXErZDJL?= =?utf-8?B?MnVpN0pLdWU1eVBTT1ROQjZBOFM5TysxcTB3TXM0WU1iemxIRlcrdXlLTWZu?= =?utf-8?B?WmdSZlZScHo4OXdaR0kvM0lkZzFvTXhteWhkaDhKRTJJK1N4eTNGUDZqNmxM?= =?utf-8?B?clJkQ3NYbHJlblFWSFd6V205UWhqVm53VUZTTzZvaWxpQndCbVZydXNnQkxr?= =?utf-8?B?amF3Mkhlcmc3bGNIbkJnQjRIUVRQWFJlVWh4NVBNUUlBYzJUcXJ6dWJiMWVD?= =?utf-8?B?MkdwaXR2UHhWU2tDa1dMWTEvdWk4S3l1OUIwVFYzRElmOUFabHFmYjZ5czBk?= =?utf-8?B?MEZMS0F6RTg1Rk02SUNYdzh4enBFUWF6NGxFZjZaVU9nVjQrc2NxUTRYQi9h?= =?utf-8?B?S04xYkNZaDdQQ1dpU3pZQ3U0WlhQM0NWUHk3cjM4SGUvUXlGczVKVzM3WUFC?= =?utf-8?B?Mm1BcStNNW9YNVhXTld6OWdlVzlWN1RIdnFwZ3RoNFhLQUtXYkFRcHJTQWo2?= =?utf-8?B?TmMybU5xaWdwdjErUmI5S3FRRmphZjJUbVpNUXRyM01vU2pjUEtqR003YmxL?= =?utf-8?B?NEIwNGdtallXWWtXN0M5N3ZMbTVCMjdhSTlmMFJZK3hQWWV0RWdpeUZJbW5G?= =?utf-8?B?UnF5TW9KVExINFcwMHhsYWVtOE82VHFoajVGRW5DV1UxeExlMURYQ3UvY2tV?= =?utf-8?B?ZDJXdlpXektTeUhVTlpObC9kZ0JLOGZzZkdWTXZEUmx5K1JnQUU1TDZEd0pI?= =?utf-8?B?WXNUNXZJalhBN21yUjVodnhTdUlVb0tFMk1HN0lqS1pZUUtBSUUxaHFoOGF5?= =?utf-8?B?THhyYUl5b1NEWkYrRW1wZytRRVAvWFNYczJ2ZVdseWM2SGg5YnBnNGVMQ3NI?= =?utf-8?B?cDJlSzRaOCtVSk9MNW9uMmhpbUpsR0ZGeE1MajAyU3RFa0NnVHYrWGowTmtl?= =?utf-8?B?aVFoMk1yb2wwaVRUSG5NOFJsNFNCREdTMnFzeWdKZWJ1bTBhVlVGeURJYVhR?= =?utf-8?B?a21NVkE0Q3R3RHhydmp6dXcxeGQyMko0YnFpdjZoTVprRVIvc3N5YnFYWXk4?= =?utf-8?B?d3hTY1hYenc1ekFnU29UbWpEdVdxbUJFcUNqSVVncHNpSklVemFpTnpUVFZB?= =?utf-8?B?eUdXV3ZTblkwU2F6T1RSNUwwb1JPcjd0dTA0MGthM3pyQ1ZCQnRKazFwNUJ4?= =?utf-8?Q?w/zQ=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5be981-b8a3-4f7f-016a-08dc3ee38a08 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 20:16:57.5340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z5+PuvTjZrLgdSDdJIvRa5G12f22nrcc9yreOm+GTWyDuyBejV1Cd0ZX5bcGF6GP X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4396 On Wed, Mar 06, 2024 at 06:41:38PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > This patch partly reverts below commits: > > 3a194f3f8ad0 ("mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present pud entry") > cbef8478bee5 ("mm/hugetlb: pmd_huge() returns true for non-present hugepage") > > Right now, pXd_huge() definition across kernel is unclear. We have two > groups that think differently on swap entries: > > - x86/sparc: Allow pXd_huge() to accept swap entries > - all the rest: Doesn't allow pXd_huge() to accept swap entries > > This is so confusing. Since the sparc helpers seem to be added in 2016, > which is after x86's (2015), so sparc could have followed a trend. x86 > proposed such swap handling in 2015 to resolve hugetlb swap entries hit in > GUP, but now GUP guards swap entries with !pXd_present() in all layers so > we should be safe. > > We should define this API properly, one way or another, rather than keep > them defined differently across archs. > > Gut feeling tells me that pXd_huge() shouldn't include swap entries, and it > turns out that I am not the only one thinking so, the question was raised > when the current pmd_huge() for x86 was proposed by Ville Syrjälä: > > https://lore.kernel.org/all/Y2WQ7I4LXh8iUIRd@intel.com/ > > I might also be missing something obvious, but why is it even necessary > to treat PRESENT==0+PSE==0 as a huge entry? > > It is also questioned when Jason Gunthorpe reviewed the other patchset on > swap entry handlings: > > https://lore.kernel.org/all/20240221125753.GQ13330@nvidia.com/ > > Revert its meaning back to original. It shouldn't have any functional > change as we should be ready with guards on !pXd_present() explicitly > everywhere. > > Note that I also dropped the "#if CONFIG_PGTABLE_LEVELS > 2", it was there > probably because it was breaking things when 3a194f3f8ad0 was proposed, > according to the report here: > > https://lore.kernel.org/all/Y2LYXItKQyaJTv8j@intel.com/ > > Now we shouldn't need that. > > Instead of reverting to _PAGE_PSE raw check, leverage pXd_leaf(). > > Cc: Naoya Horiguchi > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Signed-off-by: Peter Xu > --- > arch/x86/mm/hugetlbpage.c | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) I think this is the right thing to do, callers should be more directly sensitive to swap entries not back into it indirectly from a helper like this. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F31FC54E4A for ; Thu, 7 Mar 2024 20:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CtrIRMbKk/V583Kc6g3jr8JtsgTFFKdCmt1XRs/2EL0=; b=uqBkFmgNYO5wDL YpA4gQtGzfM7MIUoqvk73Re/IY4ZF32R9MKaqmDgPZ5D1CaxW8BcSbWwJfoVnKiJMTyPvYk7d5LKx e27gu5KHI3YWEWmQLb3CK0wFPihkKrbqNhUxOTCMvsvedVrJsLuFG8vhzv6hcopZw4YvEHDl4LO1M QoLcW8H+mZc0o7+g+nBYEUV46NYoDgZv0D/iTbmPluWXSrtrs+TKqzuQmY5sHNSwL1NLByxgFqjNT QuNIiFFTlhRpktBug086g0wIIOQWOX521Me2uonnYrRBpEGpDiRTEGMtfrGhyP2RY/H12yx4YDyYS n18EoUqHwC1tguwfzcuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riKAv-00000006FVA-2rLN; Thu, 07 Mar 2024 20:17:09 +0000 Received: from mail-bn8nam11on20601.outbound.protection.outlook.com ([2a01:111:f403:2414::601] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riKAr-00000006FSn-3j9Y for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2024 20:17:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUeOorKkZ9OFfLTlobVEbbCggrzqkdw4uZPOGMNdjEkfb+TpeXGUQtrtISKJl5+t9fIMb8xo6IyqJDKzqgMl4r8ZJ2HzNrVdcqzcmD/BVLBJpq9ur5YFwzJIYheGP5jxoCly6U9pnxvYkhngaLCEWtszr6TcnI7FzyZhGF9rK+xF31vJuHTdWY1MmxNuzGmIaJCUe0o9xCMD/VwguyBQjV+vDm+cv7qpElUm/KAtrp2KBP4YM9XZmE2WuolxlwZOnEygqTeH6xYuk0BpvU8kOgDeLe5lE19QlMeZDWdSHNPRpkw0vP5a9iAjLb2OoBPcoHMXaQ5nBydrCatpyoU4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yjYLYsWUwR6Os+WUro8W9GHIcP7kmbFChN+9az3aDdY=; b=fLA/gr4qSFjySjO9n4Tim7MvnG3xqqnymm80GGdwvrzeGGZyDSxO061x8tOdebRvjrDzGC3UAmz6mvTZsBjOEKLzMnb2BfvEi9dyc7xgUqKssUuj6VZCBIJfZkAJB6f0z427f9bdP1ohyY5/Jw0/U9ql3iTdg2/v0NgArB91kLG1DMuAkbNrH3YwTiU3rtWHLoHu9SHoj+zVHLFT/zibxxzNK8zlstjEFqsNx0d16MYywapEKVs3g0GQTASi6bsD1fFKBgaylCqXP6A/V9OvfvvxD6o9eovQ1vG3A+kS3ci7eEyOtQM3G7bzKVD96X8cV3ntxbrVNucjl7tFJRh51Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yjYLYsWUwR6Os+WUro8W9GHIcP7kmbFChN+9az3aDdY=; b=j3UVtH/fJzzkCe8JQRPxTEeyU2ZGhp//VEnnGurdy1+9Uipsl8ykUbo9JaYTle9W8eD8VQmhHQW5QVTTdxNyFFonEqKqbOzyOTPo0CEXchzC+R4B5N+rwHcaaQgjq8Qqb2om/uj9yySTtN87yU0mHh1BB55kr0xc+u72XJsBFG2ZUac3W7ChjE+3jN5/LfUf0PP/CaNKyiCmjo7XtF1G4FEpog8pp8P/jcPew+pwRISPiZu0bNsQI2Nj11Sn5+X2r2/5eUgg1J9PYJtdRCUIHrnrAz2HaGO877JCm/CxGFd1tBOO6Xk8u0l6tznIQ63byvHpNf6y9/ivnfAjVb5Mkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by MW3PR12MB4396.namprd12.prod.outlook.com (2603:10b6:303:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Thu, 7 Mar 2024 20:16:57 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7362.019; Thu, 7 Mar 2024 20:16:57 +0000 Date: Thu, 7 Mar 2024 16:16:55 -0400 From: Jason Gunthorpe To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Muchun Song , Matthew Wilcox , Mike Rapoport , Christophe Leroy , x86@kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Naoya Horiguchi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH RFC 04/13] mm/x86: Change pXd_huge() behavior to exclude swap entries Message-ID: <20240307201655.GF9179@nvidia.com> References: <20240306104147.193052-1-peterx@redhat.com> <20240306104147.193052-5-peterx@redhat.com> Content-Disposition: inline In-Reply-To: <20240306104147.193052-5-peterx@redhat.com> X-ClientProxiedBy: SN4PR0501CA0069.namprd05.prod.outlook.com (2603:10b6:803:41::46) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|MW3PR12MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f5be981-b8a3-4f7f-016a-08dc3ee38a08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NJ8HhtV0wbDGRgbqsFpHWrL0TsNjgen6EOcqvzAwj1i+rknyc4iW+GjuROKcYGZ2InjINyjuJFn6arn9/u/outX9LkV4Kkp+h2wFho6BWXqozGFHnpomOiiLzKh0+K2OwTpJE9/l2lshCFytUlUEANeckfu2Abwhj/F9D9P+VqUYXVArGYXYbp6NuoVAfgAWWrh3hCNTrADdizHWo9ZGUR/K5ZSeef8I8/y6Z1l2fOKj4IKyaPisYNaoSOt5zB2bPIayMRpNx7MKbCDLOnoqbBTJCzambgx+XD46uLMHvY4P/3PdQmbxC0Im7XaP6XPxdPuN9ACFuVoLlZMWlbqLELqic8+19OtI7IF74/MhFSje/7Ea7E3TvwF62zjXWVNjiYcpDxVgUVMGblec1rdUZZtqK55qEL9d9htu/jZR7X+6UbSQpVTyMqZKp+51NCqR3+6CuIEzvZeTPK7deTE7fUyxcvf26NvKZzmiKYEvL7NRA9vqRU8m/M7/+b16kRuVGFySGfJlzh9mhbw4kJleM80czkHWI3rl3ne9QVA7+nEl+WZ8Y1eBEe7yQHHKelCjaLENOeSyF5XINxM3I3PpO+BPv+qBTy2oJ9bjYEAPw3mETRySDUoTJ5eyq4qFDsvOH64a+P6IrCGSj4CoeYtHTORv/pajhfEeSkblmzS8jvs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0pwSFhuZklCNENRWS9mVVNlOUFOVDBPdnFyOEJkYVV5cTJlL0VmNjVBZlpj?= =?utf-8?B?UWZDMVY3SDdWZnptNFlrYjJoajVFNC9JSVFhdDBPZm5ZNE1ITjVtNzlxaS9O?= =?utf-8?B?cVAzcU5OUFZXYis0Y1NnZm1wbFJqMHI3S1VYdktCMDhUaXhLbSthc0tiTHdD?= =?utf-8?B?RkdjUzk3MTM1SFBzekxVdVJjZ3A5WjhkS3Fxa0N6eWo0emtoT1gvMG5yMG5J?= =?utf-8?B?cWlvdnFPZXFLTytnNTAwOHYxUzFjMGlIRGxGY0RtdThTR2JsQlNqQytwMEtr?= =?utf-8?B?dWpSOGVicWxkdEdyRXpad3NaU2I5Zktvcjd5QWJnSW5PUkR1aU5RdGtNNVh5?= =?utf-8?B?elRCVVdnQ0Y5b2cxZURwSGNPZi91V2NCNjY3N3RUMnAyRnpVZXYzb1cySjds?= =?utf-8?B?Rm91Vkl0YXdZbHFYbmoranAwWWM3TEF5a3hHOEkvMExCSDRrNmlnOHhna05m?= =?utf-8?B?UEhVdVd6Vzc1UXRQdmdNMTJZaGptdlpFeEs2Q3ZJNjB2Wlh2S0IvZjNxSUFR?= =?utf-8?B?dCtGd1VrT0RFREFMYTI4eTZIbjM2N2twUXFYWjNwMmw5U1cyeXNrY0xya2xY?= =?utf-8?B?elM3SDVTWUxDUk5iZG1JL1lkZ2loMzlkNmZVaGhIcXY4QUJicXpWTlRKYnl5?= =?utf-8?B?d2QxQjRDbDArZUcwK0RpM1RCa21aaCswZGdPRldLVXVtaGVRdDdmSWxGTm5K?= =?utf-8?B?SVNJQk9CYkNMT2pCUXIzdXo0cWI2cERURUp6VXVZS1NsWVVWWE1xTEpybGR6?= =?utf-8?B?aTdBU0pLK1lMbkxReTh6U2F6SUpONkFNRXUyZEFyNytFS0grNXF0MHlOT1pL?= =?utf-8?B?Vi8zclUwMG93MXF0ZDlsRk9JYUVhNXFhRGp6UnJTOGk1Qkppb0tHZUllRVR6?= =?utf-8?B?RmFRR1B3WStuMDJHZUdZZnNBN25xSzJKZEVmOW9oeVd1aW92ejRVWXErZDJL?= =?utf-8?B?MnVpN0pLdWU1eVBTT1ROQjZBOFM5TysxcTB3TXM0WU1iemxIRlcrdXlLTWZu?= =?utf-8?B?WmdSZlZScHo4OXdaR0kvM0lkZzFvTXhteWhkaDhKRTJJK1N4eTNGUDZqNmxM?= =?utf-8?B?clJkQ3NYbHJlblFWSFd6V205UWhqVm53VUZTTzZvaWxpQndCbVZydXNnQkxr?= =?utf-8?B?amF3Mkhlcmc3bGNIbkJnQjRIUVRQWFJlVWh4NVBNUUlBYzJUcXJ6dWJiMWVD?= =?utf-8?B?MkdwaXR2UHhWU2tDa1dMWTEvdWk4S3l1OUIwVFYzRElmOUFabHFmYjZ5czBk?= =?utf-8?B?MEZMS0F6RTg1Rk02SUNYdzh4enBFUWF6NGxFZjZaVU9nVjQrc2NxUTRYQi9h?= =?utf-8?B?S04xYkNZaDdQQ1dpU3pZQ3U0WlhQM0NWUHk3cjM4SGUvUXlGczVKVzM3WUFC?= =?utf-8?B?Mm1BcStNNW9YNVhXTld6OWdlVzlWN1RIdnFwZ3RoNFhLQUtXYkFRcHJTQWo2?= =?utf-8?B?TmMybU5xaWdwdjErUmI5S3FRRmphZjJUbVpNUXRyM01vU2pjUEtqR003YmxL?= =?utf-8?B?NEIwNGdtallXWWtXN0M5N3ZMbTVCMjdhSTlmMFJZK3hQWWV0RWdpeUZJbW5G?= =?utf-8?B?UnF5TW9KVExINFcwMHhsYWVtOE82VHFoajVGRW5DV1UxeExlMURYQ3UvY2tV?= =?utf-8?B?ZDJXdlpXektTeUhVTlpObC9kZ0JLOGZzZkdWTXZEUmx5K1JnQUU1TDZEd0pI?= =?utf-8?B?WXNUNXZJalhBN21yUjVodnhTdUlVb0tFMk1HN0lqS1pZUUtBSUUxaHFoOGF5?= =?utf-8?B?THhyYUl5b1NEWkYrRW1wZytRRVAvWFNYczJ2ZVdseWM2SGg5YnBnNGVMQ3NI?= =?utf-8?B?cDJlSzRaOCtVSk9MNW9uMmhpbUpsR0ZGeE1MajAyU3RFa0NnVHYrWGowTmtl?= =?utf-8?B?aVFoMk1yb2wwaVRUSG5NOFJsNFNCREdTMnFzeWdKZWJ1bTBhVlVGeURJYVhR?= =?utf-8?B?a21NVkE0Q3R3RHhydmp6dXcxeGQyMko0YnFpdjZoTVprRVIvc3N5YnFYWXk4?= =?utf-8?B?d3hTY1hYenc1ekFnU29UbWpEdVdxbUJFcUNqSVVncHNpSklVemFpTnpUVFZB?= =?utf-8?B?eUdXV3ZTblkwU2F6T1RSNUwwb1JPcjd0dTA0MGthM3pyQ1ZCQnRKazFwNUJ4?= =?utf-8?Q?w/zQ=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5be981-b8a3-4f7f-016a-08dc3ee38a08 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 20:16:57.5340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z5+PuvTjZrLgdSDdJIvRa5G12f22nrcc9yreOm+GTWyDuyBejV1Cd0ZX5bcGF6GP X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4396 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_121705_968822_69D407BE X-CRM114-Status: GOOD ( 24.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMDYsIDIwMjQgYXQgMDY6NDE6MzhQTSArMDgwMCwgcGV0ZXJ4QHJlZGhhdC5j b20gd3JvdGU6Cj4gRnJvbTogUGV0ZXIgWHUgPHBldGVyeEByZWRoYXQuY29tPgo+IAo+IFRoaXMg cGF0Y2ggcGFydGx5IHJldmVydHMgYmVsb3cgY29tbWl0czoKPiAKPiAzYTE5NGYzZjhhZDAgKCJt bS9odWdldGxiOiBtYWtlIHB1ZF9odWdlKCkgYW5kIGZvbGxvd19odWdlX3B1ZCgpIGF3YXJlIG9m IG5vbi1wcmVzZW50IHB1ZCBlbnRyeSIpCj4gY2JlZjg0NzhiZWU1ICgibW0vaHVnZXRsYjogcG1k X2h1Z2UoKSByZXR1cm5zIHRydWUgZm9yIG5vbi1wcmVzZW50IGh1Z2VwYWdlIikKPiAKPiBSaWdo dCBub3csIHBYZF9odWdlKCkgZGVmaW5pdGlvbiBhY3Jvc3Mga2VybmVsIGlzIHVuY2xlYXIuIFdl IGhhdmUgdHdvCj4gZ3JvdXBzIHRoYXQgdGhpbmsgZGlmZmVyZW50bHkgb24gc3dhcCBlbnRyaWVz Ogo+IAo+ICAgLSB4ODYvc3BhcmM6ICAgICBBbGxvdyBwWGRfaHVnZSgpIHRvIGFjY2VwdCBzd2Fw IGVudHJpZXMKPiAgIC0gYWxsIHRoZSByZXN0OiAgRG9lc24ndCBhbGxvdyBwWGRfaHVnZSgpIHRv IGFjY2VwdCBzd2FwIGVudHJpZXMKPiAKPiBUaGlzIGlzIHNvIGNvbmZ1c2luZy4gIFNpbmNlIHRo ZSBzcGFyYyBoZWxwZXJzIHNlZW0gdG8gYmUgYWRkZWQgaW4gMjAxNiwKPiB3aGljaCBpcyBhZnRl ciB4ODYncyAoMjAxNSksIHNvIHNwYXJjIGNvdWxkIGhhdmUgZm9sbG93ZWQgYSB0cmVuZC4gIHg4 Ngo+IHByb3Bvc2VkIHN1Y2ggc3dhcCBoYW5kbGluZyBpbiAyMDE1IHRvIHJlc29sdmUgaHVnZXRs YiBzd2FwIGVudHJpZXMgaGl0IGluCj4gR1VQLCBidXQgbm93IEdVUCBndWFyZHMgc3dhcCBlbnRy aWVzIHdpdGggIXBYZF9wcmVzZW50KCkgaW4gYWxsIGxheWVycyBzbwo+IHdlIHNob3VsZCBiZSBz YWZlLgo+IAo+IFdlIHNob3VsZCBkZWZpbmUgdGhpcyBBUEkgcHJvcGVybHksIG9uZSB3YXkgb3Ig YW5vdGhlciwgcmF0aGVyIHRoYW4ga2VlcAo+IHRoZW0gZGVmaW5lZCBkaWZmZXJlbnRseSBhY3Jv c3MgYXJjaHMuCj4gCj4gR3V0IGZlZWxpbmcgdGVsbHMgbWUgdGhhdCBwWGRfaHVnZSgpIHNob3Vs ZG4ndCBpbmNsdWRlIHN3YXAgZW50cmllcywgYW5kIGl0Cj4gdHVybnMgb3V0IHRoYXQgSSBhbSBu b3QgdGhlIG9ubHkgb25lIHRoaW5raW5nIHNvLCB0aGUgcXVlc3Rpb24gd2FzIHJhaXNlZAo+IHdo ZW4gdGhlIGN1cnJlbnQgcG1kX2h1Z2UoKSBmb3IgeDg2IHdhcyBwcm9wb3NlZCBieSBWaWxsZSBT eXJqw6Rsw6Q6Cj4gCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsL1kyV1E3STRMWGg4aVVJ UmRAaW50ZWwuY29tLwo+IAo+ICAgSSBtaWdodCBhbHNvIGJlIG1pc3Npbmcgc29tZXRoaW5nIG9i dmlvdXMsIGJ1dCB3aHkgaXMgaXQgZXZlbiBuZWNlc3NhcnkKPiAgIHRvIHRyZWF0IFBSRVNFTlQ9 PTArUFNFPT0wIGFzIGEgaHVnZSBlbnRyeT8KPiAKPiBJdCBpcyBhbHNvIHF1ZXN0aW9uZWQgd2hl biBKYXNvbiBHdW50aG9ycGUgcmV2aWV3ZWQgdGhlIG90aGVyIHBhdGNoc2V0IG9uCj4gc3dhcCBl bnRyeSBoYW5kbGluZ3M6Cj4gCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjQwMjIx MTI1NzUzLkdRMTMzMzBAbnZpZGlhLmNvbS8KPiAKPiBSZXZlcnQgaXRzIG1lYW5pbmcgYmFjayB0 byBvcmlnaW5hbC4gIEl0IHNob3VsZG4ndCBoYXZlIGFueSBmdW5jdGlvbmFsCj4gY2hhbmdlIGFz IHdlIHNob3VsZCBiZSByZWFkeSB3aXRoIGd1YXJkcyBvbiAhcFhkX3ByZXNlbnQoKSBleHBsaWNp dGx5Cj4gZXZlcnl3aGVyZS4KPiAKPiBOb3RlIHRoYXQgSSBhbHNvIGRyb3BwZWQgdGhlICIjaWYg Q09ORklHX1BHVEFCTEVfTEVWRUxTID4gMiIsIGl0IHdhcyB0aGVyZQo+IHByb2JhYmx5IGJlY2F1 c2UgaXQgd2FzIGJyZWFraW5nIHRoaW5ncyB3aGVuIDNhMTk0ZjNmOGFkMCB3YXMgcHJvcG9zZWQs Cj4gYWNjb3JkaW5nIHRvIHRoZSByZXBvcnQgaGVyZToKPiAKPiBodHRwczovL2xvcmUua2VybmVs Lm9yZy9hbGwvWTJMWVhJdEtReWFKVHY4akBpbnRlbC5jb20vCj4gCj4gTm93IHdlIHNob3VsZG4n dCBuZWVkIHRoYXQuCj4gCj4gSW5zdGVhZCBvZiByZXZlcnRpbmcgdG8gX1BBR0VfUFNFIHJhdyBj aGVjaywgbGV2ZXJhZ2UgcFhkX2xlYWYoKS4KPiAKPiBDYzogTmFveWEgSG9yaWd1Y2hpIDxuYW95 YS5ob3JpZ3VjaGlAbmVjLmNvbT4KPiBDYzogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9u aXguZGU+Cj4gQ2M6IEluZ28gTW9sbmFyIDxtaW5nb0ByZWRoYXQuY29tPgo+IENjOiBCb3Jpc2xh diBQZXRrb3YgPGJwQGFsaWVuOC5kZT4KPiBDYzogRGF2ZSBIYW5zZW4gPGRhdmUuaGFuc2VuQGxp bnV4LmludGVsLmNvbT4KPiBDYzogeDg2QGtlcm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBQZXRl ciBYdSA8cGV0ZXJ4QHJlZGhhdC5jb20+Cj4gLS0tCj4gIGFyY2gveDg2L21tL2h1Z2V0bGJwYWdl LmMgfCAxOCArKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgMTQgZGVsZXRpb25zKC0pCgpJIHRoaW5rIHRoaXMgaXMgdGhlIHJpZ2h0IHRoaW5nIHRv IGRvLCBjYWxsZXJzIHNob3VsZCBiZSBtb3JlIGRpcmVjdGx5CnNlbnNpdGl2ZSB0byBzd2FwIGVu dHJpZXMgbm90IGJhY2sgaW50byBpdCBpbmRpcmVjdGx5IGZyb20gYSBoZWxwZXIKbGlrZSB0aGlz LgoKSmFzb24KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK