All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection
Date: Thu, 7 Mar 2024 07:22:55 +0000	[thread overview]
Message-ID: <2024030726-corrosive-thicket-9cde@gregkh> (raw)
In-Reply-To: <20240305224518.39357-1-dorine.a.tipo@gmail.com>

On Tue, Mar 05, 2024 at 10:45:18PM +0000, Dorine Tipo wrote:
> Rename variable sii164EnableHotPlugDetection to
> sii164_enable_hot_plug_detection to silence checkpatch warning Avoid
> CamelCase
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index c12df1f9fb00..1ce44c50617a 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
>  		.reset_chip = sii164_reset_chip,
>  		.get_chip_string = sii164_get_chip_string,
>  		.set_power = sii164_set_power,
> -		.enable_hot_plug_detection = sii164EnableHotPlugDetection,
> +		.enable_hot_plug_detection = sii164_enable_hot_plug_detection,
>  		.is_connected = sii164IsConnected,
>  		.check_interrupt = sii164CheckInterrupt,
>  		.clear_interrupt = sii164ClearInterrupt,
> --
> 2.25.1
> 
> 

Hi,

You sent 5 patches, all look to be broken and not tested.  Please fix
them up and send them as a patch series.

thanks,

greg k-h

      reply	other threads:[~2024-03-07  7:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 22:45 [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection Dorine Tipo
2024-03-07  7:22 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024030726-corrosive-thicket-9cde@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dorine.a.tipo@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.