From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thorsten Scherer <t.scherer@eckelmann.de>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH 2/4] siox: Provide a devm variant of siox_master_alloc()
Date: Thu, 7 Mar 2024 07:29:59 +0000 [thread overview]
Message-ID: <2024030732-ocean-handbook-161f@gregkh> (raw)
In-Reply-To: <ftvih5huvc72a76s7fe4zisrqtaax5tcgoukqoi2bkz47zcrq2@4fixszonixgl>
On Thu, Mar 07, 2024 at 08:13:55AM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Feb 19, 2024 at 08:46:30AM +0100, Uwe Kleine-König wrote:
> > +struct siox_master *devm_siox_master_alloc(struct device *dev,
> > + size_t size)
> > +{
> > + struct siox_master *smaster;
> > + int ret;
> > +
> > + smaster = siox_master_alloc(dev, size);
> > + if (!smaster)
> > + return NULL;
> > +
> > + ret = devm_add_action_or_reset(dev, devm_siox_master_put, smaster);
> > + if (ret)
> > + return NULL;
> > +
> > + return smaster;
> > +}
>
> Here is missing an EXPORT_SYMBOL_GPL for devm_siox_master_alloc(). I
> squashed this into to commit I created. Find the fixed commit at
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git siox/for-next
Can you send me a "real" git pull request so that I can verify it is
what you say it is (ideally with a signed tag)?
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-07 7:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 7:46 [PATCH 0/4] siox: Move some complexity into the core Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 1/4] siox: Don't pass the reference on a master in siox_master_register() Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 2/4] siox: Provide a devm variant of siox_master_alloc() Uwe Kleine-König
2024-03-07 7:13 ` Uwe Kleine-König
2024-03-07 7:29 ` Greg Kroah-Hartman [this message]
2024-03-07 8:38 ` Uwe Kleine-König
2024-03-08 21:20 ` [PULL] siox changes for 6.9 Uwe Kleine-König
2024-03-16 7:37 ` Uwe Kleine-König
2024-03-22 7:22 ` Uwe Kleine-König
2024-03-22 7:31 ` Greg Kroah-Hartman
2024-03-23 9:21 ` Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 3/4] siox: Provide a devm variant of siox_master_register() Uwe Kleine-König
2024-02-19 7:46 ` [PATCH 4/4] siox: bus-gpio: Simplify using devm_siox_* functions Uwe Kleine-König
2024-02-27 10:21 ` [PATCH 0/4] siox: Move some complexity into the core Thorsten Scherer
2024-03-06 18:24 ` siox patches for next development cycle [Re: [PATCH 0/4] siox: Move some complexity into the core] Uwe Kleine-König
2024-03-06 21:34 ` Stephen Rothwell
2024-03-06 22:46 ` Greg Kroah-Hartman
2024-03-07 7:08 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030732-ocean-handbook-161f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=t.scherer@eckelmann.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.