From: Isaku Yamahata <isaku.yamahata@linux.intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Isaku Yamahata <isaku.yamahata@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
erdemaktas@google.com, Vishal Annapurve <vannapurve@google.com>,
Jim Mattson <jmattson@google.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
isaku.yamahata@gmail.com, isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v3 3/4] KVM: X86: Add a capability to configure bus frequency for APIC timer
Date: Thu, 7 Mar 2024 17:36:07 -0800 [thread overview]
Message-ID: <20240308013607.GL368614@ls.amr.corp.intel.com> (raw)
In-Reply-To: <ZdjzIgS6EAeCsUue@google.com>
On Fri, Feb 23, 2024 at 11:33:54AM -0800,
Sean Christopherson <seanjc@google.com> wrote:
> On Tue, Dec 19, 2023, Isaku Yamahata wrote:
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index 7025b3751027..cc976df2651e 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -7858,6 +7858,20 @@ This capability is aimed to mitigate the threat that malicious VMs can
> > cause CPU stuck (due to event windows don't open up) and make the CPU
> > unavailable to host or other VMs.
> >
> > +7.34 KVM_CAP_X86_BUS_FREQUENCY_CONTROL
>
> BUS_FREQUENCY_CONTROL is simultaneously too long, yet not descriptive enough.
> Depending on whether people get hung up on nanoseconds not being a "frequency",
> either KVM_CAP_X86_APIC_BUS_FREQUENCY or KVM_CAP_X86_APIC_BUS_CYCLES_NS.
>
> Also, this series needs to be rebased onto kvm-x86/next.
Thanks for the feedback with the concrete change to the patch.
I agree with those for the next respin.
--
Isaku Yamahata <isaku.yamahata@linux.intel.com>
next prev parent reply other threads:[~2024-03-08 1:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 8:34 [PATCH v3 0/4] KVM: X86: Make bus clock frequency for vapic timer configurable Isaku Yamahata
2023-12-19 8:34 ` [PATCH v3 1/4] KVM: x86/hyperv: Calculate APIC bus frequency for hyper-v Isaku Yamahata
2023-12-21 5:26 ` Xiaoyao Li
2023-12-29 4:20 ` Xiaoyao Li
2023-12-21 17:39 ` Maxim Levitsky
2023-12-19 8:34 ` [PATCH v3 2/4] KVM: x86: Make the APIC bus cycles per nsec VM variable Isaku Yamahata
2023-12-21 5:34 ` Xiaoyao Li
2023-12-21 17:39 ` Maxim Levitsky
2023-12-19 8:34 ` [PATCH v3 3/4] KVM: X86: Add a capability to configure bus frequency for APIC timer Isaku Yamahata
2023-12-29 4:41 ` Xiaoyao Li
2024-02-23 19:33 ` Sean Christopherson
2024-03-08 1:36 ` Isaku Yamahata [this message]
2023-12-19 8:34 ` [PATCH v3 4/4] KVM: selftests: Add test case for x86 apic_bus_clock_frequency Isaku Yamahata
2023-12-21 17:38 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308013607.GL368614@ls.amr.corp.intel.com \
--to=isaku.yamahata@linux.intel.com \
--cc=erdemaktas@google.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.