From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B15631A83 for ; Fri, 8 Mar 2024 05:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709876201; cv=none; b=D9CtMfXfIRsGYJ8dVtiF8aQT/CcYzhlevUnekNQbtVRPxCIb5CMoDppKiTIkLmVv5pC+czDZUkAf+ghxerSDwygQ7L2ocKb+3rOAGHBV1zxHuGpKAqoXriqelm2v9iMj/hO6Rb4xtxRNiyqOZIOjnLbPRhxKzXLrq6Vn/RtuUfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709876201; c=relaxed/simple; bh=CGWk1k+osmUSnjHGpIloUEL/BTJMGKlT7uAEdzjuHTo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nDCl5a5MeIdn7ymKL6a4RWB36ij/Fk0gdiyjsu7DaBavnmcCP490nZiB9mwJgYX+nIImXfGoDyqUsc00m2FD9jkoKIdpVfvPfTO02BWYl5zCE0L1d6drpuc5zh62Wzyo71jjfGKYGXBgiJqyuvslbWXOKU8i4XR2VJUMa0sylw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=v2uqPTcp; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v2uqPTcp" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3bbbc6b4ed1so1022725b6e.2 for ; Thu, 07 Mar 2024 21:36:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876199; x=1710480999; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=t5usu+wIHjrQwBdpY/kUT6MzVOdZTbW6PSQFUQqDoaA=; b=v2uqPTcp9dXDlK0NKL8G06wXWA8y+J92Wgr2fdtbBzlkkTV68eBfAIzqkoNazWBmFa 2xStiKbKeOfsVjGwAQIfo1RmtTGZxVAOdm7b3pQfzIVcRiUFurk0KuMBWwOFbRsSAwBQ cTGnhyYzzAF6nlloUocuPaTXQhvtm3YYW/yb5oMov6E+W/noaEp34V8klUbP+hl80eeJ nJz3ggToUPMxNNeQjAT3VeFqABKworqBIMvBBvynLKqxFOwXw8yKl0u61oQxbWQ9Kkl5 K+Ht9XClxupt6drl8FUTMDecIVZrPgbApfkWALWsVmJL5pXN8ORsPbD7bla+F0ydK4e6 X4Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876199; x=1710480999; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t5usu+wIHjrQwBdpY/kUT6MzVOdZTbW6PSQFUQqDoaA=; b=ZokgIAvLFsgQCvBmw5Kv6n4J1+sgV5ZE8Af0tcBi306MoG0WogStfSxgWQIrleQg2g ic6P8X7FIfVtLInXdvmMZ/kGMyUIZIf70unU8Obs4h6dN9ChiBeaqRGtxXZy0CD5Lp7W bGBsiZoDHb13ZNyuD51lPxnciJ1DKY98C3ggp8icucRCx7X2deg4YirYwCYGlDX4mmgo Qumr3ahnXOGQivXqegoZSKYpiqKTMrjZi8/LEELfTwDEqkyaLKoIYU3/YrhRtuTFRP9f MjBx6HB+57YY5ZeXh9VdBPgOBkCHXo3CjEd4N2CkmdqcY32O6zX3Xg8f1oC7C3ISWXAE 5Xjw== X-Forwarded-Encrypted: i=1; AJvYcCXkD+f13RTL2VKgo1wrOdeSF0NAlNIlLAeiY8+i0LF5KBAL/4TPGGuZJwCRhiev7iLph1TrRi5ls6s/uEQItLXt+h3S/TN5r5tO1CjuDA== X-Gm-Message-State: AOJu0Yx3KdI6mw20gOxOlV+fd5VNrDBZfpP4FGqA3+j+c5vvchziqhTU cNNgRq15Anx3UQZzRWssNhXP7ZXgAThcDnzulO6GJbLF0FcJKSuvVedPzNA90Q== X-Google-Smtp-Source: AGHT+IHj0s/MgXdETk1px2mifakT3T/ik8rZsoVSs9rmOK2GEfO1NijLKPOfSrYwO+VEWrCBP34KEg== X-Received: by 2002:aca:2b17:0:b0:3c1:f32e:8acd with SMTP id i23-20020aca2b17000000b003c1f32e8acdmr9318128oik.59.1709876198985; Thu, 07 Mar 2024 21:36:38 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id u20-20020a62d454000000b006e468cd0a5asm14446363pfl.178.2024.03.07.21.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:36:38 -0800 (PST) Date: Fri, 8 Mar 2024 11:06:24 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308053624.GB3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 07, 2024 at 09:36:56PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:18PM +0530, Manivannan Sadhasivam wrote: > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > drivers requiring active refclk from host. But for the other drivers, it is > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > that this API initializes DWC EP specific registers and that requires an > > active refclk (either from host or generated locally by endpoint itsef). > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > confusion, let's call this API directly from all glue drivers irrespective > > of refclk dependency. Only difference here is that the drivers requiring > > refclk from host will call this API only after the refclk is received and > > other drivers without refclk dependency will call this API right after > > dw_pcie_ep_init(). > > > > With this change, the check for 'core_init_notifier' flag can now be > > dropped from dw_pcie_ep_init() API. This will also allow us to remove the > > 'core_init_notifier' flag completely in the later commits. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > drivers/pci/controller/dwc/pcie-artpec6.c | 13 ++++++++++++- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > drivers/pci/controller/dwc/pcie-keembay.c | 16 +++++++++++++++- > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > 10 files changed, 90 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > > index 0e406677060d..395042b29ffc 100644 > > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > > @@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, > > return ret; > > } > > > > + ret = dw_pcie_ep_init_registers(ep); > > + if (ret) { > > Here you are using if (ret) to error check the return from > dw_pcie_ep_init_registers(). > > > > index c0c62533a3f1..8392894ed286 100644 > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > @@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) > > ret = dw_pcie_ep_init(&pci->ep); > > if (ret < 0) > > goto err_get_sync; > > + > > + ret = dw_pcie_ep_init_registers(&pci->ep); > > + if (ret < 0) { > > Here you are using if (ret < 0) to error check the return from > dw_pcie_ep_init_registers(). Please be consistent. > I maintained the consistency w.r.t individual drivers. Please check them individually. If I maintain consistency w.r.t this patch, then the style will change within the drivers. - Mani > > > diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c > > index 9ed0a9ba7619..0edd9ab3f139 100644 > > --- a/drivers/pci/controller/dwc/pcie-artpec6.c > > +++ b/drivers/pci/controller/dwc/pcie-artpec6.c > > @@ -441,7 +441,18 @@ static int artpec6_pcie_probe(struct platform_device *pdev) > > > > pci->ep.ops = &pcie_ep_ops; > > > > - return dw_pcie_ep_init(&pci->ep); > > + ret = dw_pcie_ep_init(&pci->ep); > > + if (ret < 0) > > Here you are using if (ret < 0) to error check the return from > dw_pcie_ep_init(). > > > > index 778588b4be70..ca9b22e654cd 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-plat.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c > > @@ -145,6 +145,15 @@ static int dw_plat_pcie_probe(struct platform_device *pdev) > > > > pci->ep.ops = &pcie_ep_ops; > > ret = dw_pcie_ep_init(&pci->ep); > > + if (ret) > > Here you are using if (ret) to error check the return from > dw_pcie_ep_init(). Please be consistent. -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED912C54E41 for ; Fri, 8 Mar 2024 05:37:24 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NoGW5S11; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrZgR3TCgz3vZg for ; Fri, 8 Mar 2024 16:37:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NoGW5S11; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::233; helo=mail-oi1-x233.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrZff1kGGz2xSl for ; Fri, 8 Mar 2024 16:36:42 +1100 (AEDT) Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3bbbc6b4ed1so1022718b6e.2 for ; Thu, 07 Mar 2024 21:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876199; x=1710480999; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=t5usu+wIHjrQwBdpY/kUT6MzVOdZTbW6PSQFUQqDoaA=; b=NoGW5S1193EFOMLtuQIFDZtuiwD9Tcl1zslQCGpK6JLc0zcjsyoawMDDVcZi/xJpzZ UTHH2icK/zODG/crJcm6E+b+6s4hfsKnUJja8U5UhHVV9WNkkXSS9JRW8crFIyzkweeK 9lRDL5nXHc8gjM9rE1x+JbPqTNx7W4DOjFhQ2RKg09nZNg/V9fnSeALOFFRyBtZiZgoI b5zkqw+Xp9eMCKA+gXaQnE5+pFKF93yxHXSt1VxHTfj7V/7V/JAOGOv0LiN61esQLwrS z1MLE1Byv0hYaLFRB0xu0IW2si2upWm3ggS41dM3luxQVvABOvphevHtRAu+TiUM25x/ 8w3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876199; x=1710480999; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t5usu+wIHjrQwBdpY/kUT6MzVOdZTbW6PSQFUQqDoaA=; b=M9nN6Z+nxY7JW334zZBGedku2nhiRh9eudzSlud88jBD5uYB20nxvAHYNh8AiMJddO nGMBbRFBZQmjPdYo8lxBl1WEXN4hX7FBTKAlw15cBYVyaX92DcuGrYx8FHSyhK8OiJ7M ztqTjJp+SkDk87KJyvL5L2JdL9gIpcyHp9YNdcm9q+u1N7YcWQjqBE8VOBdQkQyDPEJW jz/bMisitOQe6p7FtIJgiIo0ZITmmOHBO5vgBSMrfUJSYMcUcNs3V3pxs+sbJyv+ADIc /TUFZ5ysb8FI/3ImUvyoJZ6ntAnvTnn3Qfya/PuZOlxgfwHBJrFbw0O1lXrqQuB20cZw YdNg== X-Forwarded-Encrypted: i=1; AJvYcCVmoufCIUHRrRCsEcm4OJpxoVCZJ9MznD/guRyWsZ1SOHAT3BK+zvYOd6ycWA8bKQdds3OnB4lO8ND401ewb/nfbBwu+qdZWTEjS/mTRQ== X-Gm-Message-State: AOJu0YzmiiJb3t+ED/GH50iaKNROxK90M3HEafjhhUjBZzQfvIPXCMEi +AJH7KKcjWyQ6NvP4gjAaV+rxvHaqvjLbHp5CnIu8MbpSe9OvvfEF9uOLni6oQ== X-Google-Smtp-Source: AGHT+IHj0s/MgXdETk1px2mifakT3T/ik8rZsoVSs9rmOK2GEfO1NijLKPOfSrYwO+VEWrCBP34KEg== X-Received: by 2002:aca:2b17:0:b0:3c1:f32e:8acd with SMTP id i23-20020aca2b17000000b003c1f32e8acdmr9318128oik.59.1709876198985; Thu, 07 Mar 2024 21:36:38 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id u20-20020a62d454000000b006e468cd0a5asm14446363pfl.178.2024.03.07.21.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:36:38 -0800 (PST) Date: Fri, 8 Mar 2024 11:06:24 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308053624.GB3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 07, 2024 at 09:36:56PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:18PM +0530, Manivannan Sadhasivam wrote: > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > drivers requiring active refclk from host. But for the other drivers, it is > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > that this API initializes DWC EP specific registers and that requires an > > active refclk (either from host or generated locally by endpoint itsef). > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > confusion, let's call this API directly from all glue drivers irrespective > > of refclk dependency. Only difference here is that the drivers requiring > > refclk from host will call this API only after the refclk is received and > > other drivers without refclk dependency will call this API right after > > dw_pcie_ep_init(). > > > > With this change, the check for 'core_init_notifier' flag can now be > > dropped from dw_pcie_ep_init() API. This will also allow us to remove the > > 'core_init_notifier' flag completely in the later commits. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > drivers/pci/controller/dwc/pcie-artpec6.c | 13 ++++++++++++- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > drivers/pci/controller/dwc/pcie-keembay.c | 16 +++++++++++++++- > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > 10 files changed, 90 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > > index 0e406677060d..395042b29ffc 100644 > > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > > @@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, > > return ret; > > } > > > > + ret = dw_pcie_ep_init_registers(ep); > > + if (ret) { > > Here you are using if (ret) to error check the return from > dw_pcie_ep_init_registers(). > > > > index c0c62533a3f1..8392894ed286 100644 > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > @@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) > > ret = dw_pcie_ep_init(&pci->ep); > > if (ret < 0) > > goto err_get_sync; > > + > > + ret = dw_pcie_ep_init_registers(&pci->ep); > > + if (ret < 0) { > > Here you are using if (ret < 0) to error check the return from > dw_pcie_ep_init_registers(). Please be consistent. > I maintained the consistency w.r.t individual drivers. Please check them individually. If I maintain consistency w.r.t this patch, then the style will change within the drivers. - Mani > > > diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c > > index 9ed0a9ba7619..0edd9ab3f139 100644 > > --- a/drivers/pci/controller/dwc/pcie-artpec6.c > > +++ b/drivers/pci/controller/dwc/pcie-artpec6.c > > @@ -441,7 +441,18 @@ static int artpec6_pcie_probe(struct platform_device *pdev) > > > > pci->ep.ops = &pcie_ep_ops; > > > > - return dw_pcie_ep_init(&pci->ep); > > + ret = dw_pcie_ep_init(&pci->ep); > > + if (ret < 0) > > Here you are using if (ret < 0) to error check the return from > dw_pcie_ep_init(). > > > > index 778588b4be70..ca9b22e654cd 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-plat.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c > > @@ -145,6 +145,15 @@ static int dw_plat_pcie_probe(struct platform_device *pdev) > > > > pci->ep.ops = &pcie_ep_ops; > > ret = dw_pcie_ep_init(&pci->ep); > > + if (ret) > > Here you are using if (ret) to error check the return from > dw_pcie_ep_init(). Please be consistent. -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC437C54E41 for ; Fri, 8 Mar 2024 05:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SqsJcwN3eIDW6CWhmH5qPwXMkPx78fQGGQ2ImSMyUUU=; b=FQkf0C/aQJRKT1 gvM/sjsecgZzeCCAJQXQh/qW6eLG4e/ueL6+sQub+jWNm2/a+aGWRJEdigtXyv1IZsv0Ph0bsLSM9 Coiz4mV3thHo7LfVXjhIzgt4e4Au4qsvqf7oFakcd7f8jezxQiYXbVSCmtIo8M9YEDskylEQUJ4iU a5aCa8cVJ2xg964PZqO6HGqWsTRv6O1l4DMzVnGhG61IWa2199az+DZ72U2qmN+QRO4gNI4Mw6zD2 tTogL2jcelCMmJlirm/R07Ewhz+CkriNvWJVHqDX6zFHPd+GgELP3r3+9Hy2n7K4OkA79QA7Jcqi1 UOg3k1EP5iPc8uacuHdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riSuS-00000007tEv-0RWu; Fri, 08 Mar 2024 05:36:44 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riSuP-00000007tCq-0Qfc for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 05:36:42 +0000 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3bbbc6b4ed1so1022722b6e.2 for ; Thu, 07 Mar 2024 21:36:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876199; x=1710480999; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=t5usu+wIHjrQwBdpY/kUT6MzVOdZTbW6PSQFUQqDoaA=; b=TGD16zDqwIEFJpprbpO9HdAsgDICUSlaJrwk7c/rQ0JM3azkvtQjJxtiwR3B6R9GTk XA67ASfaLdyWr2znAR+cWmCtYzk3bsC76wtULUVrqrpmjor5QKimdQlXhTHaUShW9brM GgPrxFbOxstyXCFWBCg0xrzjGnc8r4ztDjupe0tK1k5yW/N94urj/U4tdwQ8Fx9pvkKF e8Jf4805lbgBH7Sy+6dihsPB3ibrnglPF8txOrfNbVzKm6qCoyLTi/BhMA5n1fMCUB4c klzEwpJcnC0To6nrkgAMqeeL/UArjJrjHFediORiG3lb/R2QSPFOA/sBg1DCMOOGjBXv aUCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876199; x=1710480999; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t5usu+wIHjrQwBdpY/kUT6MzVOdZTbW6PSQFUQqDoaA=; b=FQ9d9dqiVyEHmlnZjOE1E5BoaIuAQYTks8774Ukh9tAa/62f/gSwRzdAQZfSbt+umq 0eq0WvwDfrcmssGmRfjuwbDaWM6tzM2HnVmLTjgJKxLIzS5solblB0Ta3HXg2nBHlAEm yEiT74A6RhYIx9zxrBjhYolbENid/OXVU8vl05ZFaoBDdXh/F/jyp04s7jguwhDTwsos 75CmA9z8DA4w+KgUfAxhUfLUF2ESoU6O9WD1Y1nYSku7miJPzMuCS+KvfTrgdT1ckofF 8CmunVvgfeLUY+k8873R8OpTSkh2PHb1czNVYqqowcqc5CJcLTzDTSgUZgdzcO8ri64D 6E0g== X-Forwarded-Encrypted: i=1; AJvYcCV+3gd0l4rzpPdILYS1CP2t0g2DIsoKGnC1yI5PvbWbra/il9kErnOQOJp8klVgPXi/DcIDOgVpG3iak+Nwz1IYt24cUZ2ybQ7vD3TAhqPLlKK9FEA= X-Gm-Message-State: AOJu0Yxbb0snZUakRMGo7BWe3QXrHrx+KLARlmrMe/dmX1id01V8miLx lE7FVHKCdGTcyrPoGZ4ZUVFiAqoUs/s3cL8rI8ot8YG4dcNM2aEIelgQr+OWCQ== X-Google-Smtp-Source: AGHT+IHj0s/MgXdETk1px2mifakT3T/ik8rZsoVSs9rmOK2GEfO1NijLKPOfSrYwO+VEWrCBP34KEg== X-Received: by 2002:aca:2b17:0:b0:3c1:f32e:8acd with SMTP id i23-20020aca2b17000000b003c1f32e8acdmr9318128oik.59.1709876198985; Thu, 07 Mar 2024 21:36:38 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id u20-20020a62d454000000b006e468cd0a5asm14446363pfl.178.2024.03.07.21.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:36:38 -0800 (PST) Date: Fri, 8 Mar 2024 11:06:24 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308053624.GB3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_213641_182744_BC1A20E6 X-CRM114-Status: GOOD ( 28.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMDcsIDIwMjQgYXQgMDk6MzY6NTZQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwMjo1MjoxOFBNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiBDdXJyZW50bHksIGR3X3BjaWVfZXBfaW5pdF9yZWdp c3RlcnMoKSBBUEkgaXMgZGlyZWN0bHkgY2FsbGVkIGJ5IHRoZSBnbHVlCj4gPiBkcml2ZXJzIHJl cXVpcmluZyBhY3RpdmUgcmVmY2xrIGZyb20gaG9zdC4gQnV0IGZvciB0aGUgb3RoZXIgZHJpdmVy cywgaXQgaXMKPiA+IGdldHRpbmcgY2FsbGVkIGltcGxpY2l0bHkgYnkgZHdfcGNpZV9lcF9pbml0 KCkuIFRoaXMgaXMgZHVlIHRvIHRoZSBmYWN0Cj4gPiB0aGF0IHRoaXMgQVBJIGluaXRpYWxpemVz IERXQyBFUCBzcGVjaWZpYyByZWdpc3RlcnMgYW5kIHRoYXQgcmVxdWlyZXMgYW4KPiA+IGFjdGl2 ZSByZWZjbGsgKGVpdGhlciBmcm9tIGhvc3Qgb3IgZ2VuZXJhdGVkIGxvY2FsbHkgYnkgZW5kcG9p bnQgaXRzZWYpLgo+ID4gCj4gPiBCdXQsIHRoaXMgY2F1c2VzIGEgZGlzY3JlcGFuY3kgYW1vbmcg dGhlIGdsdWUgZHJpdmVycy4gU28gdG8gYXZvaWQgdGhpcwo+ID4gY29uZnVzaW9uLCBsZXQncyBj YWxsIHRoaXMgQVBJIGRpcmVjdGx5IGZyb20gYWxsIGdsdWUgZHJpdmVycyBpcnJlc3BlY3RpdmUK PiA+IG9mIHJlZmNsayBkZXBlbmRlbmN5LiBPbmx5IGRpZmZlcmVuY2UgaGVyZSBpcyB0aGF0IHRo ZSBkcml2ZXJzIHJlcXVpcmluZwo+ID4gcmVmY2xrIGZyb20gaG9zdCB3aWxsIGNhbGwgdGhpcyBB UEkgb25seSBhZnRlciB0aGUgcmVmY2xrIGlzIHJlY2VpdmVkIGFuZAo+ID4gb3RoZXIgZHJpdmVy cyB3aXRob3V0IHJlZmNsayBkZXBlbmRlbmN5IHdpbGwgY2FsbCB0aGlzIEFQSSByaWdodCBhZnRl cgo+ID4gZHdfcGNpZV9lcF9pbml0KCkuCj4gPiAKPiA+IFdpdGggdGhpcyBjaGFuZ2UsIHRoZSBj aGVjayBmb3IgJ2NvcmVfaW5pdF9ub3RpZmllcicgZmxhZyBjYW4gbm93IGJlCj4gPiBkcm9wcGVk IGZyb20gZHdfcGNpZV9lcF9pbml0KCkgQVBJLiBUaGlzIHdpbGwgYWxzbyBhbGxvdyB1cyB0byBy ZW1vdmUgdGhlCj4gPiAnY29yZV9pbml0X25vdGlmaWVyJyBmbGFnIGNvbXBsZXRlbHkgaW4gdGhl IGxhdGVyIGNvbW1pdHMuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1hbml2YW5uYW4gU2FkaGFz aXZhbSA8bWFuaXZhbm5hbi5zYWRoYXNpdmFtQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZHJhN3h4LmMgICAgICAgICAgIHwgIDcgKysrKysr Kwo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgICAgICAgICAgICAg fCAgOCArKysrKysrKwo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9u ZS5jICAgICAgICAgfCAgOSArKysrKysrKysKPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3 Yy9wY2ktbGF5ZXJzY2FwZS1lcC5jICAgIHwgIDcgKysrKysrKwo+ID4gIGRyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaWUtYXJ0cGVjNi5jICAgICAgICAgfCAxMyArKysrKysrKysrKystCj4g PiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMgICB8IDIy IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLWRlc2lnbndhcmUtcGxhdC5jIHwgIDkgKysrKysrKysrCj4gPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpZS1rZWVtYmF5LmMgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKy0K PiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXJjYXItZ2VuNC5jICAgICAgIHwg MTIgKysrKysrKysrKystCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS11bmlw aGllci1lcC5jICAgICB8IDEzICsrKysrKysrKysrKy0KPiA+ICAxMCBmaWxlcyBjaGFuZ2VkLCA5 MCBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1kcmE3eHguYyBiL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1kcmE3eHguYwo+ID4gaW5kZXggMGU0MDY2NzcwNjBkLi4zOTUwNDJiMjlm ZmMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZHJhN3h4 LmMKPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1kcmE3eHguYwo+ID4g QEAgLTQ2Nyw2ICs0NjcsMTMgQEAgc3RhdGljIGludCBkcmE3eHhfYWRkX3BjaWVfZXAoc3RydWN0 IGRyYTd4eF9wY2llICpkcmE3eHgsCj4gPiAgCQlyZXR1cm4gcmV0Owo+ID4gIAl9Cj4gPiAgCj4g PiArCXJldCA9IGR3X3BjaWVfZXBfaW5pdF9yZWdpc3RlcnMoZXApOwo+ID4gKwlpZiAocmV0KSB7 Cj4gCj4gSGVyZSB5b3UgYXJlIHVzaW5nIGlmIChyZXQpIHRvIGVycm9yIGNoZWNrIHRoZSByZXR1 cm4gZnJvbQo+IGR3X3BjaWVfZXBfaW5pdF9yZWdpc3RlcnMoKS4KPiAKPiAKPiA+IGluZGV4IGMw YzYyNTMzYTNmMS4uODM5Mjg5NGVkMjg2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWtleXN0b25lLmMKPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xs ZXIvZHdjL3BjaS1rZXlzdG9uZS5jCj4gPiBAQCAtMTI4Niw2ICsxMjg2LDEzIEBAIHN0YXRpYyBp bnQga3NfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gIAkJcmV0 ID0gZHdfcGNpZV9lcF9pbml0KCZwY2ktPmVwKTsKPiA+ICAJCWlmIChyZXQgPCAwKQo+ID4gIAkJ CWdvdG8gZXJyX2dldF9zeW5jOwo+ID4gKwo+ID4gKwkJcmV0ID0gZHdfcGNpZV9lcF9pbml0X3Jl Z2lzdGVycygmcGNpLT5lcCk7Cj4gPiArCQlpZiAocmV0IDwgMCkgewo+IAo+IEhlcmUgeW91IGFy ZSB1c2luZyBpZiAocmV0IDwgMCkgdG8gZXJyb3IgY2hlY2sgdGhlIHJldHVybiBmcm9tCj4gZHdf cGNpZV9lcF9pbml0X3JlZ2lzdGVycygpLiBQbGVhc2UgYmUgY29uc2lzdGVudC4KPiAKCkkgbWFp bnRhaW5lZCB0aGUgY29uc2lzdGVuY3kgdy5yLnQgaW5kaXZpZHVhbCBkcml2ZXJzLiBQbGVhc2Ug Y2hlY2sgdGhlbQppbmRpdmlkdWFsbHkuCgpJZiBJIG1haW50YWluIGNvbnNpc3RlbmN5IHcuci50 IHRoaXMgcGF0Y2gsIHRoZW4gdGhlIHN0eWxlIHdpbGwgY2hhbmdlIHdpdGhpbgp0aGUgZHJpdmVy cy4KCi0gTWFuaQoKPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3 Yy9wY2llLWFydHBlYzYuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtYXJ0cGVj Ni5jCj4gPiBpbmRleCA5ZWQwYTliYTc2MTkuLjBlZGQ5YWIzZjEzOSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtYXJ0cGVjNi5jCj4gPiArKysgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFydHBlYzYuYwo+ID4gQEAgLTQ0MSw3ICs0NDEs MTggQEAgc3RhdGljIGludCBhcnRwZWM2X3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiA+ICAKPiA+ICAJCXBjaS0+ZXAub3BzID0gJnBjaWVfZXBfb3BzOwo+ID4gIAo+ ID4gLQkJcmV0dXJuIGR3X3BjaWVfZXBfaW5pdCgmcGNpLT5lcCk7Cj4gPiArCQlyZXQgPSBkd19w Y2llX2VwX2luaXQoJnBjaS0+ZXApOwo+ID4gKwkJaWYgKHJldCA8IDApCj4gCj4gSGVyZSB5b3Ug YXJlIHVzaW5nIGlmIChyZXQgPCAwKSB0byBlcnJvciBjaGVjayB0aGUgcmV0dXJuIGZyb20KPiBk d19wY2llX2VwX2luaXQoKS4KPiAKPiAKPiA+IGluZGV4IDc3ODU4OGI0YmU3MC4uY2E5YjIyZTY1 NGNkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNp Z253YXJlLXBsYXQuYwo+ID4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1k ZXNpZ253YXJlLXBsYXQuYwo+ID4gQEAgLTE0NSw2ICsxNDUsMTUgQEAgc3RhdGljIGludCBkd19w bGF0X3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ICAKPiA+ICAJ CXBjaS0+ZXAub3BzID0gJnBjaWVfZXBfb3BzOwo+ID4gIAkJcmV0ID0gZHdfcGNpZV9lcF9pbml0 KCZwY2ktPmVwKTsKPiA+ICsJCWlmIChyZXQpCj4gCj4gSGVyZSB5b3UgYXJlIHVzaW5nIGlmIChy ZXQpIHRvIGVycm9yIGNoZWNrIHRoZSByZXR1cm4gZnJvbQo+IGR3X3BjaWVfZXBfaW5pdCgpLiBQ bGVhc2UgYmUgY29uc2lzdGVudC4KCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a 4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==