From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8FA32C9C for ; Fri, 8 Mar 2024 05:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709876326; cv=none; b=pEB+eyaXVrer0IqFqitTROPKga6IKXy6Wm+h/RGJflT9L1oaL+APm0Sy9MKnl7j4TcG4WqhNnLGJCqsQoNHqN9M94c7eyF6te20RC1Lx0mWBvSQrI8SmkfAIqhs5WeWGOn8zSr1tBc9+x3l4d3Fqxi/T2KEgfaIqWVSgBbGG6aA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709876326; c=relaxed/simple; bh=s6AAzj9sTa4DqwiYGNiVH8lleweJM08Qd7fO/aNO1Aw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M5fpswzCqBy4PFK9enAkOGpnmfAH9mvOkATivmkIZHoctrQzQlth38S08Zp0BgiE90iUXBLT2OV1iEXoajv7j0FihG09yy8lE5TugHnPzEwwV0lId44Pn701ACMt/J2gsdUfrYD1rUfOVJi19lKwXMWLDBM2MUOGr9+IqEZ7bJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=juriCvY2; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="juriCvY2" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dd10ae77d8so14728045ad.0 for ; Thu, 07 Mar 2024 21:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876324; x=1710481124; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DUybYaiPJClMOkVE2KcQ/JxyjAJYL0HAMjXF/A+2etI=; b=juriCvY2LUW8K+fvMfcJ9XAOijDfTMn7RSlwIkicLQAGQPG3M/Oc2CCut7sYRc2qOs PoGUbmS4wFeEnYdxo8x9PXpgdbEW56M9Q3XUQAeTRUdSHuGrDjp/jjTjz3wcg0aSTEhl jicKsD5Rb0kjZKKOYFHYXMI5gwXyP971Z9uQgI9x4nAXHqTXBqZPgCJrHfI+lwMuo2oO UUzeaRg2TgNs0+DFBIrMWMKfz6BfNF8eHMo8QOfNNawb4R2KYDvrowoo+lcQzbJMcLl9 lGaB+FAzwyHHzvZ3KEqs6NB3ShFsDerx5dd35FUkqTbmhmtx8Kh2W5ag6hdXqRiTFlHU oDag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876324; x=1710481124; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DUybYaiPJClMOkVE2KcQ/JxyjAJYL0HAMjXF/A+2etI=; b=m3zOlw2UrqrXF9Mbe6S7GX5LN7Co3c+By1gzAtKVHmOZ6CNHM8RQlnowI+liUWuMVL ySpmfIuosecx93PZpSd7JxY6BOnOSTZtK4+JXcgdlIBSVj77FriRKNxOQdxkf+jOpsaL gz1A8fFjY5wGJQf6Zthpapgt3e9X6ko2wKCF1jkS2dVSbJBEHRAaBmoQjWsl3pQvAKIN jiS77563lCzvbzcGNAMGBsqqfdpBQ9t4bvqK8766YyaZc7Pu2vpZKXyYC8Rktj/z8a5A W001efSSrRoLxfzQTe02oxL7iZFMKMZkjT2+fz5aOT8ALrrlNa7afSORGUsdfmfrVQyb 14kw== X-Forwarded-Encrypted: i=1; AJvYcCXsPxujea6xsxEOC5J8xeEykrrUjCry6glf5A/nf0OLpKKv6IMKAfvzx1cQaFFzGu+CeqXjow0D843qn4t2EHZ7P680fFIx+lwhPW4sQQ== X-Gm-Message-State: AOJu0Yyhc7ZkZtdBww61VHRHFMMc3HpvK3b5V/SKHc0TfSBmcWg1dwmk 1jnxARORgrr8XD+FYuay8B8AGqECL1wemp5C0imxyWyhVe7NwY6F6DNkpCby+Q== X-Google-Smtp-Source: AGHT+IFnxmsrp/JdPtnzlcbTNURcPyjpmM+tg6dX1wncoxt7+3e7o8Cy2Ru1ZT2zUpWAw+nYHfuG6A== X-Received: by 2002:a17:903:1249:b0:1db:4419:e925 with SMTP id u9-20020a170903124900b001db4419e925mr11913418plh.1.1709876324294; Thu, 07 Mar 2024 21:38:44 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id f11-20020a170903104b00b001db717ed294sm923036plc.120.2024.03.07.21.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:38:43 -0800 (PST) Date: Fri, 8 Mar 2024 11:08:29 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240308053829.GC3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 07, 2024 at 10:09:06PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:19PM +0530, Manivannan Sadhasivam wrote: > > "core_init_notifier" flag is set by the glue drivers requiring refclk from > > the host to complete the DWC core initialization. Also, those drivers will > > send a notification to the EPF drivers once the initialization is fully > > completed using the pci_epc_init_notify() API. Only then, the EPF drivers > > will start functioning. > > > > For the rest of the drivers generating refclk locally, EPF drivers will > > start functioning post binding with them. EPF drivers rely on the > > 'core_init_notifier' flag to differentiate between the drivers. > > Unfortunately, this creates two different flows for the EPF drivers. > > > > So to avoid that, let's get rid of the "core_init_notifier" flag and follow > > a single initialization flow for the EPF drivers. This is done by calling > > the dw_pcie_ep_init_notify() from all glue drivers after the completion of > > dw_pcie_ep_init_registers() API. This will allow all the glue drivers to > > send the notification to the EPF drivers once the initialization is fully > > completed. > > > > Only difference here is that, the drivers requiring refclk from host will > > send the notification once refclk is received, while others will send it > > during probe time itself. > > > > Reviewed-by: Frank Li > > Signed-off-by: Manivannan Sadhasivam > > --- > > You have removed the .core_init_notifier from EPC drivers, > but the callback in EPF drivers is still called .core_init. > > Yes, this was a confusing name even before this patch, but > after this patch, it is probably even worse :) > > The callback should be named from the perspective of EPF drivers IMO. > .core_init sounds like a EPF driver should initialize the core. > (But that is of course done by the EPC driver.) > > The .link_up() callback name is better, the EPF driver is informed > that the link is up. > > Perhaps we could rename .core_init to .core_up ? > > It tells the EPF drivers that the core is now up. > (And the EPF driver can configure the BARs.) > I don't disagree :) I thought about it but then decided to not extend the scope of this series further. So saved that for next series. But yeah, it is good to clean it up here itself. > > Considering that you are not changing the name of the callback, > and that it was already confusing before this patch: > Reviewed-by: Niklas Cassel Thanks! - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58094C54E41 for ; Fri, 8 Mar 2024 05:39:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YvR7zOWV; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrZjt5c5xz3dV1 for ; Fri, 8 Mar 2024 16:39:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YvR7zOWV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::62c; helo=mail-pl1-x62c.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrZj333Xdz2ysD for ; Fri, 8 Mar 2024 16:38:47 +1100 (AEDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1dcb3e6ff3fso13586915ad.2 for ; Thu, 07 Mar 2024 21:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876324; x=1710481124; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DUybYaiPJClMOkVE2KcQ/JxyjAJYL0HAMjXF/A+2etI=; b=YvR7zOWVarHLWCp9KY2GwMAQyS8zLsoXjvW/fEGskoezFnZrtMj6JEhRzyAmzkHCLJ UWc8s1m6Tzs6DVtg7iNsZkWEy4/iWLX4W9z5InUJtZUQxa4INrtFQyea4RXw9ps5A7qF ZYyEzPgaekz2eluYH4YO++3j2zdwvGCvzjghWtkcNb0xdz8oJf44IjSoE71QoOG3Yjzt yg8n/p6SUpBturmKuYO9LoDTgbg7nzb24m3Nw3IGChg35ky2DUkpMqVY6EwsgHw/iHmV xVC+RCS9fS3aboYJUhLmMSCQWxc4Ek0b3UL2lZgg1Ij8qr9WVN/3Tyq5mD0XvyHphJTM 4dLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876324; x=1710481124; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DUybYaiPJClMOkVE2KcQ/JxyjAJYL0HAMjXF/A+2etI=; b=IIsg7FEurhgHOOpytx+T2qexhKt2Sh7V1HVZz6mIznIGSDuUIeQmXJrNmE1wV7msqC lwkS8F20eCHdo4Cqtd+dpBJvKeD8Tfbfx/QlAUJ6s8sHzDlEsEDy2psWsV7CHfZrBzZn UVPIMaD2v0ysNdEP9nIXs7X5IeEg74ORSoPyh5g/J404aNG/DCSVmydraZTlnfUlgKwO LU0k1+08l0eVizQLM28BOamGS6+kJkkjdP2r+01su9axA9SXQM5B2fCzqMVxomzBPQUs AuAjiijDK8oBm9i01uYaxbSo6a0w5H/3jUQgRVxsNKaRTURPHvKrv4XF4AcXdScR4vRE ooGQ== X-Forwarded-Encrypted: i=1; AJvYcCWcVfrGb5dfmBjSRcVZKOIuQNV22gtLh8YoERckgTrxKdVh/p5fFwsV/pWGnWQ8xmi6Sl7dWv2/Qzf+xigjGFGQ85OwVhBMRpAZd1ZAFQ== X-Gm-Message-State: AOJu0YyCIg+D4NQD0JVE9RE0fQqEkTaOE4FtC6J9K5UvYIRn+lkK7w9i pctKPioYNYK9Z8nrd/H4oCJ562+dGPjwITWDlqUNbSp8MA9Gxa6Ou/taXsenXw== X-Google-Smtp-Source: AGHT+IFnxmsrp/JdPtnzlcbTNURcPyjpmM+tg6dX1wncoxt7+3e7o8Cy2Ru1ZT2zUpWAw+nYHfuG6A== X-Received: by 2002:a17:903:1249:b0:1db:4419:e925 with SMTP id u9-20020a170903124900b001db4419e925mr11913418plh.1.1709876324294; Thu, 07 Mar 2024 21:38:44 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id f11-20020a170903104b00b001db717ed294sm923036plc.120.2024.03.07.21.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:38:43 -0800 (PST) Date: Fri, 8 Mar 2024 11:08:29 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240308053829.GC3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@ lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 07, 2024 at 10:09:06PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:19PM +0530, Manivannan Sadhasivam wrote: > > "core_init_notifier" flag is set by the glue drivers requiring refclk from > > the host to complete the DWC core initialization. Also, those drivers will > > send a notification to the EPF drivers once the initialization is fully > > completed using the pci_epc_init_notify() API. Only then, the EPF drivers > > will start functioning. > > > > For the rest of the drivers generating refclk locally, EPF drivers will > > start functioning post binding with them. EPF drivers rely on the > > 'core_init_notifier' flag to differentiate between the drivers. > > Unfortunately, this creates two different flows for the EPF drivers. > > > > So to avoid that, let's get rid of the "core_init_notifier" flag and follow > > a single initialization flow for the EPF drivers. This is done by calling > > the dw_pcie_ep_init_notify() from all glue drivers after the completion of > > dw_pcie_ep_init_registers() API. This will allow all the glue drivers to > > send the notification to the EPF drivers once the initialization is fully > > completed. > > > > Only difference here is that, the drivers requiring refclk from host will > > send the notification once refclk is received, while others will send it > > during probe time itself. > > > > Reviewed-by: Frank Li > > Signed-off-by: Manivannan Sadhasivam > > --- > > You have removed the .core_init_notifier from EPC drivers, > but the callback in EPF drivers is still called .core_init. > > Yes, this was a confusing name even before this patch, but > after this patch, it is probably even worse :) > > The callback should be named from the perspective of EPF drivers IMO. > .core_init sounds like a EPF driver should initialize the core. > (But that is of course done by the EPC driver.) > > The .link_up() callback name is better, the EPF driver is informed > that the link is up. > > Perhaps we could rename .core_init to .core_up ? > > It tells the EPF drivers that the core is now up. > (And the EPF driver can configure the BARs.) > I don't disagree :) I thought about it but then decided to not extend the scope of this series further. So saved that for next series. But yeah, it is good to clean it up here itself. > > Considering that you are not changing the name of the callback, > and that it was already confusing before this patch: > Reviewed-by: Niklas Cassel Thanks! - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62539C54E41 for ; Fri, 8 Mar 2024 05:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dmbRojhCFDWWHrsQEwnLtrLIZbv5/OqtqyvrJO0YiY0=; b=dW5mWnWw2mxNI+ DmSv4SmsCUAmBADYjQa3yaA9xpYPWeSQoyqJ/qDIrHHTEIGlB07veop0vV0H4/tzNXKG7Bfi5cWA/ GkoAP1ILp2K2NtflrXLhUy8hSv88ags/0Y3M9rTvN8bBa4E3BMvGEWhUSDNce5AkBYSeBWB1vACm7 ewSy8T3lcfVZ4ykQbqkkWUsTs5wHGy4odnvcscLaAdeXIoFmWiUB4AENhotJ8e4K+9rRUvO5+VNfg 0jhu/r9jJ75UUH/pmBJFG2R+b7K19ejBUUfYnFmGyZlZ6fOnN6MIEE/nTinChcWw4AfPQALixg2Pg 4Vh0CFIzY/MGQ3iFtzIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riSwT-00000007trQ-0ZIg; Fri, 08 Mar 2024 05:38:49 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riSwP-00000007tpY-2PxA for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 05:38:46 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1dcb3e6ff3fso13586955ad.2 for ; Thu, 07 Mar 2024 21:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876324; x=1710481124; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DUybYaiPJClMOkVE2KcQ/JxyjAJYL0HAMjXF/A+2etI=; b=zTZV1pTFb/hcI/jNd411aaeL50ho4lGOCTW+gJ+C5P37o7fgg1TpezclBFd5Hf/ycT kMfoahRAekJyTP+ILiHoOyEn30O5Yi+omtcj0AcGyyTbxUNLFjTiQUTBNQGVOcFAUX55 RMAj/q4ZhSBKGS1zTeLXEvPAmvGAMX++k51KWWtmVzPg5lWNMIYDrsx8G4CrC72PRnfj bjD1HQU6tMXNiMQZmtN909tCjVctofbgB8W8vy/h9+gos8ZH0QRc9JkoszHdLdTdqBSZ jetgF8p9wPz9pH2v0yF2fLmWMa+4C0hCyrIARAeyFnpnmDkzkwE9G+ZI6RJKfvNr74na lD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876324; x=1710481124; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DUybYaiPJClMOkVE2KcQ/JxyjAJYL0HAMjXF/A+2etI=; b=hmzAO2I1rZDc6Vw4nyThex0wsE7eHV8SEjyR3UnfexdZLQUn3jCte2r/C8eMlapyc6 VxcTvROYJV8Bhd6/bM39Hkfliv2A9dytyAYPjOg7n5tmFaZZUs/Oj7XJSqirJNbGx6df cJLSqfMcYLdU0pvW9i9OlS8zV9B5EWspd7vb1oIxPb2YGvI5FExkOvbpHX/7cMNrVoM5 4ju+yPzugDS5d15D9f2wBMjp2AsOmeCg+D7FAoQJgWRQSHvvVdt+GqyZ4voWfTrAstD0 YjG9pxUDOnsz0cIvKghqMWWTQ65u7suyvy/W2lrOMaUTXGGhQ4iS/B7nTNhaKf5A22aD E9bQ== X-Forwarded-Encrypted: i=1; AJvYcCUW08rStnOPffhPRAbuqWmUfFeaBO0KnuQJlUW6G8Cb0gV6U8Cna5wOA6E7W+uBEcw9jOVXTJpy9T5nza4/uBM82IIfoeenTFSwiMBISyjXYEQacbk= X-Gm-Message-State: AOJu0Ywao623jbbWoaEjbq6KyhbsBvONoZRZStUhN5+id6pVUu0AeQL+ 411qG4MBuIoZxOoTM9CBvh6Ov9PpIP7sdQxLBojSL6qqRccuI34z8ON/WUMHDA== X-Google-Smtp-Source: AGHT+IFnxmsrp/JdPtnzlcbTNURcPyjpmM+tg6dX1wncoxt7+3e7o8Cy2Ru1ZT2zUpWAw+nYHfuG6A== X-Received: by 2002:a17:903:1249:b0:1db:4419:e925 with SMTP id u9-20020a170903124900b001db4419e925mr11913418plh.1.1709876324294; Thu, 07 Mar 2024 21:38:44 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id f11-20020a170903104b00b001db717ed294sm923036plc.120.2024.03.07.21.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:38:43 -0800 (PST) Date: Fri, 8 Mar 2024 11:08:29 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240308053829.GC3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_213845_642953_FC6B19D6 X-CRM114-Status: GOOD ( 30.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMDcsIDIwMjQgYXQgMTA6MDk6MDZQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwMjo1MjoxOVBNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiAiY29yZV9pbml0X25vdGlmaWVyIiBmbGFnIGlzIHNl dCBieSB0aGUgZ2x1ZSBkcml2ZXJzIHJlcXVpcmluZyByZWZjbGsgZnJvbQo+ID4gdGhlIGhvc3Qg dG8gY29tcGxldGUgdGhlIERXQyBjb3JlIGluaXRpYWxpemF0aW9uLiBBbHNvLCB0aG9zZSBkcml2 ZXJzIHdpbGwKPiA+IHNlbmQgYSBub3RpZmljYXRpb24gdG8gdGhlIEVQRiBkcml2ZXJzIG9uY2Ug dGhlIGluaXRpYWxpemF0aW9uIGlzIGZ1bGx5Cj4gPiBjb21wbGV0ZWQgdXNpbmcgdGhlIHBjaV9l cGNfaW5pdF9ub3RpZnkoKSBBUEkuIE9ubHkgdGhlbiwgdGhlIEVQRiBkcml2ZXJzCj4gPiB3aWxs IHN0YXJ0IGZ1bmN0aW9uaW5nLgo+ID4gCj4gPiBGb3IgdGhlIHJlc3Qgb2YgdGhlIGRyaXZlcnMg Z2VuZXJhdGluZyByZWZjbGsgbG9jYWxseSwgRVBGIGRyaXZlcnMgd2lsbAo+ID4gc3RhcnQgZnVu Y3Rpb25pbmcgcG9zdCBiaW5kaW5nIHdpdGggdGhlbS4gRVBGIGRyaXZlcnMgcmVseSBvbiB0aGUK PiA+ICdjb3JlX2luaXRfbm90aWZpZXInIGZsYWcgdG8gZGlmZmVyZW50aWF0ZSBiZXR3ZWVuIHRo ZSBkcml2ZXJzLgo+ID4gVW5mb3J0dW5hdGVseSwgdGhpcyBjcmVhdGVzIHR3byBkaWZmZXJlbnQg Zmxvd3MgZm9yIHRoZSBFUEYgZHJpdmVycy4KPiA+IAo+ID4gU28gdG8gYXZvaWQgdGhhdCwgbGV0 J3MgZ2V0IHJpZCBvZiB0aGUgImNvcmVfaW5pdF9ub3RpZmllciIgZmxhZyBhbmQgZm9sbG93Cj4g PiBhIHNpbmdsZSBpbml0aWFsaXphdGlvbiBmbG93IGZvciB0aGUgRVBGIGRyaXZlcnMuIFRoaXMg aXMgZG9uZSBieSBjYWxsaW5nCj4gPiB0aGUgZHdfcGNpZV9lcF9pbml0X25vdGlmeSgpIGZyb20g YWxsIGdsdWUgZHJpdmVycyBhZnRlciB0aGUgY29tcGxldGlvbiBvZgo+ID4gZHdfcGNpZV9lcF9p bml0X3JlZ2lzdGVycygpIEFQSS4gVGhpcyB3aWxsIGFsbG93IGFsbCB0aGUgZ2x1ZSBkcml2ZXJz IHRvCj4gPiBzZW5kIHRoZSBub3RpZmljYXRpb24gdG8gdGhlIEVQRiBkcml2ZXJzIG9uY2UgdGhl IGluaXRpYWxpemF0aW9uIGlzIGZ1bGx5Cj4gPiBjb21wbGV0ZWQuCj4gPiAKPiA+IE9ubHkgZGlm ZmVyZW5jZSBoZXJlIGlzIHRoYXQsIHRoZSBkcml2ZXJzIHJlcXVpcmluZyByZWZjbGsgZnJvbSBo b3N0IHdpbGwKPiA+IHNlbmQgdGhlIG5vdGlmaWNhdGlvbiBvbmNlIHJlZmNsayBpcyByZWNlaXZl ZCwgd2hpbGUgb3RoZXJzIHdpbGwgc2VuZCBpdAo+ID4gZHVyaW5nIHByb2JlIHRpbWUgaXRzZWxm Lgo+ID4gCj4gPiBSZXZpZXdlZC1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gPiBT aWduZWQtb2ZmLWJ5OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZh bUBsaW5hcm8ub3JnPgo+ID4gLS0tCj4gCj4gWW91IGhhdmUgcmVtb3ZlZCB0aGUgLmNvcmVfaW5p dF9ub3RpZmllciBmcm9tIEVQQyBkcml2ZXJzLAo+IGJ1dCB0aGUgY2FsbGJhY2sgaW4gRVBGIGRy aXZlcnMgaXMgc3RpbGwgY2FsbGVkIC5jb3JlX2luaXQuCj4gCj4gWWVzLCB0aGlzIHdhcyBhIGNv bmZ1c2luZyBuYW1lIGV2ZW4gYmVmb3JlIHRoaXMgcGF0Y2gsIGJ1dAo+IGFmdGVyIHRoaXMgcGF0 Y2gsIGl0IGlzIHByb2JhYmx5IGV2ZW4gd29yc2UgOikKPiAKPiBUaGUgY2FsbGJhY2sgc2hvdWxk IGJlIG5hbWVkIGZyb20gdGhlIHBlcnNwZWN0aXZlIG9mIEVQRiBkcml2ZXJzIElNTy4KPiAuY29y ZV9pbml0IHNvdW5kcyBsaWtlIGEgRVBGIGRyaXZlciBzaG91bGQgaW5pdGlhbGl6ZSB0aGUgY29y ZS4KPiAoQnV0IHRoYXQgaXMgb2YgY291cnNlIGRvbmUgYnkgdGhlIEVQQyBkcml2ZXIuKQo+IAo+ IFRoZSAubGlua191cCgpIGNhbGxiYWNrIG5hbWUgaXMgYmV0dGVyLCB0aGUgRVBGIGRyaXZlciBp cyBpbmZvcm1lZAo+IHRoYXQgdGhlIGxpbmsgaXMgdXAuCj4gCj4gUGVyaGFwcyB3ZSBjb3VsZCBy ZW5hbWUgLmNvcmVfaW5pdCB0byAuY29yZV91cCA/Cj4gCj4gSXQgdGVsbHMgdGhlIEVQRiBkcml2 ZXJzIHRoYXQgdGhlIGNvcmUgaXMgbm93IHVwLgo+IChBbmQgdGhlIEVQRiBkcml2ZXIgY2FuIGNv bmZpZ3VyZSB0aGUgQkFScy4pCj4gCgpJIGRvbid0IGRpc2FncmVlIDopIEkgdGhvdWdodCBhYm91 dCBpdCBidXQgdGhlbiBkZWNpZGVkIHRvIG5vdCBleHRlbmQgdGhlIHNjb3BlCm9mIHRoaXMgc2Vy aWVzIGZ1cnRoZXIuIFNvIHNhdmVkIHRoYXQgZm9yIG5leHQgc2VyaWVzLgoKQnV0IHllYWgsIGl0 IGlzIGdvb2QgdG8gY2xlYW4gaXQgdXAgaGVyZSBpdHNlbGYuCgo+IAo+IENvbnNpZGVyaW5nIHRo YXQgeW91IGFyZSBub3QgY2hhbmdpbmcgdGhlIG5hbWUgb2YgdGhlIGNhbGxiYWNrLAo+IGFuZCB0 aGF0IGl0IHdhcyBhbHJlYWR5IGNvbmZ1c2luZyBiZWZvcmUgdGhpcyBwYXRjaDoKPiBSZXZpZXdl ZC1ieTogTmlrbGFzIENhc3NlbCA8Y2Fzc2VsQGtlcm5lbC5vcmc+CgpUaGFua3MhCgotIE1hbmkK Ci0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+N CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==