From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DBA52E859 for ; Fri, 8 Mar 2024 05:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709876643; cv=none; b=KyaYoXFn6ih5T7Xn0AtxbqI0R0UejW4OEIBkl1PRENi+vDbdx6FTFlhQx+va6aZBbgXUjaay7WLMTLmwX6s4vWBSQExuyBg4t9H3x9zUg66A9RPU14kpOaAiqdBwTBQZrawKYbeOqUvZvw4+RfOhun0CzpNTX3C6xkMVRJtHEWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709876643; c=relaxed/simple; bh=l8mRvqhe3rCJcL5EfXN0mb564Hh0Pb6/VhQn5bYxOzY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HVHa5oYMwV+PFfRuqmCcVzUir8RnabP5Lj+T1pl11HEwRfDMkjgVTXYDasJiY9qxbFYjogM6CziEhJjJkLn41lsPRSRUl3Fe0jpT2Uyar2s1HjZgrMFogs3gmVVHem9S7lp7eXHpsFxnaF3pRRVSBo/Ywkdc+cvye2O/fRMhE8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zd+u7b/x; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zd+u7b/x" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e64cdf08e3so373852b3a.3 for ; Thu, 07 Mar 2024 21:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876642; x=1710481442; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pP3WC4SyW/Vzti9hv7dYhKLJSQ5hGnrzQR/QY37QH6U=; b=zd+u7b/xgUU80tS+jXojilCTJsZNAWM0d/l1V2BF7G3oMIX/oHjrnKgWd2Y5dPETnX CmipROa7r+nU+Fdg1Uap2Jk6f44e/qPEA0R63CrgAKhltZMrOk0TR+adtl/8hl9t98K5 35BOmSiUcEN61VdQAxeczgEZjLHCOhxH6Ccu6EPqDfm3VGfhnFetaA3kZxaquwgh3RG5 oRVJLoynmllmSaMbUmqjusGc2fsoja+oa4/hwz7soyBV61zju8MaIGwePXOnI2G3AS/W G2qF3pYugdabM8Os35OITh5uSuGb9mC5zvO4BqdxiVUbi4VWE3RdA4hbQV1wa/yr6sHW Yicg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876642; x=1710481442; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pP3WC4SyW/Vzti9hv7dYhKLJSQ5hGnrzQR/QY37QH6U=; b=TLXb/YAHxbjdNEZBIBmdOuRxjwJLHUYU4Dsy2UHl6QDRx1WQ1/qFT4d4TsfKxW3su+ ADPT8bIccCNWnm1CLxLVS9LEGyZAyWLPtfFFPenLeoumkqYj2of1okGlcQrfkNd8pe1A 9A6pHcFwb95nyvSuxrUuohCXzNDwlFgePoON+SazLc4r6pcQkDjz7rV+e4044Rf5KdII 1SS/ftuYtjdOh4AnexxMM+oVjY6hpwowJ5+UYjfd+gR0WHbs8iUiJVaTUG1/WLRDnO9x 2Obul8r1jtagmyPdqsl7CTZswpk/x1ML7ptyUTyhDDs8/dKFetZ+M2Z7bCJKuroN2fOR pStA== X-Forwarded-Encrypted: i=1; AJvYcCWa5F0QCeicP02J/DQ1lmz0S9wgXo9y1JCdTZNYzuF8xoSnNyT2WGKgQ7lw3XMhnd3lnRWsmGtix6nTZTzPowg9wC3f7GvrP3XAMKBEgA== X-Gm-Message-State: AOJu0YxT3ZhGqYtETqZ+q+yTjC5dsxOI1mq8SjW7NBE6PoM31+x33N9Y ruSC0jeZMouZPZuihHPwP1XC9FvNofmsZHMAMPFEeCn5KkrS3zXVopsPFkyLtA== X-Google-Smtp-Source: AGHT+IF4OBcYmj84dqXR/j7tUWistQOyDNgAnoteok0JgpLNMa/4XKXGz0eVlhJR+Ieyw9pe6cuoUw== X-Received: by 2002:a05:6a00:815:b0:6e5:9a92:f99b with SMTP id m21-20020a056a00081500b006e59a92f99bmr19446806pfk.16.1709876641435; Thu, 07 Mar 2024 21:44:01 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id e3-20020aa79803000000b006e5667793d4sm13354830pfl.66.2024.03.07.21.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:44:01 -0800 (PST) Date: Fri, 8 Mar 2024 11:13:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240308054347.GE3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-10-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 07, 2024 at 10:58:12PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:22PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Reviewed-by: Frank Li > > Signed-off-by: Manivannan Sadhasivam > > --- > > For the functions that you added in this series, e.g. > dw_pcie_ep_cleanup(), dw_pcie_ep_init_non_sticky_registers(), > and dw_pcie_ep_linkdown(), I think that it would have been > better if you actually added the kdoc in the same commit that > added the respective function. > > > For the existing functions that did not have a kdoc, I think > it would have been better if you fixed this as patch 1/10 in > this series. (Or 2/10, in case you keep the Fixes tag for the > "PCI: dwc: ep: Fix DBI access failure for drivers requiring > refclk from host" patch.) > > Yes, I know that you rename some of these functions that > lacked kdoc later in the series, but the whole kdoc description > would be the same, the kdoc parameters would be the same, and the > kdoc return value would be the same. > > If you later rename a function, you would only need to change > the kdoc function name (in addition to the function declaration > itself). > Makes sense! Will change it. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8C45C5475B for ; Fri, 8 Mar 2024 05:44:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=pfV34Dsv; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrZqx2vCmz3vYX for ; Fri, 8 Mar 2024 16:44:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=pfV34Dsv; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::431; helo=mail-pf1-x431.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrZq76kN2z3bPV for ; Fri, 8 Mar 2024 16:44:03 +1100 (AEDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6e5d7f1f25fso381631b3a.0 for ; Thu, 07 Mar 2024 21:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876642; x=1710481442; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pP3WC4SyW/Vzti9hv7dYhKLJSQ5hGnrzQR/QY37QH6U=; b=pfV34DsvmAEbMwbrwjD0VO8Bplu87jRjEAWtJ4KL/HLQdrBHx0s8UO8hiUuVx88Xbf /jlDv0dGYVI5j4gp30MVtZ9/K3LwzosGMbhtM4ncpcUd3Lvw1pWunCd6YC7K9dGp4BMb IhzmI/Ejq+IO2nN/oTECuwl15VbXNpjWD93DoqeFbUJo0cVYygnWRVEzRNgE3jXyN25u 0ZzELRkqdKwaklRmLBFEdH+OlKf75n/zK0J0HpAsGWjiikRn1ClZgctOetFRCxb1mb9h 2bIHLypseGk1C/zl/CLuD41bs16DkQndEtfBYeLnZgoulNkVUEpzbeh/TtMqAitg2Wc5 ntRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876642; x=1710481442; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pP3WC4SyW/Vzti9hv7dYhKLJSQ5hGnrzQR/QY37QH6U=; b=iBHZXz5mxiM1CKWkuRc7F0v5IE6LJMp2NV/923sfEt7jAheF2SCjIVQtWKRfs6zDX9 aJ7jn1BBgsLC/bZ6OGnK53aE8wgeg6o1c0P87Mm/Q+Qby0xvn/PJCPBn/rsphYFn3pBi 4a5YWackN0sCiHc1EJv+WV+ByHMwAgXFVGyqNJvWD5AzO0J7n7jSQXoDbz8K3lA6hbLa +GPUfVfTTjsj2zNeXRojdaJul5Bq/31DGnpVNsMXWwMODNy+/oAfmZ7CnZXxk70+Wctx yPRW9dzAHuXc4cDm00hgquE20ZUN0F4ldmu/1uxThJqPWQZHCitJYcZdPAI9ynJUvfUQ gq9w== X-Forwarded-Encrypted: i=1; AJvYcCUpX3uIynlsGr9vLyBv7NkLZKrztb0YOojMBMJGW1kPCTqQsEQq/GeFHUIBszpqldLJMGLv5BWl5m1iX4WGDEtVJVWZzPccAVfCqxx2zQ== X-Gm-Message-State: AOJu0YzukWJjSYh9LPiYq0SFuWtzbF9IKPXVBPTnGNdSOgF+VpKSCNWw hPXYYdN6CD+JP2xl8+JP4cGMTcq1oymgpWQ6t76B0Ro9o4CaODZ/FGXuz6IG/w== X-Google-Smtp-Source: AGHT+IF4OBcYmj84dqXR/j7tUWistQOyDNgAnoteok0JgpLNMa/4XKXGz0eVlhJR+Ieyw9pe6cuoUw== X-Received: by 2002:a05:6a00:815:b0:6e5:9a92:f99b with SMTP id m21-20020a056a00081500b006e59a92f99bmr19446806pfk.16.1709876641435; Thu, 07 Mar 2024 21:44:01 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id e3-20020aa79803000000b006e5667793d4sm13354830pfl.66.2024.03.07.21.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:44:01 -0800 (PST) Date: Fri, 8 Mar 2024 11:13:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240308054347.GE3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-10-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@ lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 07, 2024 at 10:58:12PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:22PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Reviewed-by: Frank Li > > Signed-off-by: Manivannan Sadhasivam > > --- > > For the functions that you added in this series, e.g. > dw_pcie_ep_cleanup(), dw_pcie_ep_init_non_sticky_registers(), > and dw_pcie_ep_linkdown(), I think that it would have been > better if you actually added the kdoc in the same commit that > added the respective function. > > > For the existing functions that did not have a kdoc, I think > it would have been better if you fixed this as patch 1/10 in > this series. (Or 2/10, in case you keep the Fixes tag for the > "PCI: dwc: ep: Fix DBI access failure for drivers requiring > refclk from host" patch.) > > Yes, I know that you rename some of these functions that > lacked kdoc later in the series, but the whole kdoc description > would be the same, the kdoc parameters would be the same, and the > kdoc return value would be the same. > > If you later rename a function, you would only need to change > the kdoc function name (in addition to the function declaration > itself). > Makes sense! Will change it. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1017C5475B for ; Fri, 8 Mar 2024 05:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hpuelrah8nqlJQSt0CaNqf1YJmBwJy1iLgXjthUV0cs=; b=pppJtUQ3ExTtyk 0Ko4ACEiSRgcmJpDJ/djDDYU3omhK/mIwdsIdFImTSEpeW436Nl2eF23x7eyM/YwKUl7GDKGaLA3u QgV961GfrQm5MlhExWbk5u9iTp8PXdMqWBTO1FIpRXVi2EjDAmmZVebnZpMAhzr98RQ7ga39nwGkI tLKfGDHsZiCfuXZja/AFDHSu23FO3HdZ+sZgRNI85t4421Q2rnQpJr3N0sRUEsxbUa8lPVYUtYxEX O/fiw6zw6Qo/k1W1pDniOqO+8XAx2tafbIfv0xMcMwGIrKN43/VJ7ZdGBJ+x9Atw3hQb75lT0REQv Mv3iuJLkbTCyp6Uj5lpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riT1a-00000007usX-0xmL; Fri, 08 Mar 2024 05:44:06 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riT1X-00000007urX-0Lf4 for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 05:44:05 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6e5d7f1f25fso381635b3a.0 for ; Thu, 07 Mar 2024 21:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709876642; x=1710481442; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pP3WC4SyW/Vzti9hv7dYhKLJSQ5hGnrzQR/QY37QH6U=; b=DvdlQXyvKyxaexjlZUIXQRmbSOlup+AvHOPRxTq+SavNNSyNcFoc3oYjWm70Jq3swz z4946fAOTOusflid70Ix67HJeunTwR4p4dB0Epk5uYPy+puV4/IIQaKFjHum/mb/LN8s W40wnk7T2RwnKrOQjkY64mcHpyggLXdHwaUW+R+aH/CWyaQfr0mY1OffJ2HhVjyftt4y nAuS148OKpyuKq/MgQCHnwdC68BcP1tXBPd98aGRcwbgrLjjdvJyQxQzEnjiQD36xcsY sDkc+8IhKFlTMOH/+3o/onfuswCyLYnABcW9HFxwu+SA211wvBP6u0GdjAAaDqYnU0mw I4ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709876642; x=1710481442; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pP3WC4SyW/Vzti9hv7dYhKLJSQ5hGnrzQR/QY37QH6U=; b=f85dsC/2U4cKX9n99QcbamfzFJHjTafkjm0EW1pk/TqWPpRrClbNS0dI/uhgzFusl2 Ot0O7MQ9efU1onpKAZyVmqHJtD8jTpNiwmndT615TdCllL922zfOv8mYt3pfmuKXLlmB Jl0h3asM2HkSHdqLZlSZhXjcsFXhv4VjmRlmiRqBApyAgbpGv9uMHaXO5Vf/mFC7rB6I 5A5agv7S2IB57m2xDwABw3oi1X3EDH/suu7IkGEHVJZhiiGmoViq5Br/rkf1CRoEMDp1 ZWK4MC/+wchxQ0E6fPSdtOTEi5dIkSwlgzHjHwIWhvE/XEk/r44esOx+AzvJt2tPHeM1 K6sQ== X-Forwarded-Encrypted: i=1; AJvYcCWYG2+otthjTvRkB5a8BlfsmXE+2wPDayHK6U3OoTL7l1xVYNQ4LUvh5fp1vVZ0Yqhp/6BkOcJucvrlE5s+dLNFZxERL8VX1U6iJ0Gkuv9G60VOQME= X-Gm-Message-State: AOJu0YzZDlbJI7GtJVh5o7fNFa3b0++ietDq6QDO0svDRmJD2tRv0bvS JV0FfT0GotxpOoI33Wz7fk3ZkZrW2B6jjMk1OnxvcWLMED2zjInJkeXrADvSaQ== X-Google-Smtp-Source: AGHT+IF4OBcYmj84dqXR/j7tUWistQOyDNgAnoteok0JgpLNMa/4XKXGz0eVlhJR+Ieyw9pe6cuoUw== X-Received: by 2002:a05:6a00:815:b0:6e5:9a92:f99b with SMTP id m21-20020a056a00081500b006e59a92f99bmr19446806pfk.16.1709876641435; Thu, 07 Mar 2024 21:44:01 -0800 (PST) Received: from thinkpad ([117.217.178.39]) by smtp.gmail.com with ESMTPSA id e3-20020aa79803000000b006e5667793d4sm13354830pfl.66.2024.03.07.21.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 21:44:01 -0800 (PST) Date: Fri, 8 Mar 2024 11:13:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240308054347.GE3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-10-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_214403_449350_33F61F8A X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMDcsIDIwMjQgYXQgMTA6NTg6MTJQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwMjo1MjoyMlBNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiBBbGwgb2YgdGhlIEFQSXMgYXJlIG1pc3NpbmcgdGhl IEtlcm5lbC1kb2MgY29tbWVudHMuIEhlbmNlLCBhZGQgdGhlbS4KPiA+IAo+ID4gUmV2aWV3ZWQt Ynk6IEZyYW5rIExpIDxGcmFuay5MaUBueHAuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogTWFuaXZh bm5hbiBTYWRoYXNpdmFtIDxtYW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4KPiA+IC0t LQo+IAo+IEZvciB0aGUgZnVuY3Rpb25zIHRoYXQgeW91IGFkZGVkIGluIHRoaXMgc2VyaWVzLCBl LmcuCj4gZHdfcGNpZV9lcF9jbGVhbnVwKCksIGR3X3BjaWVfZXBfaW5pdF9ub25fc3RpY2t5X3Jl Z2lzdGVycygpLAo+IGFuZCBkd19wY2llX2VwX2xpbmtkb3duKCksIEkgdGhpbmsgdGhhdCBpdCB3 b3VsZCBoYXZlIGJlZW4KPiBiZXR0ZXIgaWYgeW91IGFjdHVhbGx5IGFkZGVkIHRoZSBrZG9jIGlu IHRoZSBzYW1lIGNvbW1pdCB0aGF0Cj4gYWRkZWQgdGhlIHJlc3BlY3RpdmUgZnVuY3Rpb24uCj4g Cj4gCj4gRm9yIHRoZSBleGlzdGluZyBmdW5jdGlvbnMgdGhhdCBkaWQgbm90IGhhdmUgYSBrZG9j LCBJIHRoaW5rCj4gaXQgd291bGQgaGF2ZSBiZWVuIGJldHRlciBpZiB5b3UgZml4ZWQgdGhpcyBh cyBwYXRjaCAxLzEwIGluCj4gdGhpcyBzZXJpZXMuIChPciAyLzEwLCBpbiBjYXNlIHlvdSBrZWVw IHRoZSBGaXhlcyB0YWcgZm9yIHRoZQo+ICJQQ0k6IGR3YzogZXA6IEZpeCBEQkkgYWNjZXNzIGZh aWx1cmUgZm9yIGRyaXZlcnMgcmVxdWlyaW5nCj4gcmVmY2xrIGZyb20gaG9zdCIgcGF0Y2guKQo+ IAo+IFllcywgSSBrbm93IHRoYXQgeW91IHJlbmFtZSBzb21lIG9mIHRoZXNlIGZ1bmN0aW9ucyB0 aGF0Cj4gbGFja2VkIGtkb2MgbGF0ZXIgaW4gdGhlIHNlcmllcywgYnV0IHRoZSB3aG9sZSBrZG9j IGRlc2NyaXB0aW9uCj4gd291bGQgYmUgdGhlIHNhbWUsIHRoZSBrZG9jIHBhcmFtZXRlcnMgd291 bGQgYmUgdGhlIHNhbWUsIGFuZCB0aGUKPiBrZG9jIHJldHVybiB2YWx1ZSB3b3VsZCBiZSB0aGUg c2FtZS4KPiAKPiBJZiB5b3UgbGF0ZXIgcmVuYW1lIGEgZnVuY3Rpb24sIHlvdSB3b3VsZCBvbmx5 IG5lZWQgdG8gY2hhbmdlCj4gdGhlIGtkb2MgZnVuY3Rpb24gbmFtZSAoaW4gYWRkaXRpb24gdG8g dGhlIGZ1bmN0aW9uIGRlY2xhcmF0aW9uCj4gaXRzZWxmKS4KPiAKCk1ha2VzIHNlbnNlISBXaWxs IGNoYW5nZSBpdC4KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprg rqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK