From: Jakub Kicinski <kuba@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Ching-Te Ku <ku920601@realtek.com>,
Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: pull-request: wireless-next-2024-03-08
Date: Fri, 8 Mar 2024 08:58:39 -0800 [thread overview]
Message-ID: <20240308085839.47d8cb37@kernel.org> (raw)
In-Reply-To: <87wmqc4qik.fsf@kernel.org>
On Fri, 08 Mar 2024 18:50:11 +0200 Kalle Valo wrote:
> > coccicheck flags:
> >
> > drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else)
>
> Thanks, but how did you find this? I'm asking just to understand your process, at
> least the pull request shows all green:
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20240308100429.B8EA2C433F1@smtp.kernel.org/
>
> We don't run coccicheck so it's not surprising there are new warnings.
We have another bunch of tests now which run on all outstanding patches
every 3 hours. selftests for example. We need to aggregate because
there's too much code getting posted. One of the "tests" we run is
make coccicheck.
https://github.com/kuba-moo/nipa/blob/master/contest/tests/cocci-check.sh
it's supposed to report back to patchwork as "contest", but
the reporting is not 100% accurate I need to fix it :|
I look here instead: https://netdev.bots.linux.dev/status.html
next prev parent reply other threads:[~2024-03-08 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 10:04 pull-request: wireless-next-2024-03-08 Kalle Valo
2024-03-08 15:45 ` Jakub Kicinski
2024-03-08 16:50 ` Kalle Valo
2024-03-08 16:58 ` Jakub Kicinski [this message]
2024-03-09 0:19 ` Ping-Ke Shih
2024-03-08 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308085839.47d8cb37@kernel.org \
--to=kuba@kernel.org \
--cc=ku920601@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.