From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1DBA3BBDE for ; Fri, 8 Mar 2024 09:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891063; cv=none; b=qRz7Kpwh7FCh3iX4L4KMJl32S9UEsx5nuNDFCH7zLPU0Yl+DUnktedtuqXiB6f7eokei7T9Uj62+oYDlCBY/Oqwx01I/NEYG3CA3tJ//hYNZexfaScwoybXT1LEeitpnvj4/kXp9vH+3DTyBxAiQBHFnUwMFoBi2eaR/8KThRpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891063; c=relaxed/simple; bh=0HEUZNyW463A0kgIICyd/mFsEgweSIiAp5zW9wvwQAQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=orJRfOUiomxU3qx2ZUaF7ka8Le5QQoxM7HSwoYpvPLfTJOWHoBGWpg4bKswOCYP8FwkgOq6KwVWu6ARTqLeWTPwB6r/55ZDQLsTWe2x8TE36UmDlFY3Z1GUmQLL6BX5jRNEzUrH9gh54fFZ3IS4Vdm5cFKuoJpdCFaXproeZ/k0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=scNnxe+e; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="scNnxe+e" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e4d48a5823so499644b3a.1 for ; Fri, 08 Mar 2024 01:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891060; x=1710495860; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cdMdoK0AVaUo9V+wul4fyguoktaqDabkYBWscL2ezsE=; b=scNnxe+eH0gJxpLD0BEvB7iGN2bbDV3x3kfx59zaTZPi8My/LQzAyQCdqZI3PhYc1J 6lQEh9CPLTemfcQpPYXAqYpSOnV42pha+24/QSs8Rv5XyvF1Jl7Xy58mXLEN0lspq8mw nzB9N5d7NoGM92r2JY6lMAMKdXznKYIRMjkZZ9l5cWzw5ZiqRbp1awaJ+9FdScEP/MvU 1x28YZpIxM8HZvGeyF42lUoRbJ2ZQUJrWQgYE8FvywAEZ3cSUuhhBo7oqziYapoD1FW3 FSb0ut2COKfFVrLeAzgf2kuJAj0PWN0jL8IPwMagx/fET4usxx4CBS+LbPkoTFM9sJYJ FHsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891060; x=1710495860; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdMdoK0AVaUo9V+wul4fyguoktaqDabkYBWscL2ezsE=; b=afklZ9+rJQitI9u15oOvbEF8+Jk5tCV3VJmMJaVdemTerS/hoGCDcUzqe5QQ+7zlRe eEXJQ5a0tZjDtzJbYc9UAldu5+FCFScHUS3S3+ZvxpMPyoxX5dLL+g47yOVnHvFCGLNU b7ZNQZi6sYPPufNWPELmS6BWd8IRFSLCXz/GNirZBmV5HZRjFPsnWkOh0MKubCxQyLut 7P/gcwsWJkh6HMAD6gfTr9nH4BTcM5l6cRmUK/Vd5w/mZSZD5gdE9ilI+9iATqYj4fU1 hSQgD9jB7Hg5msDBv3Lw0zLcjFNa//xPToGOhC10Lf1iq6UibEGqV3Fb5wV0661Krw2z fdVA== X-Forwarded-Encrypted: i=1; AJvYcCXlDDxz3978V0F/HsGXELYFSo6I7fc2CsNOVUln0obkFhrF7iUe+C2fCj9uEyXCOSSkUxOYasvkRFJpl76sMGRnXMrLA0S8QYXiXpgEIA== X-Gm-Message-State: AOJu0YydobtMqAjw1Sz3EZk3K0DcAeIFVgR3gr2U/AikfoY0/z4MX2Gq 8D5DOgV0WUL+9I8VDO9TQ8DnD0+n3QdOV/xIdYimxusbLKyGLZ8eGltvA01kKQ== X-Google-Smtp-Source: AGHT+IFPbL54AXHQXB9MkS0qJtzg8o8q9yBGg3I5qPe5e95N0vMgv1+cPBqKR5EsKnzhBrhB5Hgmww== X-Received: by 2002:a05:6a20:4284:b0:1a1:6b04:9f2e with SMTP id o4-20020a056a20428400b001a16b049f2emr7419660pzj.9.1709891060050; Fri, 08 Mar 2024 01:44:20 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id b1-20020aa78101000000b006e6350986a8sm6625169pfi.215.2024.03.08.01.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:44:19 -0800 (PST) Date: Fri, 8 Mar 2024 15:14:04 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240308094404.GF3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> <20240308053829.GC3789@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 08, 2024 at 09:48:07AM +0100, Niklas Cassel wrote: > On Fri, Mar 08, 2024 at 11:08:29AM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 10:09:06PM +0100, Niklas Cassel wrote: > > > On Mon, Mar 04, 2024 at 02:52:19PM +0530, Manivannan Sadhasivam wrote: > > > > "core_init_notifier" flag is set by the glue drivers requiring refclk from > > > > the host to complete the DWC core initialization. Also, those drivers will > > > > send a notification to the EPF drivers once the initialization is fully > > > > completed using the pci_epc_init_notify() API. Only then, the EPF drivers > > > > will start functioning. > > > > > > > > For the rest of the drivers generating refclk locally, EPF drivers will > > > > start functioning post binding with them. EPF drivers rely on the > > > > 'core_init_notifier' flag to differentiate between the drivers. > > > > Unfortunately, this creates two different flows for the EPF drivers. > > > > > > > > So to avoid that, let's get rid of the "core_init_notifier" flag and follow > > > > a single initialization flow for the EPF drivers. This is done by calling > > > > the dw_pcie_ep_init_notify() from all glue drivers after the completion of > > > > dw_pcie_ep_init_registers() API. This will allow all the glue drivers to > > > > send the notification to the EPF drivers once the initialization is fully > > > > completed. > > > > > > > > Only difference here is that, the drivers requiring refclk from host will > > > > send the notification once refclk is received, while others will send it > > > > during probe time itself. > > > > > > > > Reviewed-by: Frank Li > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > > > You have removed the .core_init_notifier from EPC drivers, > > > but the callback in EPF drivers is still called .core_init. > > > > > > Yes, this was a confusing name even before this patch, but > > > after this patch, it is probably even worse :) > > > > > > The callback should be named from the perspective of EPF drivers IMO. > > > .core_init sounds like a EPF driver should initialize the core. > > > (But that is of course done by the EPC driver.) > > > > > > The .link_up() callback name is better, the EPF driver is informed > > > that the link is up. > > > > > > Perhaps we could rename .core_init to .core_up ? > > > > > > It tells the EPF drivers that the core is now up. > > > (And the EPF driver can configure the BARs.) > > > > > > > I don't disagree :) I thought about it but then decided to not extend the scope > > of this series further. So saved that for next series. > > > > But yeah, it is good to clean it up here itself. > > If you intend to create a .core_deinit or .core_down (or whatever name > you decide on), perhaps it is better to leave this cleanup to be part > of that same series? > I already added a patch. So let's do it here itself :) - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32A4FC54E4A for ; Fri, 8 Mar 2024 09:45:06 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZXIVK6kO; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Trh9D6LJPz3vYF for ; Fri, 8 Mar 2024 20:45:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZXIVK6kO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::436; helo=mail-pf1-x436.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Trh8R6BDcz3bPV for ; Fri, 8 Mar 2024 20:44:22 +1100 (AEDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e63e9abf6aso515077b3a.2 for ; Fri, 08 Mar 2024 01:44:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891060; x=1710495860; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cdMdoK0AVaUo9V+wul4fyguoktaqDabkYBWscL2ezsE=; b=ZXIVK6kOATpP5d3ht7zS842ZyfVW66fyrY8XgMCDgPwzM21EgwYtkZPjHDS5Sw4vVI 7a/mas0pJHypVATl8o2OAYQln0rm9ogM3rHt+ncmvQjbhwDWMh3hJ5hC/YD7v1N+34+6 QHpA86Qx/D41AutbZVqdw0HSMYvExJkf7xdRhy+6gL5KamOHLnqZqrNG77wHV6L6dNLS b1dzLNsPnp+GkABrkfxyAwJHKidracCwtNVhrpI5FpYFka219/UrzYqKKOTbAMu1YcaV oDg50ZUlWfvxyLD9RFk/jg9fV69wNCLg84RgsrXGFmgi1PsATuDdhO1oKSK/Hc5IT7KV qrsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891060; x=1710495860; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdMdoK0AVaUo9V+wul4fyguoktaqDabkYBWscL2ezsE=; b=MbWCqHPHsyHwc4FywJDH0fFmLmUIFD6F5n7w/5O+5/cxpClqSFKm6v0UovpjbwKbr0 4pLpMJfUP3akR4cNfA2GnA+xFoSrasrEMq+YOyAMUoPZ7AQO4F7yqZz7y+KsXsLfym0w 5JDRZ83oWDxNJmrL6K9H1slqI56aG+6LWEe6nvDV1oi5X+L4ib/rxWtxvaJVhD6TmDho Sk7l3Sp7wwIJ3uEOzZ1hoyJ+niV6eCHWt1orMid1iy64h6sJ1yCtERzt6W44u4QOLRYL sg3cRmaRpd4phv70zzf4ROUacrhSb9RnscG2DFFChCnAx0lVs/C7pXoAC3YAUyC7VM/m JYzg== X-Forwarded-Encrypted: i=1; AJvYcCWMDY35R8PSTQaNIJ8TVUPwGXCr7xvGmX5goEx45zcN2/vDnEN1WGzkwv/EgDsINFbOUb676smeqI56SA5nFwEe9GlOvPc8HTmwHGw8oQ== X-Gm-Message-State: AOJu0Yz8DS02KzvANkz7Hp+Pp9+mnWwHLDlcOajgvHoAkyWLMq2A5fZf GpMADDGHmEslw+iwkQpWIfFeNxZ55CsVqGpfGLDS8k43hOwtMKckQ0BVKex70g== X-Google-Smtp-Source: AGHT+IFPbL54AXHQXB9MkS0qJtzg8o8q9yBGg3I5qPe5e95N0vMgv1+cPBqKR5EsKnzhBrhB5Hgmww== X-Received: by 2002:a05:6a20:4284:b0:1a1:6b04:9f2e with SMTP id o4-20020a056a20428400b001a16b049f2emr7419660pzj.9.1709891060050; Fri, 08 Mar 2024 01:44:20 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id b1-20020aa78101000000b006e6350986a8sm6625169pfi.215.2024.03.08.01.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:44:19 -0800 (PST) Date: Fri, 8 Mar 2024 15:14:04 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240308094404.GF3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> <20240308053829.GC3789@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@ lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 08, 2024 at 09:48:07AM +0100, Niklas Cassel wrote: > On Fri, Mar 08, 2024 at 11:08:29AM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 10:09:06PM +0100, Niklas Cassel wrote: > > > On Mon, Mar 04, 2024 at 02:52:19PM +0530, Manivannan Sadhasivam wrote: > > > > "core_init_notifier" flag is set by the glue drivers requiring refclk from > > > > the host to complete the DWC core initialization. Also, those drivers will > > > > send a notification to the EPF drivers once the initialization is fully > > > > completed using the pci_epc_init_notify() API. Only then, the EPF drivers > > > > will start functioning. > > > > > > > > For the rest of the drivers generating refclk locally, EPF drivers will > > > > start functioning post binding with them. EPF drivers rely on the > > > > 'core_init_notifier' flag to differentiate between the drivers. > > > > Unfortunately, this creates two different flows for the EPF drivers. > > > > > > > > So to avoid that, let's get rid of the "core_init_notifier" flag and follow > > > > a single initialization flow for the EPF drivers. This is done by calling > > > > the dw_pcie_ep_init_notify() from all glue drivers after the completion of > > > > dw_pcie_ep_init_registers() API. This will allow all the glue drivers to > > > > send the notification to the EPF drivers once the initialization is fully > > > > completed. > > > > > > > > Only difference here is that, the drivers requiring refclk from host will > > > > send the notification once refclk is received, while others will send it > > > > during probe time itself. > > > > > > > > Reviewed-by: Frank Li > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > > > You have removed the .core_init_notifier from EPC drivers, > > > but the callback in EPF drivers is still called .core_init. > > > > > > Yes, this was a confusing name even before this patch, but > > > after this patch, it is probably even worse :) > > > > > > The callback should be named from the perspective of EPF drivers IMO. > > > .core_init sounds like a EPF driver should initialize the core. > > > (But that is of course done by the EPC driver.) > > > > > > The .link_up() callback name is better, the EPF driver is informed > > > that the link is up. > > > > > > Perhaps we could rename .core_init to .core_up ? > > > > > > It tells the EPF drivers that the core is now up. > > > (And the EPF driver can configure the BARs.) > > > > > > > I don't disagree :) I thought about it but then decided to not extend the scope > > of this series further. So saved that for next series. > > > > But yeah, it is good to clean it up here itself. > > If you intend to create a .core_deinit or .core_down (or whatever name > you decide on), perhaps it is better to leave this cleanup to be part > of that same series? > I already added a patch. So let's do it here itself :) - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6CF0C5475B for ; Fri, 8 Mar 2024 09:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eay89WWu/reWWpN18UOuI3pRJEL/C2CJnGFjbqLstJM=; b=ZrQ86gWg6JEXHZ rtsT8IryDdn2Qn3B2zqvkyuJhcdooX2mbtUlrjPOR6nfTpbN9FJTKSzSJHwv09qqRWyuLF/zUgeS5 +1fjvtxj4nQZ3LtxxHiirr/aWBVl0Ua+p1V88F4qIFM7ml1fGFT6e9lAHFZUTV2RKb5pr63kxAa7X wjVRxdsiOS8+SgAZ+YeH+EgBfiCe/eVS8tDJbMrWb+iuqyeFEaXYyxxE3Rez6IGsbknA5Qi/mlTPm Iir5Nkdr/X0ztubrR9O63AivqDrxGC02Z+rtdaJjf5RzwunNwty89YOgFdFuds5FNx4KVTPtjdv2G OJKL2XnfimGSjq8L6TfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWm9-00000008c9Z-3OI0; Fri, 08 Mar 2024 09:44:25 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWm7-00000008c7o-0ble for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 09:44:24 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6e55731af5cso482471b3a.0 for ; Fri, 08 Mar 2024 01:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891060; x=1710495860; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cdMdoK0AVaUo9V+wul4fyguoktaqDabkYBWscL2ezsE=; b=rRnEeVwMeJPzANn5ZAhrfDQ3i3mCTkgXRBfP/P5SpNpoXGrnGwc+GNRJOi8dgFaXOd RRYyC0D0IuP9K416l7dsLl9Hfs1ko5UepKeM2a8yW9bW2pqBuFmxeBMhjRGpAKZzcTpu wiG7UrDLEoVB9X9nUgHsRvCNq1St46OlwZmQQ9PSAnzBt6HgN6M38gxFHte6FuiTiGuj JKZG7Krz7RbuW8IE3F5PqwCrNtq14g5n7eaTzIEquyjCmmm9LuWS5nmmgNgw4CMpBAx0 Qwpaqr8qcDdvbmYtMJbLuSWCaxl3OvXVs1dm29IR5WDhKlNUuomcjS2V34wKr/QeYXZ/ 0HpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891060; x=1710495860; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdMdoK0AVaUo9V+wul4fyguoktaqDabkYBWscL2ezsE=; b=bPqzrhqJhyWj6uGV5IhU4hcEvEC93lU+XQpOlF5FM3GrCD6FJxY/ToN0zMDYV13RYz wMbmjOkeHRKj/LbWgJUgq92LZ9rLUTmAMiOtC9xS+xrDzJrbLVyXhOnIvNBLsTXMlUTu zD5ddivuY+3r7oNKrtYcOBISMtRP5FEurR1DrvYHDVNL77cOrhzD6cXlH/c/WdXTh2u5 snWSf8bWRwQQd4io6Ow5mMPsSWZsBvt93OJWlQHvZqM+SGcdauOggz82VwXI10NBslV+ LFxo2TMCB/yzMdnl9dr7/Ul2N43dCjfnLGq6m8Pl7DRRUhN+5mscWiXnZUht8XK0XFTT 02Jw== X-Forwarded-Encrypted: i=1; AJvYcCV/iqlEBaLagsC1mEyjBLNnvrN4Q6usQ+IbmqPr6KClKoqzYFn51QU1R9C7/2ZT7V1nl1oQWXPhXtSvsHXPuivUpyBIZ48pPmPMp1/bxIrh0Rx8pk4= X-Gm-Message-State: AOJu0YwVvxNa0J0mVaTcZBqV9WRzM6sjiTOc2ukCMCRqu0Bc5B412lfS RLRQoVZWTOxxEpe7DWOdh0XJ3BkbO+N49A3TOSmPA/oDlzbUWt+mixCn11mY4Q== X-Google-Smtp-Source: AGHT+IFPbL54AXHQXB9MkS0qJtzg8o8q9yBGg3I5qPe5e95N0vMgv1+cPBqKR5EsKnzhBrhB5Hgmww== X-Received: by 2002:a05:6a20:4284:b0:1a1:6b04:9f2e with SMTP id o4-20020a056a20428400b001a16b049f2emr7419660pzj.9.1709891060050; Fri, 08 Mar 2024 01:44:20 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id b1-20020aa78101000000b006e6350986a8sm6625169pfi.215.2024.03.08.01.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:44:19 -0800 (PST) Date: Fri, 8 Mar 2024 15:14:04 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240308094404.GF3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> <20240308053829.GC3789@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_014423_267298_65F560FD X-CRM114-Status: GOOD ( 34.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMDgsIDIwMjQgYXQgMDk6NDg6MDdBTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBGcmksIE1hciAwOCwgMjAyNCBhdCAxMTowODoyOUFNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiBPbiBUaHUsIE1hciAwNywgMjAyNCBhdCAxMDowOTow NlBNICswMTAwLCBOaWtsYXMgQ2Fzc2VsIHdyb3RlOgo+ID4gPiBPbiBNb24sIE1hciAwNCwgMjAy NCBhdCAwMjo1MjoxOVBNICswNTMwLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiA+ ID4gImNvcmVfaW5pdF9ub3RpZmllciIgZmxhZyBpcyBzZXQgYnkgdGhlIGdsdWUgZHJpdmVycyBy ZXF1aXJpbmcgcmVmY2xrIGZyb20KPiA+ID4gPiB0aGUgaG9zdCB0byBjb21wbGV0ZSB0aGUgRFdD IGNvcmUgaW5pdGlhbGl6YXRpb24uIEFsc28sIHRob3NlIGRyaXZlcnMgd2lsbAo+ID4gPiA+IHNl bmQgYSBub3RpZmljYXRpb24gdG8gdGhlIEVQRiBkcml2ZXJzIG9uY2UgdGhlIGluaXRpYWxpemF0 aW9uIGlzIGZ1bGx5Cj4gPiA+ID4gY29tcGxldGVkIHVzaW5nIHRoZSBwY2lfZXBjX2luaXRfbm90 aWZ5KCkgQVBJLiBPbmx5IHRoZW4sIHRoZSBFUEYgZHJpdmVycwo+ID4gPiA+IHdpbGwgc3RhcnQg ZnVuY3Rpb25pbmcuCj4gPiA+ID4gCj4gPiA+ID4gRm9yIHRoZSByZXN0IG9mIHRoZSBkcml2ZXJz IGdlbmVyYXRpbmcgcmVmY2xrIGxvY2FsbHksIEVQRiBkcml2ZXJzIHdpbGwKPiA+ID4gPiBzdGFy dCBmdW5jdGlvbmluZyBwb3N0IGJpbmRpbmcgd2l0aCB0aGVtLiBFUEYgZHJpdmVycyByZWx5IG9u IHRoZQo+ID4gPiA+ICdjb3JlX2luaXRfbm90aWZpZXInIGZsYWcgdG8gZGlmZmVyZW50aWF0ZSBi ZXR3ZWVuIHRoZSBkcml2ZXJzLgo+ID4gPiA+IFVuZm9ydHVuYXRlbHksIHRoaXMgY3JlYXRlcyB0 d28gZGlmZmVyZW50IGZsb3dzIGZvciB0aGUgRVBGIGRyaXZlcnMuCj4gPiA+ID4gCj4gPiA+ID4g U28gdG8gYXZvaWQgdGhhdCwgbGV0J3MgZ2V0IHJpZCBvZiB0aGUgImNvcmVfaW5pdF9ub3RpZmll ciIgZmxhZyBhbmQgZm9sbG93Cj4gPiA+ID4gYSBzaW5nbGUgaW5pdGlhbGl6YXRpb24gZmxvdyBm b3IgdGhlIEVQRiBkcml2ZXJzLiBUaGlzIGlzIGRvbmUgYnkgY2FsbGluZwo+ID4gPiA+IHRoZSBk d19wY2llX2VwX2luaXRfbm90aWZ5KCkgZnJvbSBhbGwgZ2x1ZSBkcml2ZXJzIGFmdGVyIHRoZSBj b21wbGV0aW9uIG9mCj4gPiA+ID4gZHdfcGNpZV9lcF9pbml0X3JlZ2lzdGVycygpIEFQSS4gVGhp cyB3aWxsIGFsbG93IGFsbCB0aGUgZ2x1ZSBkcml2ZXJzIHRvCj4gPiA+ID4gc2VuZCB0aGUgbm90 aWZpY2F0aW9uIHRvIHRoZSBFUEYgZHJpdmVycyBvbmNlIHRoZSBpbml0aWFsaXphdGlvbiBpcyBm dWxseQo+ID4gPiA+IGNvbXBsZXRlZC4KPiA+ID4gPiAKPiA+ID4gPiBPbmx5IGRpZmZlcmVuY2Ug aGVyZSBpcyB0aGF0LCB0aGUgZHJpdmVycyByZXF1aXJpbmcgcmVmY2xrIGZyb20gaG9zdCB3aWxs Cj4gPiA+ID4gc2VuZCB0aGUgbm90aWZpY2F0aW9uIG9uY2UgcmVmY2xrIGlzIHJlY2VpdmVkLCB3 aGlsZSBvdGhlcnMgd2lsbCBzZW5kIGl0Cj4gPiA+ID4gZHVyaW5nIHByb2JlIHRpbWUgaXRzZWxm Lgo+ID4gPiA+IAo+ID4gPiA+IFJldmlld2VkLWJ5OiBGcmFuayBMaSA8RnJhbmsuTGlAbnhwLmNv bT4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5u YW4uc2FkaGFzaXZhbUBsaW5hcm8ub3JnPgo+ID4gPiA+IC0tLQo+ID4gPiAKPiA+ID4gWW91IGhh dmUgcmVtb3ZlZCB0aGUgLmNvcmVfaW5pdF9ub3RpZmllciBmcm9tIEVQQyBkcml2ZXJzLAo+ID4g PiBidXQgdGhlIGNhbGxiYWNrIGluIEVQRiBkcml2ZXJzIGlzIHN0aWxsIGNhbGxlZCAuY29yZV9p bml0Lgo+ID4gPiAKPiA+ID4gWWVzLCB0aGlzIHdhcyBhIGNvbmZ1c2luZyBuYW1lIGV2ZW4gYmVm b3JlIHRoaXMgcGF0Y2gsIGJ1dAo+ID4gPiBhZnRlciB0aGlzIHBhdGNoLCBpdCBpcyBwcm9iYWJs eSBldmVuIHdvcnNlIDopCj4gPiA+IAo+ID4gPiBUaGUgY2FsbGJhY2sgc2hvdWxkIGJlIG5hbWVk IGZyb20gdGhlIHBlcnNwZWN0aXZlIG9mIEVQRiBkcml2ZXJzIElNTy4KPiA+ID4gLmNvcmVfaW5p dCBzb3VuZHMgbGlrZSBhIEVQRiBkcml2ZXIgc2hvdWxkIGluaXRpYWxpemUgdGhlIGNvcmUuCj4g PiA+IChCdXQgdGhhdCBpcyBvZiBjb3Vyc2UgZG9uZSBieSB0aGUgRVBDIGRyaXZlci4pCj4gPiA+ IAo+ID4gPiBUaGUgLmxpbmtfdXAoKSBjYWxsYmFjayBuYW1lIGlzIGJldHRlciwgdGhlIEVQRiBk cml2ZXIgaXMgaW5mb3JtZWQKPiA+ID4gdGhhdCB0aGUgbGluayBpcyB1cC4KPiA+ID4gCj4gPiA+ IFBlcmhhcHMgd2UgY291bGQgcmVuYW1lIC5jb3JlX2luaXQgdG8gLmNvcmVfdXAgPwo+ID4gPiAK PiA+ID4gSXQgdGVsbHMgdGhlIEVQRiBkcml2ZXJzIHRoYXQgdGhlIGNvcmUgaXMgbm93IHVwLgo+ ID4gPiAoQW5kIHRoZSBFUEYgZHJpdmVyIGNhbiBjb25maWd1cmUgdGhlIEJBUnMuKQo+ID4gPiAK PiA+IAo+ID4gSSBkb24ndCBkaXNhZ3JlZSA6KSBJIHRob3VnaHQgYWJvdXQgaXQgYnV0IHRoZW4g ZGVjaWRlZCB0byBub3QgZXh0ZW5kIHRoZSBzY29wZQo+ID4gb2YgdGhpcyBzZXJpZXMgZnVydGhl ci4gU28gc2F2ZWQgdGhhdCBmb3IgbmV4dCBzZXJpZXMuCj4gPiAKPiA+IEJ1dCB5ZWFoLCBpdCBp cyBnb29kIHRvIGNsZWFuIGl0IHVwIGhlcmUgaXRzZWxmLgo+IAo+IElmIHlvdSBpbnRlbmQgdG8g Y3JlYXRlIGEgLmNvcmVfZGVpbml0IG9yIC5jb3JlX2Rvd24gKG9yIHdoYXRldmVyIG5hbWUKPiB5 b3UgZGVjaWRlIG9uKSwgcGVyaGFwcyBpdCBpcyBiZXR0ZXIgdG8gbGVhdmUgdGhpcyBjbGVhbnVw IHRvIGJlIHBhcnQKPiBvZiB0aGF0IHNhbWUgc2VyaWVzPwo+IAoKSSBhbHJlYWR5IGFkZGVkIGEg cGF0Y2guIFNvIGxldCdzIGRvIGl0IGhlcmUgaXRzZWxmIDopCgotIE1hbmkKCi0tIArgrq7grqPg rr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==