From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22026535BC for ; Fri, 8 Mar 2024 09:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891408; cv=none; b=Tx/OQOAEDaQZMKooGkBhA+rzGveWL+EblpYIxI/wkyXy8ALt9sGG7/a7fLmfinMD7PUaMrmvMEHlr5w12TBLO2i3CZOxqNHbqGOy4LXmJ4J/Os+N0+wBGYyaQKjxLyxFiA0IX+u1dFNmvP00NV3eXbvbweAZPfgmYosjY5r3ErI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891408; c=relaxed/simple; bh=N+FnD75U9P5fcQ38HlMO4pcD/DzIJlqTaauzTbsehwI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B22+f5Ujk4Um9FhYSDaZM28QN19w2Kb230RrWdNnlyAiyaOGDgmidNXG0D0PuAHbyaYQVxN0qZfU5SEXaZ/9ziGszNKE9loN/b+VZiDu5GaO5PH05jruLwVNm61p1yBpC4NxEa+vbN9kYm9vwxv2fRcdpNrHIEq8ghFPXy0jCKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HDUwHABd; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HDUwHABd" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5d3907ff128so1532576a12.3 for ; Fri, 08 Mar 2024 01:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891405; x=1710496205; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=HDUwHABdT92cmTAErIymd71gIzFwxlngdnjYnnJDu5wUhDIg1nJK4RHjEo4BS0jKuB G99mFpPQfLPiXRRmEYZJDp2kreUmiWDm9R94GfowCB8JSfRVXY/vnKddRLtk8N67lqxu fePNWztxa8g5MNRwH2cxR97zdVlikMFyNII48E6VE6zZr0xkdfANfTA5y+GPT+QZVVDr ScS4ME+JQyD1CYdFB31P8uecrdFfh/L4t2a6g+sw/vUJxDXIYuvM3OUXmE1K47WLZvY6 1ibvW+/j9gbUHU4aPBtNNaTmQxXVENs4Mt4GwBC1zu5fQyAMM1uYwDlX/8GvgnNIU2f4 Gq2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891405; x=1710496205; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=XvJRrAyLq7YoUsoJ4/8asQ2y0pV180zNvw5xuR/zbpkQug7CGRyRJU0vSqRF32EMhK y3jzmAXdCOeMbuhaWr4SNJ65ahN3aXFKii2TRkvWOepuL5UXxv5nM3oXVA7tzdhB1xFE fD6DXVX/U2H4qpRDfOSfckJqAPtt6LP6VyX/S2WN+2yqlCAn529AfkhbsRf44QXOUz2Z O2RksJ6/WBwCgmDTOqEs1iVEmkx61yG6XhVWoRclpuTKbygRBot1dP3Fe5F+Z1WfIgGy NFsj0Z3Q3WHwguM1ncdZql0caEn6F/21Z2loXFllvbzaEf5pCHofzOMUObSVDJNrf0QT gVFg== X-Forwarded-Encrypted: i=1; AJvYcCUlOQXrNBWjEqw4WQhBIBWFvu33O8CP7SxmCi5AT4w2qpLEkFEnMwu5skfHaJqwZF2NcYiG1eCmZGiVkDqFeck2btG6tK3vdtR4wlGQlg== X-Gm-Message-State: AOJu0Yw96+NjZIIFG/b/iVaF2g1/BJ2W4ivL/XHuwrBBUfP58e69tP6t FXu3Q1ts+pramNVgbBWkSDzJM3CeoJdd6cZ7lntAuqli6JVjf40hgO2F2vH4Ew== X-Google-Smtp-Source: AGHT+IEMW10NsMpl6QbbrMpGgV+z8bvUPkiIHa5C3nopapJCs9aJNBuwrvqex+LlxA53iZxgm5hkkg== X-Received: by 2002:a05:6a20:160a:b0:1a1:4a45:c05f with SMTP id l10-20020a056a20160a00b001a14a45c05fmr12756809pzj.25.1709891405150; Fri, 08 Mar 2024 01:50:05 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id w8-20020a17090aea0800b0029bb8ebdc23sm374544pjy.37.2024.03.08.01.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:50:04 -0800 (PST) Date: Fri, 8 Mar 2024 15:19:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308094947.GH3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> <20240308053624.GB3789@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 08, 2024 at 10:05:11AM +0100, Niklas Cassel wrote: > On Fri, Mar 08, 2024 at 11:06:24AM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 09:36:56PM +0100, Niklas Cassel wrote: > > > On Mon, Mar 04, 2024 at 02:52:18PM +0530, Manivannan Sadhasivam wrote: > > > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > > > drivers requiring active refclk from host. But for the other drivers, it is > > > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > > > that this API initializes DWC EP specific registers and that requires an > > > > active refclk (either from host or generated locally by endpoint itsef). > > > > > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > > > confusion, let's call this API directly from all glue drivers irrespective > > > > of refclk dependency. Only difference here is that the drivers requiring > > > > refclk from host will call this API only after the refclk is received and > > > > other drivers without refclk dependency will call this API right after > > > > dw_pcie_ep_init(). > > > > > > > > With this change, the check for 'core_init_notifier' flag can now be > > > > dropped from dw_pcie_ep_init() API. This will also allow us to remove the > > > > 'core_init_notifier' flag completely in the later commits. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pcie-artpec6.c | 13 ++++++++++++- > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pcie-keembay.c | 16 +++++++++++++++- > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > > > 10 files changed, 90 insertions(+), 26 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > > > > index 0e406677060d..395042b29ffc 100644 > > > > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > > > > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > > > > @@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, > > > > return ret; > > > > } > > > > > > > > + ret = dw_pcie_ep_init_registers(ep); > > > > + if (ret) { > > > > > > Here you are using if (ret) to error check the return from > > > dw_pcie_ep_init_registers(). > > > > > > > > > > index c0c62533a3f1..8392894ed286 100644 > > > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > > > @@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) > > > > ret = dw_pcie_ep_init(&pci->ep); > > > > if (ret < 0) > > > > goto err_get_sync; > > > > + > > > > + ret = dw_pcie_ep_init_registers(&pci->ep); > > > > + if (ret < 0) { > > > > > > Here you are using if (ret < 0) to error check the return from > > > dw_pcie_ep_init_registers(). Please be consistent. > > > > > > > I maintained the consistency w.r.t individual drivers. Please check them > > individually. > > > > If I maintain consistency w.r.t this patch, then the style will change within > > the drivers. > > Personally, I disagree with that. > > All glue drivers should use the same way of checking dw_pcie_ep_init(), > depending on the kdoc of dw_pcie_ep_init(). > > If the kdoc for dw_pcie_ep_init() says returns 0 on success, > then I think that it is strictly more correct to do: > > ret = dw_pcie_ep_init() > if (ret) { > > } > > And if a glue driver doesn't look like that, then I think we should change > them. (Same reasoning for dw_pcie_ep_init_registers().) > > > If you read code that looks like: > ret = dw_pcie_ep_init() > if (ret < 0) { > > } > > then you assume that is is a function with a kdoc that says it can return 0 > or a positive value on success, e.g. a function that returns an index in an > array. > But if you read the same function from the individual drivers, it could present a different opinion because the samantics is different than others. I'm not opposed to keeping the API semantics consistent, but we have to take account of the drivers style as well. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 630D1C5475B for ; Fri, 8 Mar 2024 09:50:52 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NiJFTgaG; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrhHt6Jmpz3vYj for ; Fri, 8 Mar 2024 20:50:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NiJFTgaG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::532; helo=mail-pg1-x532.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrhH52sbDz3cgg for ; Fri, 8 Mar 2024 20:50:07 +1100 (AEDT) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso1499508a12.2 for ; Fri, 08 Mar 2024 01:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891405; x=1710496205; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=NiJFTgaGuRc0a5+8w1dGsKQEukmwW1YZZMZMwsRTVEjmmRpZy2UQ+vq8zuxj8NdYTH z285NIVtCY9F1NoN71UnSFJWI7pT5kxGWHTfdBGghcWixrZU6JMeP5/XbkpsbPHSK7Um H8ayVBd2one24mSE/gIrPvRC5C/JFxsNRTFHMl2nMPHRnATEQGfkbmjTEhxDsndfl18O hjM3VGZMjAt+EQcM5ImRlSbvrM3N7gmqE+D/+k9p31aJQF4WHss608gFjGORsqG2vOyJ SPyIfnbnT+9Y9KXXtjt5DmpiJW/IomlUIP/1dU/53SSivkBUrPWz6IeaSPdeBwoe4oOj iSlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891405; x=1710496205; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=ODeWNVbUJLA7pGTEBgfb61vxnIRsEIpa2UoirBBM58C5VYbhgO/167HddqfU4nku+E k9WkD66cvK0k9OSrd75tOaY3cE/FUFej732bO5zY0WzlkZ7nvydKghWVbnecui10SIIj YA7u4xxBixhfosLJEIsqVfb+cooHLUKX7V17C44vmidyfKeFSCo95MSPilE7siWCZeE0 8EPYQH/9Ycwd0im1kE453H9V7S3e8HxlzvK3MHEL2b3srnlvrXdslPmBI+gujXlvQFTc qpc4hEQDsqJ1+cqqZec4fxxpHi7GzrlX7HXm7FY/wG1R3hpzvLxGtoNTlXAKtCT3BqnO 9nsw== X-Forwarded-Encrypted: i=1; AJvYcCVCQvWZzB8VR8am4cXDnwXTyUVjh01zbnC+i8DO2I/iax8MpawEZkR+ARHF9d23RuaE4QOcGy2ukw/Q6Z4aIQiCfQF51Mzo1SWi6mM1Wg== X-Gm-Message-State: AOJu0YxIAFY7CkI8V9VbtcK+6cIm8bW6HwmjymPKh9aQtmGgz2Pa44bv 6mGpQ5HeCWY2xF7sFq071xZVhl6xBirbvF2Yp/GlfnXaOOZNuwtDnBTxP6t+kA== X-Google-Smtp-Source: AGHT+IEMW10NsMpl6QbbrMpGgV+z8bvUPkiIHa5C3nopapJCs9aJNBuwrvqex+LlxA53iZxgm5hkkg== X-Received: by 2002:a05:6a20:160a:b0:1a1:4a45:c05f with SMTP id l10-20020a056a20160a00b001a14a45c05fmr12756809pzj.25.1709891405150; Fri, 08 Mar 2024 01:50:05 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id w8-20020a17090aea0800b0029bb8ebdc23sm374544pjy.37.2024.03.08.01.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:50:04 -0800 (PST) Date: Fri, 8 Mar 2024 15:19:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308094947.GH3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> <20240308053624.GB3789@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 08, 2024 at 10:05:11AM +0100, Niklas Cassel wrote: > On Fri, Mar 08, 2024 at 11:06:24AM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 09:36:56PM +0100, Niklas Cassel wrote: > > > On Mon, Mar 04, 2024 at 02:52:18PM +0530, Manivannan Sadhasivam wrote: > > > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > > > drivers requiring active refclk from host. But for the other drivers, it is > > > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > > > that this API initializes DWC EP specific registers and that requires an > > > > active refclk (either from host or generated locally by endpoint itsef). > > > > > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > > > confusion, let's call this API directly from all glue drivers irrespective > > > > of refclk dependency. Only difference here is that the drivers requiring > > > > refclk from host will call this API only after the refclk is received and > > > > other drivers without refclk dependency will call this API right after > > > > dw_pcie_ep_init(). > > > > > > > > With this change, the check for 'core_init_notifier' flag can now be > > > > dropped from dw_pcie_ep_init() API. This will also allow us to remove the > > > > 'core_init_notifier' flag completely in the later commits. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pcie-artpec6.c | 13 ++++++++++++- > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pcie-keembay.c | 16 +++++++++++++++- > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > > > 10 files changed, 90 insertions(+), 26 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > > > > index 0e406677060d..395042b29ffc 100644 > > > > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > > > > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > > > > @@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, > > > > return ret; > > > > } > > > > > > > > + ret = dw_pcie_ep_init_registers(ep); > > > > + if (ret) { > > > > > > Here you are using if (ret) to error check the return from > > > dw_pcie_ep_init_registers(). > > > > > > > > > > index c0c62533a3f1..8392894ed286 100644 > > > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > > > @@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) > > > > ret = dw_pcie_ep_init(&pci->ep); > > > > if (ret < 0) > > > > goto err_get_sync; > > > > + > > > > + ret = dw_pcie_ep_init_registers(&pci->ep); > > > > + if (ret < 0) { > > > > > > Here you are using if (ret < 0) to error check the return from > > > dw_pcie_ep_init_registers(). Please be consistent. > > > > > > > I maintained the consistency w.r.t individual drivers. Please check them > > individually. > > > > If I maintain consistency w.r.t this patch, then the style will change within > > the drivers. > > Personally, I disagree with that. > > All glue drivers should use the same way of checking dw_pcie_ep_init(), > depending on the kdoc of dw_pcie_ep_init(). > > If the kdoc for dw_pcie_ep_init() says returns 0 on success, > then I think that it is strictly more correct to do: > > ret = dw_pcie_ep_init() > if (ret) { > > } > > And if a glue driver doesn't look like that, then I think we should change > them. (Same reasoning for dw_pcie_ep_init_registers().) > > > If you read code that looks like: > ret = dw_pcie_ep_init() > if (ret < 0) { > > } > > then you assume that is is a function with a kdoc that says it can return 0 > or a positive value on success, e.g. a function that returns an index in an > array. > But if you read the same function from the individual drivers, it could present a different opinion because the samantics is different than others. I'm not opposed to keeping the API semantics consistent, but we have to take account of the drivers style as well. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC71C5475B for ; Fri, 8 Mar 2024 09:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5n7i/UcwD8NqrbIek7zk02r/XsUJ57AQikgcCYAY5YU=; b=DNb0E/b+cxmNQ3 qHvhJdLiwLBKaCKkyaJjP8/4UVpCaYD58ge6Da5aDGaAFE6Ui8y6/65VcAdq64lFvC6xNk9uuk5Wm Q3Kc3Gyk0NA7GmFVSjPtgsh5LLoRfdp9QRsNdep2CVOvqy8NQUxiSluOZwZyX418IWH0Y+pSybJ7B 2BiXOfv9B4eOsm2qAnYnZ+DQdak2m5SvmD2op/0HpgmoMKVlcn5dKxfvcGTYmyHOmPCyIruIgyHYt 3TgXA08cVDuPpSgUPyqzf55+tMYGqZvIrlFdiiSBZGAZalMxVlWsIJBbjWdY2U0H8N83PlVQA82GQ xyFc+YvbhQpB+l/ItJrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWrh-00000008dLl-0f5P; Fri, 08 Mar 2024 09:50:09 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWre-00000008dL0-1nLm for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 09:50:07 +0000 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5d3907ff128so1532572a12.3 for ; Fri, 08 Mar 2024 01:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891405; x=1710496205; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=TJYC3Wefg39tq7UL1djFZW+iQg7zr2VuE4zuU8Py9PoRoeWFLZ86IvqKdXq9+vtNAF IjbeDa4AtgAjkb41Zub0mdlGQRWuYwcEVPmZPeWwvGSe9+G7ax3VHpoEo39pAwk7zlgE OVAtvXzyzLNlbp2hz6SDIOWIdOWHC7wYw7qNyOvaGuiObqtFrBRiMKzJoDHeTOAD/9rk HCeLYynq4sm35brf5io33Ux6xN9KmlzVnBF2CJf6mZLVrwtPm9MtFesOZ7463WxoZxNY NVZO3YsNjh7d2QnH5wtFSw+y1aWQ5QJL67VVoV4TADnuxzlqE3avhYBl1vdzcIE2OOSH QJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891405; x=1710496205; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=k2GY0Evv8g2rpZvy6SIE29WaZ1v7eW3LYRSTpd9Fru4H6dADmaek/awRS85ZYF0Lo4 Dy1Kn7djSEyk38WqGndzNeeDCO1XM5VNm3sAzIBRsLzkfgzpfJfkjiUcm1MOz8fQqgrB ZRitIKStTd3Qdm5AUS1KM86hRTfNJPSNZ+M9FMB9C23FV0Le8tNmMqAoveTe9jG2Zk8h wYCZbMGa3T2+raNBHSlLRJZrBFGRjs+22YoyVptEyt2LrY6xq27VGjb57ix5ySDpB2b6 G/VblhSQSBfxm5sjjlKuIE9hmjF7QpeuXSII1d5VG5eDk27sDO9oMTW7KA+cWDggwQdb UH3w== X-Forwarded-Encrypted: i=1; AJvYcCXc0ePW/9zQ1yDgs83adOr0LbXf0kDg/jRfx1Z2EwzFtJwLDFRGr48UnUKVYWTQsz89lUo02Eq3X04/Dpq2sNflYGxB9UsV/5MzKBCO1Gpk0DwcVS4= X-Gm-Message-State: AOJu0Yz6irXG188nWCK0L/9ewK1row603UzzDAkXnU/nteQIZeY7wIeT +cF/s9MssnkaZCld8VoLQTVDwofcXH2u+C6nmw4QhklOUv+9fJFtvkGj+59sdg== X-Google-Smtp-Source: AGHT+IEMW10NsMpl6QbbrMpGgV+z8bvUPkiIHa5C3nopapJCs9aJNBuwrvqex+LlxA53iZxgm5hkkg== X-Received: by 2002:a05:6a20:160a:b0:1a1:4a45:c05f with SMTP id l10-20020a056a20160a00b001a14a45c05fmr12756809pzj.25.1709891405150; Fri, 08 Mar 2024 01:50:05 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id w8-20020a17090aea0800b0029bb8ebdc23sm374544pjy.37.2024.03.08.01.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:50:04 -0800 (PST) Date: Fri, 8 Mar 2024 15:19:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308094947.GH3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> <20240308053624.GB3789@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_015006_559005_886F4BC8 X-CRM114-Status: GOOD ( 40.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMDgsIDIwMjQgYXQgMTA6MDU6MTFBTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBGcmksIE1hciAwOCwgMjAyNCBhdCAxMTowNjoyNEFNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiBPbiBUaHUsIE1hciAwNywgMjAyNCBhdCAwOTozNjo1 NlBNICswMTAwLCBOaWtsYXMgQ2Fzc2VsIHdyb3RlOgo+ID4gPiBPbiBNb24sIE1hciAwNCwgMjAy NCBhdCAwMjo1MjoxOFBNICswNTMwLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiA+ ID4gQ3VycmVudGx5LCBkd19wY2llX2VwX2luaXRfcmVnaXN0ZXJzKCkgQVBJIGlzIGRpcmVjdGx5 IGNhbGxlZCBieSB0aGUgZ2x1ZQo+ID4gPiA+IGRyaXZlcnMgcmVxdWlyaW5nIGFjdGl2ZSByZWZj bGsgZnJvbSBob3N0LiBCdXQgZm9yIHRoZSBvdGhlciBkcml2ZXJzLCBpdCBpcwo+ID4gPiA+IGdl dHRpbmcgY2FsbGVkIGltcGxpY2l0bHkgYnkgZHdfcGNpZV9lcF9pbml0KCkuIFRoaXMgaXMgZHVl IHRvIHRoZSBmYWN0Cj4gPiA+ID4gdGhhdCB0aGlzIEFQSSBpbml0aWFsaXplcyBEV0MgRVAgc3Bl Y2lmaWMgcmVnaXN0ZXJzIGFuZCB0aGF0IHJlcXVpcmVzIGFuCj4gPiA+ID4gYWN0aXZlIHJlZmNs ayAoZWl0aGVyIGZyb20gaG9zdCBvciBnZW5lcmF0ZWQgbG9jYWxseSBieSBlbmRwb2ludCBpdHNl ZikuCj4gPiA+ID4gCj4gPiA+ID4gQnV0LCB0aGlzIGNhdXNlcyBhIGRpc2NyZXBhbmN5IGFtb25n IHRoZSBnbHVlIGRyaXZlcnMuIFNvIHRvIGF2b2lkIHRoaXMKPiA+ID4gPiBjb25mdXNpb24sIGxl dCdzIGNhbGwgdGhpcyBBUEkgZGlyZWN0bHkgZnJvbSBhbGwgZ2x1ZSBkcml2ZXJzIGlycmVzcGVj dGl2ZQo+ID4gPiA+IG9mIHJlZmNsayBkZXBlbmRlbmN5LiBPbmx5IGRpZmZlcmVuY2UgaGVyZSBp cyB0aGF0IHRoZSBkcml2ZXJzIHJlcXVpcmluZwo+ID4gPiA+IHJlZmNsayBmcm9tIGhvc3Qgd2ls bCBjYWxsIHRoaXMgQVBJIG9ubHkgYWZ0ZXIgdGhlIHJlZmNsayBpcyByZWNlaXZlZCBhbmQKPiA+ ID4gPiBvdGhlciBkcml2ZXJzIHdpdGhvdXQgcmVmY2xrIGRlcGVuZGVuY3kgd2lsbCBjYWxsIHRo aXMgQVBJIHJpZ2h0IGFmdGVyCj4gPiA+ID4gZHdfcGNpZV9lcF9pbml0KCkuCj4gPiA+ID4gCj4g PiA+ID4gV2l0aCB0aGlzIGNoYW5nZSwgdGhlIGNoZWNrIGZvciAnY29yZV9pbml0X25vdGlmaWVy JyBmbGFnIGNhbiBub3cgYmUKPiA+ID4gPiBkcm9wcGVkIGZyb20gZHdfcGNpZV9lcF9pbml0KCkg QVBJLiBUaGlzIHdpbGwgYWxzbyBhbGxvdyB1cyB0byByZW1vdmUgdGhlCj4gPiA+ID4gJ2NvcmVf aW5pdF9ub3RpZmllcicgZmxhZyBjb21wbGV0ZWx5IGluIHRoZSBsYXRlciBjb21taXRzLgo+ID4g PiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaXZh bm5hbi5zYWRoYXNpdmFtQGxpbmFyby5vcmc+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1kcmE3eHguYyAgICAgICAgICAgfCAgNyArKysrKysrCj4g PiA+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgICAgICAgICAgICAg fCAgOCArKysrKysrKwo+ID4gPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2kta2V5 c3RvbmUuYyAgICAgICAgIHwgIDkgKysrKysrKysrCj4gPiA+ID4gIGRyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLWVwLmMgICAgfCAgNyArKysrKysrCj4gPiA+ID4gIGRy aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtYXJ0cGVjNi5jICAgICAgICAgfCAxMyArKysr KysrKysrKystCj4gPiA+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZGVzaWdu d2FyZS1lcC5jICAgfCAyMiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ID4gIGRyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZGVzaWdud2FyZS1wbGF0LmMgfCAgOSArKysrKysrKysK PiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1rZWVtYmF5LmMgICAgICAg ICB8IDE2ICsrKysrKysrKysrKysrKy0KPiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpZS1yY2FyLWdlbjQuYyAgICAgICB8IDEyICsrKysrKysrKysrLQo+ID4gPiA+ICBkcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXVuaXBoaWVyLWVwLmMgICAgIHwgMTMgKysrKysr KysrKysrLQo+ID4gPiA+ICAxMCBmaWxlcyBjaGFuZ2VkLCA5MCBpbnNlcnRpb25zKCspLCAyNiBk ZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWRyYTd4eC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp LWRyYTd4eC5jCj4gPiA+ID4gaW5kZXggMGU0MDY2NzcwNjBkLi4zOTUwNDJiMjlmZmMgMTAwNjQ0 Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWRyYTd4eC5jCj4g PiA+ID4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWRyYTd4eC5jCj4gPiA+ ID4gQEAgLTQ2Nyw2ICs0NjcsMTMgQEAgc3RhdGljIGludCBkcmE3eHhfYWRkX3BjaWVfZXAoc3Ry dWN0IGRyYTd4eF9wY2llICpkcmE3eHgsCj4gPiA+ID4gIAkJcmV0dXJuIHJldDsKPiA+ID4gPiAg CX0KPiA+ID4gPiAgCj4gPiA+ID4gKwlyZXQgPSBkd19wY2llX2VwX2luaXRfcmVnaXN0ZXJzKGVw KTsKPiA+ID4gPiArCWlmIChyZXQpIHsKPiA+ID4gCj4gPiA+IEhlcmUgeW91IGFyZSB1c2luZyBp ZiAocmV0KSB0byBlcnJvciBjaGVjayB0aGUgcmV0dXJuIGZyb20KPiA+ID4gZHdfcGNpZV9lcF9p bml0X3JlZ2lzdGVycygpLgo+ID4gPiAKPiA+ID4gCj4gPiA+ID4gaW5kZXggYzBjNjI1MzNhM2Yx Li44MzkyODk0ZWQyODYgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpLWtleXN0b25lLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2kta2V5c3RvbmUuYwo+ID4gPiA+IEBAIC0xMjg2LDYgKzEyODYsMTMgQEAgc3RhdGlj IGludCBrc19wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiA+ID4g IAkJcmV0ID0gZHdfcGNpZV9lcF9pbml0KCZwY2ktPmVwKTsKPiA+ID4gPiAgCQlpZiAocmV0IDwg MCkKPiA+ID4gPiAgCQkJZ290byBlcnJfZ2V0X3N5bmM7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJCXJl dCA9IGR3X3BjaWVfZXBfaW5pdF9yZWdpc3RlcnMoJnBjaS0+ZXApOwo+ID4gPiA+ICsJCWlmIChy ZXQgPCAwKSB7Cj4gPiA+IAo+ID4gPiBIZXJlIHlvdSBhcmUgdXNpbmcgaWYgKHJldCA8IDApIHRv IGVycm9yIGNoZWNrIHRoZSByZXR1cm4gZnJvbQo+ID4gPiBkd19wY2llX2VwX2luaXRfcmVnaXN0 ZXJzKCkuIFBsZWFzZSBiZSBjb25zaXN0ZW50Lgo+ID4gPiAKPiA+IAo+ID4gSSBtYWludGFpbmVk IHRoZSBjb25zaXN0ZW5jeSB3LnIudCBpbmRpdmlkdWFsIGRyaXZlcnMuIFBsZWFzZSBjaGVjayB0 aGVtCj4gPiBpbmRpdmlkdWFsbHkuCj4gPiAKPiA+IElmIEkgbWFpbnRhaW4gY29uc2lzdGVuY3kg dy5yLnQgdGhpcyBwYXRjaCwgdGhlbiB0aGUgc3R5bGUgd2lsbCBjaGFuZ2Ugd2l0aGluCj4gPiB0 aGUgZHJpdmVycy4KPiAKPiBQZXJzb25hbGx5LCBJIGRpc2FncmVlIHdpdGggdGhhdC4KPiAKPiBB bGwgZ2x1ZSBkcml2ZXJzIHNob3VsZCB1c2UgdGhlIHNhbWUgd2F5IG9mIGNoZWNraW5nIGR3X3Bj aWVfZXBfaW5pdCgpLAo+IGRlcGVuZGluZyBvbiB0aGUga2RvYyBvZiBkd19wY2llX2VwX2luaXQo KS4KPiAKPiBJZiB0aGUga2RvYyBmb3IgZHdfcGNpZV9lcF9pbml0KCkgc2F5cyByZXR1cm5zIDAg b24gc3VjY2VzcywKPiB0aGVuIEkgdGhpbmsgdGhhdCBpdCBpcyBzdHJpY3RseSBtb3JlIGNvcnJl Y3QgdG8gZG86Cj4gCj4gcmV0ID0gZHdfcGNpZV9lcF9pbml0KCkKPiBpZiAocmV0KSB7Cj4gCTxl cnJvciBoYW5kbGluZz4KPiB9Cj4gCj4gQW5kIGlmIGEgZ2x1ZSBkcml2ZXIgZG9lc24ndCBsb29r IGxpa2UgdGhhdCwgdGhlbiBJIHRoaW5rIHdlIHNob3VsZCBjaGFuZ2UKPiB0aGVtLiAoU2FtZSBy ZWFzb25pbmcgZm9yIGR3X3BjaWVfZXBfaW5pdF9yZWdpc3RlcnMoKS4pCj4gCj4gCj4gSWYgeW91 IHJlYWQgY29kZSB0aGF0IGxvb2tzIGxpa2U6Cj4gcmV0ID0gZHdfcGNpZV9lcF9pbml0KCkKPiBp ZiAocmV0IDwgMCkgewo+IAk8ZXJyb3IgaGFuZGxpbmc+Cj4gfQo+IAo+IHRoZW4geW91IGFzc3Vt ZSB0aGF0IGlzIGlzIGEgZnVuY3Rpb24gd2l0aCBhIGtkb2MgdGhhdCBzYXlzIGl0IGNhbiByZXR1 cm4gMAo+IG9yIGEgcG9zaXRpdmUgdmFsdWUgb24gc3VjY2VzcywgZS5nLiBhIGZ1bmN0aW9uIHRo YXQgcmV0dXJucyBhbiBpbmRleCBpbiBhbgo+IGFycmF5Lgo+IAoKQnV0IGlmIHlvdSByZWFkIHRo ZSBzYW1lIGZ1bmN0aW9uIGZyb20gdGhlIGluZGl2aWR1YWwgZHJpdmVycywgaXQgY291bGQgcHJl c2VudAphIGRpZmZlcmVudCBvcGluaW9uIGJlY2F1c2UgdGhlIHNhbWFudGljcyBpcyBkaWZmZXJl bnQgdGhhbiBvdGhlcnMuCgpJJ20gbm90IG9wcG9zZWQgdG8ga2VlcGluZyB0aGUgQVBJIHNlbWFu dGljcyBjb25zaXN0ZW50LCBidXQgd2UgaGF2ZSB0byB0YWtlCmFjY291bnQgb2YgdGhlIGRyaXZl cnMgc3R5bGUgYXMgd2VsbC4KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCv jSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK