From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH xtables] extensions: xt_TPROXY: add txlate support
Date: Fri, 8 Mar 2024 15:25:27 +0100 [thread overview]
Message-ID: <20240308142527.GD22451@breakpoint.cc> (raw)
In-Reply-To: <Zer9L_EgbICxBu0m@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Could you please add a testcase involving an IPv6 address? Just so we
> exercise this code path.
done.
> > + else if (mask || info->mark_value)
> > + xt_xlate_add(xl, "meta mark set meta mark & 0x%x or 0x%x",
> > + ~mask, info->mark_value);
>
> Shouldn't this be 'xor' instead of 'or' in translated output?
Makes no difference. But I see that this might be confusing when
looking at xt_TPROXY.c or the comment so I changed it.
prev parent reply other threads:[~2024-03-08 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 14:05 [PATCH xtables] extensions: xt_TPROXY: add txlate support Florian Westphal
2024-03-08 11:57 ` Phil Sutter
2024-03-08 14:25 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308142527.GD22451@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.