All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Saranya Muruganandam <saranyamohan@google.com>
Cc: Yu Kuai <yukuai1@huaweicloud.com>, Christoph Hellwig <hch@lst.de>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	sashal@kernel.org, Ming Lei <ming.lei@redhat.com>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: regression on BLKRRPART ioctl for EIO
Date: Fri, 8 Mar 2024 17:32:37 +0100	[thread overview]
Message-ID: <20240308163237.GA17159@lst.de> (raw)
In-Reply-To: <CAP9s-SrXvm5MfhXCMBYfsEv9xKWqvkkLp2ZjndYrJ65m5x8M_w@mail.gmail.com>

On Thu, Mar 07, 2024 at 10:14:05AM -0800, Saranya Muruganandam wrote:
> > I think we can fix this by returning error from bdev_get_whole() if
> > bdev_disk_changed() failed, this will cause that open disk to fail now,
> > however, I think this can be acceptable.
> 
> Thanks for the response!
> I agree this would fix the regression for the ioctl.
> However, since returning an error from blkdev_get_whole is new
> behavior, I wasn't sure what all parts it affects.
> 
> So this is just a ping to let you know that I am also waiting to hear
> from Christoph.

I'd hate returning a failure and changing the interface, but I haven't
come up with anything better yet.  Let me thing about this a bit more.

  reply	other threads:[~2024-03-08 16:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  4:28 regression on BLKRRPART ioctl for EIO Saranya Muruganandam
2024-02-12 15:44 ` Christoph Hellwig
     [not found]   ` <CAP9s-Sr3_GVYBv-XObPRC9L27jJoQqX40d8g3gysEmy6VdQS1Q@mail.gmail.com>
2024-02-13  4:01     ` Saranya Muruganandam
2024-02-27  2:38       ` Saranya Muruganandam
2024-02-27  3:13         ` Yu Kuai
2024-03-07 18:14           ` Saranya Muruganandam
2024-03-08 16:32             ` Christoph Hellwig [this message]
2024-03-20  0:20               ` Saranya Muruganandam
2024-03-20  1:51                 ` Christoph Hellwig
2024-04-05  2:04                   ` Saranya Muruganandam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308163237.GA17159@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=saranyamohan@google.com \
    --cc=sashal@kernel.org \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.