From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Daniil Dulov <d.dulov@aladdin.ru>,
Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: phy: mdio-bcm-unimac: Cast denominator to unsigned long to avoid overflow
Date: Fri, 8 Mar 2024 19:52:19 -0800 [thread overview]
Message-ID: <20240308195219.542550eb@kernel.org> (raw)
In-Reply-To: <5592aeca-608f-4817-8848-99deb2815ddc@broadcom.com>
On Thu, 7 Mar 2024 12:21:26 -0800 Florian Fainelli wrote:
> On 3/7/2024 5:19 AM, Daniil Dulov wrote:
> > The expression priv->clk_freq * 2 can lead to overflow that will cause
> > a division by zero. So, let's cast it to unsigned long to avoid it.
>
> It will not in real life because the maximum clock frequency is 250MHz,
> but it also does not hurt.
If that's the case - Daniil, could you respin against net-next without
the Fixes tag? Otherwise it'll cause a conflict, if it's not a real
issue no point creating an extra hassle.
--
pw-bot: cr
prev parent reply other threads:[~2024-03-09 3:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 13:19 [PATCH] net: phy: mdio-bcm-unimac: Cast denominator to unsigned long to avoid overflow Daniil Dulov
2024-03-07 20:21 ` Florian Fainelli
2024-03-09 3:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308195219.542550eb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=d.dulov@aladdin.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.