From: Simon Horman <horms@kernel.org>
To: Aleksandr Mishin <amishin@t-argos.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kees Cook <keescook@chromium.org>,
Justin Stitt <justinstitt@google.com>,
Felix Manlunas <felix.manlunas@cavium.com>,
Satanand Burla <satananda.burla@cavium.com>,
Raghu Vatsavayi <raghu.vatsavayi@cavium.com>,
Vijaya Mohan Guvva <vijaya.guvva@cavium.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] liquidio: Fix potential null pointer dereference
Date: Fri, 8 Mar 2024 20:19:11 +0000 [thread overview]
Message-ID: <20240308201911.GB603911@kernel.org> (raw)
In-Reply-To: <20240307092932.18419-1-amishin@t-argos.ru>
On Thu, Mar 07, 2024 at 12:29:32PM +0300, Aleksandr Mishin wrote:
> In lio_vf_rep_copy_packet() pg_info->page is compared to a NULL value,
> but then it is unconditionally passed to skb_add_rx_frag() which could
> lead to null pointer dereference.
> Fix this bug by moving skb_add_rx_frag() into conditional scope.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 1f233f327913 (liquidio: switchdev support for LiquidIO NIC)
A correct format for the tag above is:
Fixes: 1f233f327913 ("liquidio: switchdev support for LiquidIO NIC")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
I guess this code is never hit.
But I agree this should be fixed.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-08 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 9:29 [PATCH] liquidio: Fix potential null pointer dereference Aleksandr Mishin
2024-03-08 20:19 ` Simon Horman [this message]
2024-03-09 20:45 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308201911.GB603911@kernel.org \
--to=horms@kernel.org \
--cc=amishin@t-argos.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=felix.manlunas@cavium.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
--cc=vijaya.guvva@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.