From: Simon Horman <horms@kernel.org>
To: thomas.perrot@bootlin.com
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: macb: remove change_mtu callback
Date: Sat, 9 Mar 2024 14:54:41 +0000 [thread overview]
Message-ID: <20240309145441.GA4701@kernel.org> (raw)
In-Reply-To: <20240308155330.1610616-1-thomas.perrot@bootlin.com>
On Fri, Mar 08, 2024 at 04:53:30PM +0100, thomas.perrot@bootlin.com wrote:
> From: Thomas Perrot <thomas.perrot@bootlin.com>
>
> Because it doesn't allow MTU changes when the interface is up, although
> it is not necessary.
>
> This callback has been added to add in a first implementation of the Jumbo
> support [1],since it has been reworked and moved to the probe [2].
>
> [1] commit a5898ea09aad ("net: macb: Add change_mtu callback with
> jumbo support")
> [2] commit 44770e1180de ("ethernet: use core min/max MTU checking")
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
Hi Thomas,
Perhaps it is worth mentioning that after this patch the core will set the
MTU, regardless of if the interface is up or not.
prev parent reply other threads:[~2024-03-09 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 15:53 [PATCH] net: macb: remove change_mtu callback thomas.perrot
2024-03-09 14:54 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240309145441.GA4701@kernel.org \
--to=horms@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=thomas.perrot@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.