From: "Michael Büsch" <m@bues.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ying Sun <sunying@isrc.iscas.ac.cn>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH] ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol
Date: Sun, 10 Mar 2024 01:34:39 +0100 [thread overview]
Message-ID: <20240310013439.44682105@barney> (raw)
In-Reply-To: <20240309224540.22682-1-rdunlap@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Sat, 9 Mar 2024 14:45:38 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> -static inline void __cold __ssb_dma_not_implemented(struct ssb_device *dev)
> -{
> -#ifdef CONFIG_SSB_DEBUG
> - printk(KERN_ERR "SSB: BUG! Calling DMA API for "
> - "unsupported bustype %d\n", dev->bus->bustype);
> -#endif /* DEBUG */
> -}
> -
> #ifdef CONFIG_SSB_PCIHOST
> /* PCI-host wrapper driver */
> extern int ssb_pcihost_register(struct pci_driver *driver);
> diff -- a/drivers/ssb/main.c b/drivers/ssb/main.c
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1144,7 +1144,6 @@ u32 ssb_dma_translation(struct ssb_devic
> return SSB_PCI_DMA;
> }
> default:
> - __ssb_dma_not_implemented(dev);
> }
> return 0;
> }
>
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-10 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 22:45 [PATCH] ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol Randy Dunlap
2024-03-10 0:34 ` Michael Büsch [this message]
2024-03-12 15:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240310013439.44682105@barney \
--to=m@bues.ch \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sunying@isrc.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.