All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: linke li <lilinke99@qq.com>
Cc: Bernard Metzler <bmt@zurich.ibm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/siw: Reuse value read using READ_ONCE instead of re-reading it
Date: Sun, 10 Mar 2024 13:33:06 +0200	[thread overview]
Message-ID: <20240310113306.GF12921@unreal> (raw)
In-Reply-To: <tencent_32C3AEB0599DF0A0010A862439636CDA2707@qq.com>

On Sat, Mar 09, 2024 at 08:27:16PM +0800, linke li wrote:
> In siw_orqe_start_rx, the orqe's flag in the if condition is read using
> READ_ONCE, checked, and then re-read, voiding all guarantees of the
> checks. Reuse the value that was read by READ_ONCE to ensure the
> consistency of the flags throughout the function.

Please read include/asm-generic/rwonce.h comments when READ_ONCE() is used.
There is no value in caching the output of READ_ONCE().

Thanks

  parent reply	other threads:[~2024-03-10 11:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-09 12:27 [PATCH] RDMA/siw: Reuse value read using READ_ONCE instead of re-reading it linke li
2024-03-10  4:53 ` Zhu Yanjun
2024-03-10 12:36   ` linke li
2024-03-10 17:00     ` Greg Sword
2024-03-11  2:57       ` linke li
2024-03-11  8:17         ` Zhu Yanjun
2024-03-10 11:33 ` Leon Romanovsky [this message]
2024-03-10 12:15   ` linke li
2024-03-10 19:19     ` Leon Romanovsky
2024-03-11  2:34       ` linke li
2024-03-11  5:11         ` Zhu Yanjun
2024-03-10 17:02   ` Greg Sword
2024-03-11 14:14 ` Bernard Metzler
2024-03-12  1:30   ` linke li
2024-03-12  7:57     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240310113306.GF12921@unreal \
    --to=leon@kernel.org \
    --cc=bmt@zurich.ibm.com \
    --cc=jgg@ziepe.ca \
    --cc=lilinke99@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.