From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0437E28375 for ; Sun, 10 Mar 2024 13:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710076254; cv=none; b=LxfPirvEGfOb6OozsazGedgCES2YVXmCenmrVZ+tFmyv31fc/C8H3lwe1Y3HIZXrekg6CyjhEWk9YVksrtb9ocBbyIkqkuyqGeLvpTUliruecNT+KS0FbVkuMuKWSNGTN5ptC9GiamA+2jwgck+rVnB3ySMlb9hLMTr768RJxlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710076254; c=relaxed/simple; bh=ax2RNJorpp3TSFA3u6t7l1IpR8HjaNKlGKbBlwXPHTo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SiREEQIjVjHrmLzcSkEq7hBpLbNAbQ4dQkuH63vNI4vrKZo2BEOM9xrxfZTH/jOWD5Sui1UaMNevVzmRC2QsjsUwRs0A5uxdWQmSWtPajjwgPRUaawvfGydihw56gts0PYLuwj1/BcTZv2ebbz58heoMRHh5x6wqFrvTfPuw1r4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Oi9ktv6a; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oi9ktv6a" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1dd3bdb6e9eso21218295ad.3 for ; Sun, 10 Mar 2024 06:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710076252; x=1710681052; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=au7P4O6xCDCWvwO0tgkblYFVdWtoYF+Jl11SBGPbJW4=; b=Oi9ktv6aoBxop11GbT/HxE4090A+KghAC8286wIRm5uJfMhgCStm+OF1SnRYelglqt oaUwq34rJ2Kxs3gKrdC9uQ8FXF2ZtKnJthyQpSSdfVjKqEJCJvgKMVIVCRC16SQb7D5U TcePeRHiAd1sVs6wu7FGEYv9uBBrr4FneT+FOa84J6yXGYIcEWxqK13fvtGRstgOGjUy 0e0e4cqXYcm5MmoJZjMoBI5tCTH5UMEat6eCdh3B9kbV53V7TYPqlfYxo0wtjEuGK3in RTs5TEUT+V4HdlkQxSxFI1LZSOCb5QQDV+9jnS/6FGGRXZsSOAJOV9BOwEM2l4/H9xQr gCKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710076252; x=1710681052; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=au7P4O6xCDCWvwO0tgkblYFVdWtoYF+Jl11SBGPbJW4=; b=mZUvgYB3qN6f+N5K4lspMtTs5Sp5XJMbPeptRzVkXMsZ6SYq98mH4SP+ynAATsje4a +ArNyJZ2VJVof66JP2OegjV1GH2L8YXgGVNlLgJ9zfYgIzjdzmYL5yJ1HKz8y+2khKMa mdNma62nJE19xYnyc4tREeS7Z4YJcIFY7klIJv21cL8TIuBX+6NYG4GbZIrw27CkeEfZ SPbGTlFAUjfNYV++O+2I5JX5eTbLtcP0NWkR9EbKzGlv2VCUbq6I5lwqt05NWnxUt5r+ Ur6a4ySWKSdnz0Bw6RgDq/6FV/+DnBE9QR7U+2NbNDUFbeJLsFR0FxTwU2Clel6UnAcq wgPA== X-Forwarded-Encrypted: i=1; AJvYcCUf0IRWMtj07pgWIIa4WvFmQn8cBjo5BP5bhiS3LNtZYi4sv3VyCBKwshqX5PawYdRxVBgNDDAC5BHMVpFSPKeHtcP+Q+YMnWJJ X-Gm-Message-State: AOJu0YxP4gr0AfWR1mAw7d9xyKRtv/kuTtFuYkwCYdhPvKoYjv1NDBox Na5LXREw5iYVYdqr3JAKR8t63/Vt83ttVOC/NYjjamhx1e9bmxR8t9rzXSXP5w== X-Google-Smtp-Source: AGHT+IFuv9OaGeFP6KlGcGd9oQzt86zGm2DdkpeYjp6iGs11PIU4RxOlG2h6k/PX/NU8+J70mccttg== X-Received: by 2002:a17:902:c952:b0:1db:f6b0:92d with SMTP id i18-20020a170902c95200b001dbf6b0092dmr4686762pla.6.1710076252234; Sun, 10 Mar 2024 06:10:52 -0700 (PDT) Received: from thinkpad ([120.138.12.86]) by smtp.gmail.com with ESMTPSA id i14-20020a17090332ce00b001dd621111e2sm2642256plr.194.2024.03.10.06.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 06:10:51 -0700 (PDT) Date: Sun, 10 Mar 2024 18:40:43 +0530 From: Manivannan Sadhasivam To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , Lei Chuanhua , Jesper Nilsson , Nobuhiro Iwamatsu , Yoshihiro Shimoda , Serge Semin , Damien Le Moal , Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths Message-ID: <20240310131043.GD3390@thinkpad> References: <20240227141256.413055-2-ukleinek@debian.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org> On Tue, Feb 27, 2024 at 03:12:54PM +0100, Uwe Kleine-König wrote: > Drivers that silently fail to probe provide a bad user experience and > make it unnecessarily hard to debug such a failure. Fix it by using > dev_err_probe() instead of a plain return. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Uwe Kleine-König Reviewed-by: Manivannan Sadhasivam - Mani > --- > Hello, > > changes since (implicit) v1, sent with Message-Id: > 20240227111837.395422-2-ukleinek@debian.org: > > - use dev instead of rockchip->pci.dev as noticed by Serge Semin. > - added Reviewed-by: tag for Heiko. I assume he agrees to above > improvement and adding the tag despite the change is fine. > > Best regards > Uwe > > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index d6842141d384..a13ca83ce260 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -225,11 +225,15 @@ static int rockchip_pcie_clk_init(struct rockchip_pcie *rockchip) > > ret = devm_clk_bulk_get_all(dev, &rockchip->clks); > if (ret < 0) > - return ret; > + return dev_err_probe(dev, ret, "failed to get clocks\n"); > > rockchip->clk_cnt = ret; > > - return clk_bulk_prepare_enable(rockchip->clk_cnt, rockchip->clks); > + ret = clk_bulk_prepare_enable(rockchip->clk_cnt, rockchip->clks); > + if (ret) > + return dev_err_probe(dev, ret, "failed to enable clocks\n"); > + > + return 0; > } > > static int rockchip_pcie_resource_get(struct platform_device *pdev, > @@ -237,12 +241,14 @@ static int rockchip_pcie_resource_get(struct platform_device *pdev, > { > rockchip->apb_base = devm_platform_ioremap_resource_byname(pdev, "apb"); > if (IS_ERR(rockchip->apb_base)) > - return PTR_ERR(rockchip->apb_base); > + return dev_err_probe(&pdev->dev, PTR_ERR(rockchip->apb_base), > + "failed to map apb registers\n"); > > rockchip->rst_gpio = devm_gpiod_get_optional(&pdev->dev, "reset", > GPIOD_OUT_HIGH); > if (IS_ERR(rockchip->rst_gpio)) > - return PTR_ERR(rockchip->rst_gpio); > + return dev_err_probe(&pdev->dev, PTR_ERR(rockchip->rst_gpio), > + "failed to get reset gpio\n"); > > rockchip->rst = devm_reset_control_array_get_exclusive(&pdev->dev); > if (IS_ERR(rockchip->rst)) > @@ -320,10 +326,9 @@ static int rockchip_pcie_probe(struct platform_device *pdev) > rockchip->vpcie3v3 = NULL; > } else { > ret = regulator_enable(rockchip->vpcie3v3); > - if (ret) { > - dev_err(dev, "failed to enable vpcie3v3 regulator\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, > + "failed to enable vpcie3v3 regulator\n"); > } > > ret = rockchip_pcie_phy_init(rockchip); > > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07145C54E58 for ; Sun, 10 Mar 2024 13:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r0UTVL4wXy6mNwEJrZWeJRFrQ2wrNuKaYLJN4cHZSc0=; b=4KI4mnjpRLbcOD YgFIi8LW6wnckRADZ6fiuuJ1YBTIPRtnGEipF9vkpqPJMZu6dgdHw0ZnqfvRHFobHYeQwodfDEuHR iyH6PE6doYPqdE7F4Z9LvWnI8aMMYi6fKuevVvv04O+Z8Gz9KsVnad0uOYcv4HFwt7SXW4O0d6E6/ zS2cYyq7DEMSFKdWx3jchrUKHuy+IWlDJaJfQa/MfTT+y4erBQSWU+uS0bDDgVUJhCGh0DTu5Mx0i MOLvY4npLtZvYdQdKqDVUrDMsqUDoRslTBaNx6/k8die9YNQzPBdw3nDWbbsdEoIF2FrI2lTMxNuK O2K/sm8nOJpBx9Vs+jVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjIxK-0000000FnmR-3nAS; Sun, 10 Mar 2024 13:11:10 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjIxG-0000000FnjY-1sND for linux-rockchip@lists.infradead.org; Sun, 10 Mar 2024 13:11:08 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1dbd32cff0bso26156365ad.0 for ; Sun, 10 Mar 2024 06:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710076252; x=1710681052; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=au7P4O6xCDCWvwO0tgkblYFVdWtoYF+Jl11SBGPbJW4=; b=WjnrxH+/E4PTzHPx9IRrOLMQXd9r7unBI57j68DxTLzt7dh3l2IDVsyCXt3vJainmO qOxh8cubkKocAiCdHSeMdf4COKSnMeKfh+oK+AYcs4MLWK5bbqOt3FQ5bLBu2eFvx1FT cJf/m+qqAg+QXe7CzjJEqXdSw4NO/FXcQE9xGw+7jqZ1SpDpY1wXGYWe+vvbsGjCMH09 Kq6GdG+ZftokADqbD/YzZD2nsv/vIGKYbnU3edCzd9mmpwBRD7hwXkw5DKVWNOHaniFc AG7UvdiDbFxrBRItnxlL6/ZfLT0MJn6E0nHenfshmASLSB8gc7IDcvQ0VEYWcEFpX9GF xHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710076252; x=1710681052; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=au7P4O6xCDCWvwO0tgkblYFVdWtoYF+Jl11SBGPbJW4=; b=G28fSwWIE/YbX2ZzGfAZEVjstuOC65LqpPqv2px6ru8r6mhN/6UNePf5DEopFxc8jx F6fmz3OYwnb6WmOEIge0MsoJMVpmBbHsaZ55Hpw5EM4UW3+tHY+yTiifGJvIXWfuGDQ1 Aiu8MQeTha3SMIz/EmOMZvgbkonK23gp0D1/Y/5UTmJ/7n5qyooyx38UBfDWW74OJIZQ cyrlKNOQnQ0dC/vi+v/FdF1SKX8tSCGks5UHMzLRi2HHTdspSSfhDhRh674V25A41JEY novu4l5MxjvMwXayByjz74STKIbfHg9w7jZvFlg0jChwGDOhGmHpI3Fq+MAcHFmAG1Uh iuSQ== X-Forwarded-Encrypted: i=1; AJvYcCWI/Y1i3vLmUeb71YRFjEviOqDzc4OKAGIBy09w1F0TdGlvaYRlLOia6p0ZL9/uuikYFm5rmietxjiLXzF4lw5PLhXBceThRxTk6sE9P/Dv2X53 X-Gm-Message-State: AOJu0YxddJJg/95L9QnyF3QoJOd0TGvXPI8mpgFGih6TGHsaTAdX4nom DGcqRFxEnLOpahwUS0/AYoeHKGSxdKK6swIyUXkUEUVwVnAgM2D6NweaTZk7Ow== X-Google-Smtp-Source: AGHT+IFuv9OaGeFP6KlGcGd9oQzt86zGm2DdkpeYjp6iGs11PIU4RxOlG2h6k/PX/NU8+J70mccttg== X-Received: by 2002:a17:902:c952:b0:1db:f6b0:92d with SMTP id i18-20020a170902c95200b001dbf6b0092dmr4686762pla.6.1710076252234; Sun, 10 Mar 2024 06:10:52 -0700 (PDT) Received: from thinkpad ([120.138.12.86]) by smtp.gmail.com with ESMTPSA id i14-20020a17090332ce00b001dd621111e2sm2642256plr.194.2024.03.10.06.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 06:10:51 -0700 (PDT) Date: Sun, 10 Mar 2024 18:40:43 +0530 From: Manivannan Sadhasivam To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , Lei Chuanhua , Jesper Nilsson , Nobuhiro Iwamatsu , Yoshihiro Shimoda , Serge Semin , Damien Le Moal , Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths Message-ID: <20240310131043.GD3390@thinkpad> References: <20240227141256.413055-2-ukleinek@debian.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240310_061106_524709_C0F2CF78 X-CRM114-Status: GOOD ( 23.67 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjcsIDIwMjQgYXQgMDM6MTI6NTRQTSArMDEwMCwgVXdlIEtsZWluZS1Lw7Zu aWcgd3JvdGU6Cj4gRHJpdmVycyB0aGF0IHNpbGVudGx5IGZhaWwgdG8gcHJvYmUgcHJvdmlkZSBh IGJhZCB1c2VyIGV4cGVyaWVuY2UgYW5kCj4gbWFrZSBpdCB1bm5lY2Vzc2FyaWx5IGhhcmQgdG8g ZGVidWcgc3VjaCBhIGZhaWx1cmUuIEZpeCBpdCBieSB1c2luZwo+IGRldl9lcnJfcHJvYmUoKSBp bnN0ZWFkIG9mIGEgcGxhaW4gcmV0dXJuLgo+IAo+IFJldmlld2VkLWJ5OiBIZWlrbyBTdHVlYm5l ciA8aGVpa29Ac250ZWNoLmRlPgo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1 a2xlaW5la0BkZWJpYW4ub3JnPgoKUmV2aWV3ZWQtYnk6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8 bWFuaXZhbm5hbi5zYWRoYXNpdmFtQGxpbmFyby5vcmc+CgotIE1hbmkKCj4gLS0tCj4gSGVsbG8s Cj4gCj4gY2hhbmdlcyBzaW5jZSAoaW1wbGljaXQpIHYxLCBzZW50IHdpdGggTWVzc2FnZS1JZDoK PiAyMDI0MDIyNzExMTgzNy4zOTU0MjItMi11a2xlaW5la0BkZWJpYW4ub3JnOgo+IAo+ICAtIHVz ZSBkZXYgaW5zdGVhZCBvZiByb2NrY2hpcC0+cGNpLmRldiBhcyBub3RpY2VkIGJ5IFNlcmdlIFNl bWluLgo+ICAtIGFkZGVkIFJldmlld2VkLWJ5OiB0YWcgZm9yIEhlaWtvLiBJIGFzc3VtZSBoZSBh Z3JlZXMgdG8gYWJvdmUKPiAgICBpbXByb3ZlbWVudCBhbmQgYWRkaW5nIHRoZSB0YWcgZGVzcGl0 ZSB0aGUgY2hhbmdlIGlzIGZpbmUuCj4gCj4gQmVzdCByZWdhcmRzCj4gVXdlCj4gCj4gIGRyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYyB8IDIxICsrKysrKysrKysr Ky0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHct cm9ja2NoaXAuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAu Ywo+IGluZGV4IGQ2ODQyMTQxZDM4NC4uYTEzY2E4M2NlMjYwIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYwo+ICsrKyBiL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYwo+IEBAIC0yMjUsMTEgKzIyNSwx NSBAQCBzdGF0aWMgaW50IHJvY2tjaGlwX3BjaWVfY2xrX2luaXQoc3RydWN0IHJvY2tjaGlwX3Bj aWUgKnJvY2tjaGlwKQo+ICAKPiAgCXJldCA9IGRldm1fY2xrX2J1bGtfZ2V0X2FsbChkZXYsICZy b2NrY2hpcC0+Y2xrcyk7Cj4gIAlpZiAocmV0IDwgMCkKPiAtCQlyZXR1cm4gcmV0Owo+ICsJCXJl dHVybiBkZXZfZXJyX3Byb2JlKGRldiwgcmV0LCAiZmFpbGVkIHRvIGdldCBjbG9ja3NcbiIpOwo+ ICAKPiAgCXJvY2tjaGlwLT5jbGtfY250ID0gcmV0Owo+ICAKPiAtCXJldHVybiBjbGtfYnVsa19w cmVwYXJlX2VuYWJsZShyb2NrY2hpcC0+Y2xrX2NudCwgcm9ja2NoaXAtPmNsa3MpOwo+ICsJcmV0 ID0gY2xrX2J1bGtfcHJlcGFyZV9lbmFibGUocm9ja2NoaXAtPmNsa19jbnQsIHJvY2tjaGlwLT5j bGtzKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJm YWlsZWQgdG8gZW5hYmxlIGNsb2Nrc1xuIik7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4g IHN0YXRpYyBpbnQgcm9ja2NoaXBfcGNpZV9yZXNvdXJjZV9nZXQoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldiwKPiBAQCAtMjM3LDEyICsyNDEsMTQgQEAgc3RhdGljIGludCByb2NrY2hpcF9w Y2llX3Jlc291cmNlX2dldChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LAo+ICB7Cj4gIAly b2NrY2hpcC0+YXBiX2Jhc2UgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2VfYnluYW1l KHBkZXYsICJhcGIiKTsKPiAgCWlmIChJU19FUlIocm9ja2NoaXAtPmFwYl9iYXNlKSkKPiAtCQly ZXR1cm4gUFRSX0VSUihyb2NrY2hpcC0+YXBiX2Jhc2UpOwo+ICsJCXJldHVybiBkZXZfZXJyX3By b2JlKCZwZGV2LT5kZXYsIFBUUl9FUlIocm9ja2NoaXAtPmFwYl9iYXNlKSwKPiArCQkJCSAgICAg ImZhaWxlZCB0byBtYXAgYXBiIHJlZ2lzdGVyc1xuIik7Cj4gIAo+ICAJcm9ja2NoaXAtPnJzdF9n cGlvID0gZGV2bV9ncGlvZF9nZXRfb3B0aW9uYWwoJnBkZXYtPmRldiwgInJlc2V0IiwKPiAgCQkJ CQkJICAgICBHUElPRF9PVVRfSElHSCk7Cj4gIAlpZiAoSVNfRVJSKHJvY2tjaGlwLT5yc3RfZ3Bp bykpCj4gLQkJcmV0dXJuIFBUUl9FUlIocm9ja2NoaXAtPnJzdF9ncGlvKTsKPiArCQlyZXR1cm4g ZGV2X2Vycl9wcm9iZSgmcGRldi0+ZGV2LCBQVFJfRVJSKHJvY2tjaGlwLT5yc3RfZ3BpbyksCj4g KwkJCQkgICAgICJmYWlsZWQgdG8gZ2V0IHJlc2V0IGdwaW9cbiIpOwo+ICAKPiAgCXJvY2tjaGlw LT5yc3QgPSBkZXZtX3Jlc2V0X2NvbnRyb2xfYXJyYXlfZ2V0X2V4Y2x1c2l2ZSgmcGRldi0+ZGV2 KTsKPiAgCWlmIChJU19FUlIocm9ja2NoaXAtPnJzdCkpCj4gQEAgLTMyMCwxMCArMzI2LDkgQEAg c3RhdGljIGludCByb2NrY2hpcF9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAkJcm9ja2NoaXAtPnZwY2llM3YzID0gTlVMTDsKPiAgCX0gZWxzZSB7Cj4gIAkJcmV0 ID0gcmVndWxhdG9yX2VuYWJsZShyb2NrY2hpcC0+dnBjaWUzdjMpOwo+IC0JCWlmIChyZXQpIHsK PiAtCQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZW5hYmxlIHZwY2llM3YzIHJlZ3VsYXRvclxu Iik7Cj4gLQkJCXJldHVybiByZXQ7Cj4gLQkJfQo+ICsJCWlmIChyZXQpCj4gKwkJCXJldHVybiBk ZXZfZXJyX3Byb2JlKGRldiwgcmV0LAo+ICsJCQkJCSAgICAgImZhaWxlZCB0byBlbmFibGUgdnBj aWUzdjMgcmVndWxhdG9yXG4iKTsKPiAgCX0KPiAgCj4gIAlyZXQgPSByb2NrY2hpcF9wY2llX3Bo eV9pbml0KHJvY2tjaGlwKTsKPiAKPiBiYXNlLWNvbW1pdDogNjYxMzQ3NmUyMjVlMDkwY2M5YWFk NDliZTdmYTUwNGUyOTBkZDMzZAo+IC0tIAo+IDIuNDMuMAo+IAoKLS0gCuCuruCuo+Cuv+CuteCu o+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DACBC54791 for ; Sun, 10 Mar 2024 13:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jxrJmntWkDScwlbwqWAwjIxD/mkythY0LKQrju0HcnE=; b=rdh4aT4UCjEoDr Wg3VTk8k3mNsz82MPP10/ygHKbRC6w2FBzKIiAKORzqohsY1KztkvjFFv40zktbYYJk3YyCjE9J/K VmwJ1F4STaRtknWBxtLLwM6eORp03nke1iPqeqn+0WvPeKgkqu0ylucsp444Gchn371rsKJAA3Pc9 8Ou07g7zaR/Gz4l/naUHPf9f0dMaAmkt/aA5Y4GfhpAP8QSFFgR6R3KR4rP2XdSywNO/TVqhqFeCG tmAxVKjxqRLT9lRCQDG4uTIGdS29JPWwa571PW5QOGo1xVMeVz2lHv2MCFSEyrzD0i0tsxlvVMx4R lt2wgEzYCdjHaObTqQ/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjIxJ-0000000Fnm9-1UXa; Sun, 10 Mar 2024 13:11:09 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjIxG-0000000FnjZ-1vyT for linux-arm-kernel@lists.infradead.org; Sun, 10 Mar 2024 13:11:08 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1dcab44747bso22957745ad.1 for ; Sun, 10 Mar 2024 06:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710076252; x=1710681052; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=au7P4O6xCDCWvwO0tgkblYFVdWtoYF+Jl11SBGPbJW4=; b=WjnrxH+/E4PTzHPx9IRrOLMQXd9r7unBI57j68DxTLzt7dh3l2IDVsyCXt3vJainmO qOxh8cubkKocAiCdHSeMdf4COKSnMeKfh+oK+AYcs4MLWK5bbqOt3FQ5bLBu2eFvx1FT cJf/m+qqAg+QXe7CzjJEqXdSw4NO/FXcQE9xGw+7jqZ1SpDpY1wXGYWe+vvbsGjCMH09 Kq6GdG+ZftokADqbD/YzZD2nsv/vIGKYbnU3edCzd9mmpwBRD7hwXkw5DKVWNOHaniFc AG7UvdiDbFxrBRItnxlL6/ZfLT0MJn6E0nHenfshmASLSB8gc7IDcvQ0VEYWcEFpX9GF xHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710076252; x=1710681052; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=au7P4O6xCDCWvwO0tgkblYFVdWtoYF+Jl11SBGPbJW4=; b=kZlMXBBDRemV2jtUPlWBkUQRSi+JAuj4GLJdN2vbdK1hcjrbVDB6wjzoYREHxpXOUN dwbz4fm7dZJ+WekSQZJLCAL8V+cnFkgZjHuFxpwj2YkuJRIJbstI7JMp8+X7fRMH9E84 qizsHZHVSoOAyBqZN5aJKpGRN1EO/L6PFt0nkAwJxJojI3NWn48SCKfZlYhvC2ddhZ3y WN7vVeS34GctTI4dU9Pk1+DGWmiM9vnq+NuU4qnrycnNwu8RJ70yresytv/mgijdZa7H wyL0Xq29dhUaB93/Rtr7h7RYO29kE1P6LLO0INifS3Fy/qb/Ns8g5uHAG9SKlQD8qaee tdmw== X-Forwarded-Encrypted: i=1; AJvYcCXvm/EGsWCQxwFNtanbOytDHDoe4gk+lvkamcJI7kalux+A/YuX21juDY2oqR/BEgfJg3jJkz8jmbq04vYVKe1b0srhdwRj4q0mIGlsVwO8Obmw2S4= X-Gm-Message-State: AOJu0Yx5WYOJwgPnwcBK74ujAvOZCOVs5ZbhNsLWkdVDfOA/3dBx4Dp6 3FkUtAABEqwu0lyzp/QPaRr6xebN3vP/30AJfO1Ng+kzzT/2SWHQ4Mz+/N/nhw== X-Google-Smtp-Source: AGHT+IFuv9OaGeFP6KlGcGd9oQzt86zGm2DdkpeYjp6iGs11PIU4RxOlG2h6k/PX/NU8+J70mccttg== X-Received: by 2002:a17:902:c952:b0:1db:f6b0:92d with SMTP id i18-20020a170902c95200b001dbf6b0092dmr4686762pla.6.1710076252234; Sun, 10 Mar 2024 06:10:52 -0700 (PDT) Received: from thinkpad ([120.138.12.86]) by smtp.gmail.com with ESMTPSA id i14-20020a17090332ce00b001dd621111e2sm2642256plr.194.2024.03.10.06.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 06:10:51 -0700 (PDT) Date: Sun, 10 Mar 2024 18:40:43 +0530 From: Manivannan Sadhasivam To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , Lei Chuanhua , Jesper Nilsson , Nobuhiro Iwamatsu , Yoshihiro Shimoda , Serge Semin , Damien Le Moal , Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths Message-ID: <20240310131043.GD3390@thinkpad> References: <20240227141256.413055-2-ukleinek@debian.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240310_061106_526856_23E145CE X-CRM114-Status: GOOD ( 25.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjcsIDIwMjQgYXQgMDM6MTI6NTRQTSArMDEwMCwgVXdlIEtsZWluZS1Lw7Zu aWcgd3JvdGU6Cj4gRHJpdmVycyB0aGF0IHNpbGVudGx5IGZhaWwgdG8gcHJvYmUgcHJvdmlkZSBh IGJhZCB1c2VyIGV4cGVyaWVuY2UgYW5kCj4gbWFrZSBpdCB1bm5lY2Vzc2FyaWx5IGhhcmQgdG8g ZGVidWcgc3VjaCBhIGZhaWx1cmUuIEZpeCBpdCBieSB1c2luZwo+IGRldl9lcnJfcHJvYmUoKSBp bnN0ZWFkIG9mIGEgcGxhaW4gcmV0dXJuLgo+IAo+IFJldmlld2VkLWJ5OiBIZWlrbyBTdHVlYm5l ciA8aGVpa29Ac250ZWNoLmRlPgo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1 a2xlaW5la0BkZWJpYW4ub3JnPgoKUmV2aWV3ZWQtYnk6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8 bWFuaXZhbm5hbi5zYWRoYXNpdmFtQGxpbmFyby5vcmc+CgotIE1hbmkKCj4gLS0tCj4gSGVsbG8s Cj4gCj4gY2hhbmdlcyBzaW5jZSAoaW1wbGljaXQpIHYxLCBzZW50IHdpdGggTWVzc2FnZS1JZDoK PiAyMDI0MDIyNzExMTgzNy4zOTU0MjItMi11a2xlaW5la0BkZWJpYW4ub3JnOgo+IAo+ICAtIHVz ZSBkZXYgaW5zdGVhZCBvZiByb2NrY2hpcC0+cGNpLmRldiBhcyBub3RpY2VkIGJ5IFNlcmdlIFNl bWluLgo+ICAtIGFkZGVkIFJldmlld2VkLWJ5OiB0YWcgZm9yIEhlaWtvLiBJIGFzc3VtZSBoZSBh Z3JlZXMgdG8gYWJvdmUKPiAgICBpbXByb3ZlbWVudCBhbmQgYWRkaW5nIHRoZSB0YWcgZGVzcGl0 ZSB0aGUgY2hhbmdlIGlzIGZpbmUuCj4gCj4gQmVzdCByZWdhcmRzCj4gVXdlCj4gCj4gIGRyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYyB8IDIxICsrKysrKysrKysr Ky0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHct cm9ja2NoaXAuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAu Ywo+IGluZGV4IGQ2ODQyMTQxZDM4NC4uYTEzY2E4M2NlMjYwIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYwo+ICsrKyBiL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYwo+IEBAIC0yMjUsMTEgKzIyNSwx NSBAQCBzdGF0aWMgaW50IHJvY2tjaGlwX3BjaWVfY2xrX2luaXQoc3RydWN0IHJvY2tjaGlwX3Bj aWUgKnJvY2tjaGlwKQo+ICAKPiAgCXJldCA9IGRldm1fY2xrX2J1bGtfZ2V0X2FsbChkZXYsICZy b2NrY2hpcC0+Y2xrcyk7Cj4gIAlpZiAocmV0IDwgMCkKPiAtCQlyZXR1cm4gcmV0Owo+ICsJCXJl dHVybiBkZXZfZXJyX3Byb2JlKGRldiwgcmV0LCAiZmFpbGVkIHRvIGdldCBjbG9ja3NcbiIpOwo+ ICAKPiAgCXJvY2tjaGlwLT5jbGtfY250ID0gcmV0Owo+ICAKPiAtCXJldHVybiBjbGtfYnVsa19w cmVwYXJlX2VuYWJsZShyb2NrY2hpcC0+Y2xrX2NudCwgcm9ja2NoaXAtPmNsa3MpOwo+ICsJcmV0 ID0gY2xrX2J1bGtfcHJlcGFyZV9lbmFibGUocm9ja2NoaXAtPmNsa19jbnQsIHJvY2tjaGlwLT5j bGtzKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJm YWlsZWQgdG8gZW5hYmxlIGNsb2Nrc1xuIik7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4g IHN0YXRpYyBpbnQgcm9ja2NoaXBfcGNpZV9yZXNvdXJjZV9nZXQoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldiwKPiBAQCAtMjM3LDEyICsyNDEsMTQgQEAgc3RhdGljIGludCByb2NrY2hpcF9w Y2llX3Jlc291cmNlX2dldChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LAo+ICB7Cj4gIAly b2NrY2hpcC0+YXBiX2Jhc2UgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2VfYnluYW1l KHBkZXYsICJhcGIiKTsKPiAgCWlmIChJU19FUlIocm9ja2NoaXAtPmFwYl9iYXNlKSkKPiAtCQly ZXR1cm4gUFRSX0VSUihyb2NrY2hpcC0+YXBiX2Jhc2UpOwo+ICsJCXJldHVybiBkZXZfZXJyX3By b2JlKCZwZGV2LT5kZXYsIFBUUl9FUlIocm9ja2NoaXAtPmFwYl9iYXNlKSwKPiArCQkJCSAgICAg ImZhaWxlZCB0byBtYXAgYXBiIHJlZ2lzdGVyc1xuIik7Cj4gIAo+ICAJcm9ja2NoaXAtPnJzdF9n cGlvID0gZGV2bV9ncGlvZF9nZXRfb3B0aW9uYWwoJnBkZXYtPmRldiwgInJlc2V0IiwKPiAgCQkJ CQkJICAgICBHUElPRF9PVVRfSElHSCk7Cj4gIAlpZiAoSVNfRVJSKHJvY2tjaGlwLT5yc3RfZ3Bp bykpCj4gLQkJcmV0dXJuIFBUUl9FUlIocm9ja2NoaXAtPnJzdF9ncGlvKTsKPiArCQlyZXR1cm4g ZGV2X2Vycl9wcm9iZSgmcGRldi0+ZGV2LCBQVFJfRVJSKHJvY2tjaGlwLT5yc3RfZ3BpbyksCj4g KwkJCQkgICAgICJmYWlsZWQgdG8gZ2V0IHJlc2V0IGdwaW9cbiIpOwo+ICAKPiAgCXJvY2tjaGlw LT5yc3QgPSBkZXZtX3Jlc2V0X2NvbnRyb2xfYXJyYXlfZ2V0X2V4Y2x1c2l2ZSgmcGRldi0+ZGV2 KTsKPiAgCWlmIChJU19FUlIocm9ja2NoaXAtPnJzdCkpCj4gQEAgLTMyMCwxMCArMzI2LDkgQEAg c3RhdGljIGludCByb2NrY2hpcF9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAkJcm9ja2NoaXAtPnZwY2llM3YzID0gTlVMTDsKPiAgCX0gZWxzZSB7Cj4gIAkJcmV0 ID0gcmVndWxhdG9yX2VuYWJsZShyb2NrY2hpcC0+dnBjaWUzdjMpOwo+IC0JCWlmIChyZXQpIHsK PiAtCQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZW5hYmxlIHZwY2llM3YzIHJlZ3VsYXRvclxu Iik7Cj4gLQkJCXJldHVybiByZXQ7Cj4gLQkJfQo+ICsJCWlmIChyZXQpCj4gKwkJCXJldHVybiBk ZXZfZXJyX3Byb2JlKGRldiwgcmV0LAo+ICsJCQkJCSAgICAgImZhaWxlZCB0byBlbmFibGUgdnBj aWUzdjMgcmVndWxhdG9yXG4iKTsKPiAgCX0KPiAgCj4gIAlyZXQgPSByb2NrY2hpcF9wY2llX3Bo eV9pbml0KHJvY2tjaGlwKTsKPiAKPiBiYXNlLWNvbW1pdDogNjYxMzQ3NmUyMjVlMDkwY2M5YWFk NDliZTdmYTUwNGUyOTBkZDMzZAo+IC0tIAo+IDIuNDMuMAo+IAoKLS0gCuCuruCuo+Cuv+CuteCu o+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK