From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_tables: fix updating/deleting devices in an existing netdev chain
Date: Sun, 10 Mar 2024 23:03:40 +0100 [thread overview]
Message-ID: <20240310220340.GC16724@breakpoint.cc> (raw)
In-Reply-To: <20240310205008.117707-1-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Updating netdev basechain is broken in many ways.
>
> Keeping a list of pending hooks to be added/deleted in the transaction
> object does not mix well with table flag updates (ie. setting dormant
> flag in table) which operate on the existing basechain hook list.
> Instead, add/delete hook to/from the basechain hook list and allocate
> one transaction object per new device to refers to the hook to
> add/delete.
>
> Add an 'inactive' flag that is set on to identify devices that has been
> already deleted, so double deletion in one batch is not possible.
Do you think it makes sense to remove dormant flag support
for the netdev family?
It would avoid the register/unregister entanglements and might
reduce headaches down the road.
IOW, do you think dormant flag toggling is useful for netdev family?
next prev parent reply other threads:[~2024-03-10 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 20:50 [PATCH nf] netfilter: nf_tables: fix updating/deleting devices in an existing netdev chain Pablo Neira Ayuso
2024-03-10 22:03 ` Florian Westphal [this message]
2024-03-10 22:31 ` Pablo Neira Ayuso
2024-03-10 22:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240310220340.GC16724@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.