From: Simon Horman <horms@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1] netdevsim: replace pr_err with {dev,netdev,}_err wherever possible
Date: Mon, 11 Mar 2024 09:28:43 +0000 [thread overview]
Message-ID: <20240311092843.GK24043@kernel.org> (raw)
In-Reply-To: <20240310015215.4011872-1-dw@davidwei.uk>
On Sat, Mar 09, 2024 at 05:52:15PM -0800, David Wei wrote:
> Replace pr_err() in netdevsim with {dev,netdev,}_err if possible,
> preferring the most specific device available.
>
> Not all instances of pr_err() can be replaced however, as there may not
> be a device to associate the error with, or a device might not be
> available.
>
> Tested by building and running netdevsim/peer.sh selftest.
>
> Signed-off-by: David Wei <dw@davidwei.uk>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-11 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 1:52 [PATCH net-next v1] netdevsim: replace pr_err with {dev,netdev,}_err wherever possible David Wei
2024-03-11 9:28 ` Simon Horman [this message]
2024-03-11 20:07 ` Jakub Kicinski
2024-03-12 22:04 ` David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311092843.GK24043@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.